Dropping eval for function closure and slashes

Stop using eval here in favor of a function that returns the value, also
replacing pipes with slashes to display correctly on mouse hover
This commit is contained in:
Matt Pass
2013-05-10 17:45:11 +01:00
parent 5f0ee6d95e
commit 43ae4ac317

View File

@@ -811,7 +811,7 @@ var ICEcoder = {
targetElem.id = location.replace(/\//g,"|") + "|" + file;
newMouseOver = targetElem.parentNode.onmouseover.toString().replace(shortURL.substring(shortURL.lastIndexOf("|")+1),file).split('\'');
eval("targetElem.parentNode.onmouseover = function() { top.ICEcoder.overFileFolder('"+newMouseOver[1]+"','"+newMouseOver[3]+"');}");
eval("targetElem.parentNode.title = newMouseOver[3];");
targetElem.parentNode.title = function(fileFolder) {return fileFolder.replace(/\|/g,"/");}(newMouseOver[3]);
targetElemPerms = document.getElementById('filesFrame').contentWindow.document.getElementById(shortURL+"_perms");
targetElemPerms.id = location.replace(/\//g,"|") + "|" + file + "_perms";
}