From 43ae4ac3173782999f4bc1f1a0a1eddb4141b750 Mon Sep 17 00:00:00 2001 From: Matt Pass Date: Fri, 10 May 2013 17:45:11 +0100 Subject: [PATCH] Dropping eval for function closure and slashes Stop using eval here in favor of a function that returns the value, also replacing pipes with slashes to display correctly on mouse hover --- lib/ice-coder.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ice-coder.js b/lib/ice-coder.js index ef20c38..6283f36 100644 --- a/lib/ice-coder.js +++ b/lib/ice-coder.js @@ -811,7 +811,7 @@ var ICEcoder = { targetElem.id = location.replace(/\//g,"|") + "|" + file; newMouseOver = targetElem.parentNode.onmouseover.toString().replace(shortURL.substring(shortURL.lastIndexOf("|")+1),file).split('\''); eval("targetElem.parentNode.onmouseover = function() { top.ICEcoder.overFileFolder('"+newMouseOver[1]+"','"+newMouseOver[3]+"');}"); - eval("targetElem.parentNode.title = newMouseOver[3];"); + targetElem.parentNode.title = function(fileFolder) {return fileFolder.replace(/\|/g,"/");}(newMouseOver[3]); targetElemPerms = document.getElementById('filesFrame').contentWindow.document.getElementById(shortURL+"_perms"); targetElemPerms.id = location.replace(/\//g,"|") + "|" + file + "_perms"; }