chore(infra): add nodes’ JS code into linter check & make them lint-passing

.eslintrc.espruino.js

@@ -9,16 +9,22 @@ module.exports = {
   ],
 
   rules: {
-    'no-underscore-dangle': 'off',
-    'func-names': 'off',
-    'space-before-function-paren': ['error', 'never'],
     'comma-dangle': ['error', 'never'],
+    'func-names': 'off',
+    'no-param-reassign': ["error", { "props": false }],
+    'no-underscore-dangle': 'off',
     'object-shorthand': ['error', 'never'],
     'prefer-arrow-callback': 'off',
+    'space-before-function-paren': ['error', 'never'],
   },
 
   globals: {
+    Pin: true,
     analogRead: true,
+    analogWrite: true,
+    digitalRead: true,
+    digitalWrite: true,
+    setWatch: true,
   },
 };
 

nodes/espruino/button.js

@@ -1,6 +1,6 @@
 
 module.exports.setup = function(e) {
-  var pin = new Pin(e.props.pin);
+  const pin = new Pin(e.props.pin);
 
   setWatch(function(evt) {
     e.fire({ state: evt.state });

nodes/espruino/led.js

@@ -4,7 +4,11 @@ module.exports.setup = function(e) {
 };
 
 module.exports.evaluate = function(e) {
-  var b = e.inputs.brightness;
-  b = b * b * b;
-  analogWrite(e.context.pin, b);
+  const b = e.inputs.brightness;
+
+  // Adjust duty cycle as a power function to align brightness
+  // perception by human eye
+  const duty = b * b * b;
+
+  analogWrite(e.context.pin, duty);
 };

nodes/espruino/pot.js

@@ -5,5 +5,4 @@ module.exports.setup = function(e) {
 
 module.exports.evaluate = function(e) {
   e.fire({ value: analogRead(e.context.pin) });
-  return analogRead(pin);
 };

nodes/espruino/servo.js

@@ -4,8 +4,8 @@ module.exports.setup = function(e) {
 };
 
 module.exports.evaluate = function(e) {
-  var minPulse = +e.props.minPulse;
-  var maxPulse = +e.props.maxPulse;
-  var us = minPulse + (maxPulse - minPulse) * e.inputs.value;
+  const minPulse = +e.props.minPulse;
+  const maxPulse = +e.props.maxPulse;
+  const us = minPulse + (maxPulse - minPulse) * e.inputs.value;
   analogWrite(e.context.pin, us / 20000, { freq: 50 });
 };

nodes/js/constBool.js

@@ -1,4 +1,4 @@
 
 module.exports.setup = function(e) {
-  e.fire({value: e.props.value});
+  e.fire({ value: e.props.value });
 };

nodes/js/constNumber.js

@@ -1,4 +1,4 @@
 
 module.exports.setup = function(e) {
-  e.fire({value: e.props.value});
+  e.fire({ value: e.props.value });
 };

nodes/js/constSting.js

@@ -1,4 +1,4 @@
 
 module.exports.setup = function(e) {
-  e.fire({value: e.props.value});
+  e.fire({ value: e.props.value });
 };

nodes/js/either.js

@@ -1,5 +1,5 @@
 
 module.exports.evaluate = function(e) {
-  var out = e.inputs.inp ? e.inputs.trueValue : e.inputs.falseValue;
+  const out = e.inputs.inp ? e.inputs.trueValue : e.inputs.falseValue;
   return { out: out };
 };

nodes/js/latch.js

@@ -4,13 +4,17 @@ module.exports.setup = function(e) {
 };
 
 module.exports.evaluate = function(e) {
-  var inputs = e.inputs;
-  var ctx = e.context;
+  const inputs = e.inputs;
+  let newState;
+
   if (inputs.toggle) {
-    return (ctx.state = !ctx.state);
+    newState = !e.context.state;
   } else if (inputs.set) {
-    return (ctx.state = true);
+    newState = true;
   } else /* if (inputs.reset) */ {
-    return (ctx.state = false);
+    newState = false;
   }
+
+  e.context.state = newState;
+  return { state: newState };
 };

nodes/js/map.js

@@ -1,8 +1,9 @@
 
 module.exports.evaluate = function(e) {
-  var inputs = e.inputs;
-  var k = (inputs.inp - inputs.inA) / (inputs.inB - inputs.inA);
-  var out = inputs.outA + k * (inputs.outB - inputs.outA);
+  const inputs = e.inputs;
+  const k = (inputs.inp - inputs.inA) / (inputs.inB - inputs.inA);
+
+  let out = inputs.outA + k * (inputs.outB - inputs.outA);
 
   if (inputs.clip) {
     if (inputs.outB > inputs.outA) {

nodes/js/not.js

@@ -1,4 +1,4 @@
 
 module.exports.evaluate = function(e) {
-  return {out: !e.inputs.in};
+  return { out: !e.inputs.in };
 };

package.json

@@ -8,7 +8,7 @@
     "build-chrome": "webpack --progress --colors --config webpack/chrome-dev.js",
     "dev-chrome": "webpack --watch --progress --colors --config webpack/chrome-dev.js",
     "lint-es6": "eslint --ext .js --ext .jsx ./app ./targets ./test --ignore-path targets/xod-espruino/runtime.js || true",
-    "lint-espruino": "eslint --config .eslintrc.espruino.js targets/xod-espruino/runtime.js || true",
+    "lint-espruino": "eslint --config .eslintrc.espruino.js targets/xod-espruino/runtime.js nodes/js nodes/espruino || true",
     "lint": "npm-run-all lint-es6 lint-espruino",
     "test": "mocha-webpack \"test/**/*Spec.js\"",
     "travis": "npm-run-all --continue-on-error lint test"