mirror of
https://github.com/trezor/trezor-firmware.git
synced 2026-02-20 00:33:30 +01:00
chore(ci): remove obsolete test_python_support
[no changelog]
This commit is contained in:
10
.github/workflows/common.yml
vendored
10
.github/workflows/common.yml
vendored
@@ -79,16 +79,6 @@ jobs:
|
||||
# LD_LIBRARY_PATH workaround: https://discourse.nixos.org/t/nixpkgs-nixos-unstable-many-package-fail-with-glibc-2-38-not-found/35078 https://github.com/NixOS/nixpkgs/issues/287764
|
||||
- run: nix-shell --arg fullDeps true --run "unset LD_LIBRARY_PATH && cd python && uv run tox"
|
||||
|
||||
python_support_test:
|
||||
name: Python support test
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
with:
|
||||
submodules: recursive
|
||||
- uses: ./.github/actions/environment
|
||||
- run: nix-shell --run "uv run make python_support_check"
|
||||
|
||||
storage_test:
|
||||
name: Storage test
|
||||
# TODO: only for changes in storage/
|
||||
|
||||
3
Makefile
3
Makefile
@@ -98,9 +98,6 @@ ruststyle_check:
|
||||
@cd core/embed/rust ; cargo fmt -- --check
|
||||
@cd rust/trezor-client ; cargo fmt -- --check
|
||||
|
||||
python_support_check:
|
||||
./tests/test_python_support.py
|
||||
|
||||
## code generation commands:
|
||||
|
||||
mocks: ## generate mock python headers from C modules
|
||||
|
||||
@@ -1,61 +0,0 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Verifying that all the tools can be run even by older python versions.
|
||||
|
||||
Uses `pyright --pythonversion 3.X <path>` output to check for substrings that
|
||||
indicate the type-hints in the code are not compatible with this version.
|
||||
"""
|
||||
|
||||
import os
|
||||
import subprocess
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
HERE = Path(__file__).resolve().parent
|
||||
ROOT_DIR = HERE.parent
|
||||
|
||||
EXIT_CODE = 0
|
||||
|
||||
os.chdir(ROOT_DIR)
|
||||
|
||||
versions_to_check = [
|
||||
"3.7",
|
||||
"3.8",
|
||||
"3.9",
|
||||
]
|
||||
|
||||
dirs_to_check = [
|
||||
"tools",
|
||||
"common",
|
||||
"core/tools",
|
||||
"core/site_scons",
|
||||
]
|
||||
|
||||
signs_of_issues = [
|
||||
"is unknown import symbol", # we need to import some stuff from typing_extensions instead of typing
|
||||
"will generate runtime exception", # happens when using `dict` or `list` as a type alias
|
||||
]
|
||||
|
||||
|
||||
def check_directory(path: str, python_version: str) -> None:
|
||||
global EXIT_CODE
|
||||
cmd = (
|
||||
"pyright",
|
||||
"--pythonversion",
|
||||
python_version,
|
||||
path,
|
||||
)
|
||||
|
||||
result = subprocess.run(cmd, stdout=subprocess.PIPE, text=True)
|
||||
for line in result.stdout.splitlines():
|
||||
if any(sign in line for sign in signs_of_issues):
|
||||
print(line)
|
||||
EXIT_CODE = 1
|
||||
|
||||
|
||||
for version in versions_to_check:
|
||||
print(f"Checking python version {version}")
|
||||
for dir_to_check in dirs_to_check:
|
||||
check_directory(dir_to_check, version)
|
||||
|
||||
sys.exit(EXIT_CODE)
|
||||
Reference in New Issue
Block a user