Aleksander Machniak
eeac27ea81
PHPDoc fixes
2024-01-24 15:41:34 +01:00
Aleksander Machniak
6f8fc03fe8
Solve some phpstan errors
2024-01-24 14:20:21 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
54f4aa33f9
Fix CS - imports ( #9316 )
...
* fix Tests\Browser\TestCase imports
* fix remaining imports
* fix PHPUnit\Framework\TestCase imports
* import GuzzleHttp\Client
* fix remaining
* "php_unit_method_casing" is not todo
* fix "single_line_comment_spacing"
* fix 2nd commit done using older fixer
2024-01-21 19:13:31 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Aleksander Machniak
5761336253
Cleanup some uses of rcube_result_set, avoid calling ->next()
2024-01-17 19:27:09 +01:00
Edouard Vanbelle
77aca18bd5
Refactorize request_access_token() returning a simple boolean ( #9299 )
2024-01-06 08:34:12 +01:00
Michael Voříšek
a797873ef5
Fix "phpdoc_no_empty_return" CS ( #9302 )
...
* replace void with never return type
* replace "return void" phpdoc with native type in tests
* replace "return void" phpdoc with native type in rcube_addressbook
* replace "return void" phpdoc with native type in rcmail_oauth
* fix remaining
2024-01-05 19:03:58 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Aleksander Machniak
7a07ce57f5
Test but do not output (while testing) some OAuth errors
2024-01-01 10:36:48 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Edouard Vanbelle
ffa298d41c
OAuth: feat: use OIDC claims on user creation ( #9286 )
...
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr >
2023-12-29 19:10:37 +01:00
Edouard Vanbelle
14f092c7af
OAuth: security: add support of nonce ( #9288 )
...
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr >
2023-12-29 19:05:14 +01:00
Edouard Vanbelle
9c769c288b
OAuth: Add support for PKCE ( #9287 )
...
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr >
2023-12-27 10:57:42 +01:00
Edouard Vanbelle
320bdefb57
OAuth: code refactorization ( #9274 )
...
* OAuth: Refact.: migrate login flow into hooks (more evolutive code and less dependency to core code)
* OAuth: Fix: logger prefix (include prefix during login phase)
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr >
2023-12-26 09:07:50 +01:00
Edouard Vanbelle
0e4c35797d
core: correct coding style warning ( #9284 )
...
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr >
2023-12-26 09:04:54 +01:00
kc
504cdb89a5
Fix OAuth for Kinde && support smtp w/o authentication ( #9244 , #9183 )
...
Co-authored-by: kc <kc@white.colors.lan >
2023-12-23 17:31:31 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
a9167a0d2f
Fix "static_lambda" CS ( #9276 )
2023-12-20 20:01:00 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Aleksander Machniak
622cc8d555
CS fixes
2023-12-17 11:11:00 +01:00
Aleksander Machniak
f363481ca1
CS improvements, fix unwanted output in tests
2023-12-17 10:08:21 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
93946f4ca7
Fix "self_accessor" PHP CS Fixer rule ( #9269 )
2023-12-17 09:44:43 +01:00
Edouard Vanbelle
588a879107
OAuth improvements ( #9217 )
...
- OAuth: Add `oauth_config_uri` - support OAuth/OpenIDC discovery (#8201 )
- OAuth: Add `oauth_logout_uri` - allow invalidating the OAUTH-Session on logout (#8057 )
- OAuth: Support for OpenID Connect RP-Initiated Logout (#9109 )
- OAuth: Add support of OAUTHBEARER (#9217 )
- OAuth: Add `oauth_debug` option (#9217 )
- OAuth: Fix: missing config `oauth_provider_name` in rcmail_oauth's constructor (#9217 )
- OAuth: Refactor: move display to the rcmail_oauth class and use `loginform_content` hook (#9217 )
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr >
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:13:07 +01:00
Michael Voříšek
1aef271290
Fix class/method names case typos ( #9261 )
...
* fix Mail_Mime case
* fix StdErrMock case
* fix method calls case
2023-12-16 15:39:59 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Michael Voříšek
f9a9ec49b0
Fix format_date with "x" format for Windows ( #9250 )
...
* Fix format_date with "x" format for Windows
* set default Intl locale and use it
* harden default test config
2023-12-10 15:30:22 +01:00
Aleksander Machniak
104a992e35
Fix PHP8 warnings ( #9242 )
2023-12-09 08:47:35 +01:00
Aleksander Machniak
17eec91deb
Fix PHP8 warning ( #9235 )
...
And added tests for utils/modcss action
2023-12-03 10:40:57 +01:00
Philip Weir
89ce052242
Unify HTML editor font settings ( #9177 )
2023-11-25 14:23:17 +01:00
Aleksander Machniak
7c1665b08f
Fix PHP8 warning ( #9160 )
2023-10-08 09:51:37 +02:00
Aleksander Machniak
20447fa962
Fix PHP8 warnings ( #9142 )
2023-09-18 11:15:33 +02:00
Aleksander Machniak
68876f073d
Fix various PHP warnings ( #9098 )
2023-08-20 08:43:05 +02:00
Ashus
50b53776ff
Fix errors while upgrading plugins with SQL migrations ( #9092 )
2023-08-20 07:23:04 +02:00
Aleksander Machniak
6f35b2cc5b
More fixes regarding rcmail::url() ( #9052 )
2023-07-10 18:27:56 +02:00
Aleksander Machniak
d2e8a889c4
Fix regression that broke use_secure_urls feature ( #9052 )
2023-07-09 11:23:44 +02:00
Aleksander Machniak
57b161111f
Fix bug where installto.sh/update.sh scripts were removing some essential options from the config file ( #9051 )
...
Plus small code improvements
2023-07-08 09:10:45 +02:00
Aleksander Machniak
7ccb8fa21a
Add package name to the "Updating database schema..." output
2023-06-08 09:49:54 +02:00
Aleksander Machniak
374a4a5e25
Prefer 8bit over quoted-printable for HTML parts, when force_7bit is disabled ( #8477 )
2023-05-28 11:04:43 +02:00
Aleksander Machniak
bac152444b
Fix listing subfolders of Trash in logout actions on servers with specific NAMESPACE definition
2023-05-10 21:34:19 +02:00
Aleksander Machniak
a20445fcc5
Fix potential HTTP protocol version mismatch ( #8982 )
2023-05-07 16:37:17 +02:00
Aleksander Machniak
ef9d345441
Drop dependency on JsTimeZoneDetect ( #8965 )
2023-04-09 16:06:00 +02:00
Aleksander Machniak
43af3e0e58
Move get_host() from rcube_utils to rcmail_utils, de-duplicate
2023-03-05 18:33:57 +01:00
Aleksander Machniak
ed73265c76
Create rcmail_install::unzip() and simplify code
2023-03-05 11:30:11 +01:00
Aleksander Machniak
77e96c7bc2
Fix duplicate recipients in "To" and "Cc" on reply ( #8912 )
2023-02-26 20:54:10 +01:00
Aleksander Machniak
156e480a26
Fix invalid onclick handler on the logo image when using non-array skin_logo setting ( #8933 )
2023-02-26 10:14:38 +01:00
Thomas Bruederli
c4c9fa0242
Fix JWT decoding with url safe base64 schema ( #8890 )
2023-01-28 22:05:59 +01:00
