Commit Graph

2657 Commits

Author SHA1 Message Date
Aleksander Machniak
d03767b7f1 OAuth: improve token refresh - check token also in the keep-alive action 2025-03-18 13:58:54 +01:00
Aleksander Machniak
91f4e289b2 Merge branch 'master' of github.com:roundcube/roundcubemail 2025-03-16 13:33:38 +01:00
Aleksander Machniak
9afeb0174e Use PHPStan v2 2025-03-16 13:33:15 +01:00
Pablo Zmdl
99236f3be4 Fix washing html from rcube_attachment_handler (#9785)
This probably wasn't implemented previously because HTML-parts usually
didn't run through get.php.
2025-03-16 12:45:15 +01:00
Aleksander Machniak
29d0eba3db Add rcmail_oauth::is_token_valid() method 2025-03-14 12:12:56 +01:00
Aleksander Machniak
94fd5a0f80 CS fixes (for the new fixer version rules) 2025-02-23 11:51:27 +01:00
Aleksander Machniak
a9b1ca34f3 Update min PHP version check, cleanup outdated checks/comments 2025-02-23 11:18:50 +01:00
Philip Weir
5e57ef83bd Add asset url to additional logo paths (#9768) 2025-02-11 18:10:48 +01:00
Aleksander Machniak
64df318a73 Add static files server (#9294)
Make use of public_html mandatory
2025-02-09 14:10:50 +01:00
Philip Weir
ccede1f272 Update links in comments and config to https where available (#9759) 2025-01-26 13:34:57 +01:00
Aleksander Machniak
94a6144a87 CS fix 2024-12-03 12:56:21 +01:00
Aleksander Machniak
c516f6e26f Fix Oauth issues with use_secure_urls=true (#9722) 2024-12-03 12:44:12 +01:00
Michael Voříšek
efcdce84ba Keep phpstan strict rules testing (#9424)
* Revert "Get rid of phpstan/phpstan-strict-rules"

This reverts commit ff59ade31a.

* drop phpstan baseline

* fix foreach phpstan issue

* adjust for rebase

* fix method call case

* ignore one phpstan error even after isset
2024-11-20 08:13:16 +01:00
Aleksander Machniak
9ab47d94fa Don't initialize OAuth handler in CLI 2024-10-28 11:45:55 +01:00
Aleksander Machniak
83417f5883 OAuth: Add a flag to the 'authenticate' hook arguments indicating SSO is in use
This way plugins can react to it, e.g. 2FA plugins can skip asking for the second factor
2024-09-12 09:39:49 +02:00
Aleksander Machniak
c5a861114e OAuth: Refresh token is optional (#9626) 2024-09-06 11:17:30 +02:00
Aleksander Machniak
d26e4354f7 Add small sanity check 2024-09-02 13:54:31 +02:00
Aleksander Machniak
0cf65ad2b1 OAuth: Support standard authentication with short-living password received with OIDC token (#9530) 2024-08-29 13:17:54 +02:00
Aleksander Machniak
a134c83f14 Cleanup 2024-08-29 13:11:45 +02:00
Aleksander Machniak
4023931ed3 OAuth: Fix some PHP warnings and improve debug logging 2024-08-27 19:33:03 +02:00
Aleksander Machniak
e12e273c0c More tests 2024-08-04 10:28:16 +02:00
Aleksander Machniak
c706575a0b CS fix 2024-07-31 18:11:51 +02:00
Michael Voříšek
6a5f9ee7ce Add override method attributes (#9272) 2024-06-02 15:57:56 +02:00
Pablo Zmdl
54b5e14933 Show quota only if sensible (#9366)
If a quota is not supported, or its value is unknown or unlimited, don't show the info element.
2024-06-01 11:25:47 +02:00
Philip Weir
24ae59b05f Add skin_extends JS env var containing name(s) of base skins extended by current skin (#9440) 2024-06-01 09:02:49 +02:00
Aleksander Machniak
cfd108399e Simplify use of rcube::raise_error() 2024-05-17 15:43:17 +02:00
Philip Weir
0c0f9fe8cf Add skin info to about dialog (#9441) 2024-05-16 16:53:27 +02:00
Aleksander Machniak
6c54254a2f Fix folders hierarchy when special folders are subfolders of INBOX, with no personal namespace prefix (#9452) 2024-05-16 16:22:57 +02:00
Edouard Vanbelle
f71ae0298a oauth: select auth scheme (XOAUTH2 vs OAUTHBEARER) (#9289) 2024-04-21 11:52:05 +02:00
Michael Voříšek
a30e0ad438 Infer file/line location in rcube::raise_error() from backtrace (#9422)
* \n\s+'file' => __FILE__,

* \n\s+'line' => __LINE__,

* 'line' => __LINE__, 'file' => __FILE__,

* 'file' => __FILE__, 'line' => __LINE__,

* rest

* more

* improve cs

* more cs

* revert rcube_utils::preg_error changes

* impl file/line from backtrace

* Revert "revert rcube_utils::preg_error changes"
2024-04-21 11:48:35 +02:00
Aleksander Machniak
ff59ade31a Get rid of phpstan/phpstan-strict-rules 2024-04-21 11:33:51 +02:00
Aleksander Machniak
7fa50e49e1 Fix PHP8 warnings (#9388) 2024-04-13 08:42:01 +02:00
Michael Voříšek
1e360999b2 Use composer autoloader for bundled plugins testing (#9412)
* use fixed "roundcube/plugin-installer"

* Use composer autoloader for plugins testing

* cherrypick remaining from 9241 related with testing

* minor legacy autoload improvements
2024-04-11 18:28:46 +02:00
Aleksander Machniak
47172b4bfc Fix regression 2024-04-01 12:28:57 +02:00
Aleksander Machniak
5c603344fe Code improvements 2024-04-01 11:50:56 +02:00
Aleksander Machniak
20d9edce04 Code improvements 2024-03-31 19:22:56 +02:00
Aleksander Machniak
8adb052d35 Code improvements, PHPDoc fixes 2024-03-30 14:17:34 +01:00
Aleksander Machniak
8133acba68 Code improvements (and fixes to recent commits) 2024-03-24 12:06:39 +01:00
Aleksander Machniak
5ed3b29a0a Code improvements 2024-03-16 21:30:10 +01:00
Aleksander Machniak
4ea35f44ff CS fixes 2024-03-16 14:26:59 +01:00
Aleksander Machniak
02e49ed236 Fix phpstan errors 2024-03-10 18:37:52 +01:00
Aleksander Machniak
97cdcf88b8 Fix some phpstan errors 2024-03-09 12:54:40 +01:00
Aleksander Machniak
a1f39f47b7 Fix phpstan errors 2024-02-10 19:20:04 +01:00
Aleksander Machniak
966274d835 Fix phpstan errors 2024-02-09 21:11:50 +01:00
Michael Voříšek
332c165d28 Fix some basic JS CS (#9328)
* fix "nonblock-statement-body-position" (fixed already)

* fix "comma-dangle"

* fix "no-regex-spaces"

* fix "new-parens"

* fix "object-curly-newline"

* fix "object-property-newline"

* fix "spaced-comment" semimanually

* fix "no-constant-condition" manually

* fix "unicorn/no-hex-escape"

* fix "unicorn/escape-case"

* fix "quote-props"

* fix "no-whitespace-before-property" - fix bug/typo

* fix "unicorn/empty-brace-spaces"

* fix "keyword-spacing"

* fix "dot-notation"

* fix "no-return-assign" manually

* fix "padding-line-between-statements"

* fix "key-spacing"

* fix "no-else-return" semimanually

* fix some "no-undef"

* fix case cs

* Revert "fix "padding-line-between-statements""

* improve switch/case format I.

* improve switch/case format II.

regex: (^ *(break|return).*)\n *(\n)

* fix safe "eqeqeq"

* fix "radix"

* fix v3.49.0 CS (static providers)

* fix "string_implicit_backslashes" in php files

* fix comments align

* fix test static providers

* fix stan

* disable "final_internal_class" rule
2024-02-06 08:28:19 +01:00
Michael Voříšek
d18406a8bd Fix binary operator spaces CS (#9330)
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
1f6a9b8843 Fix phpstan errors regarding rcube_uploads trait methods 2024-01-27 19:17:41 +01:00
Aleksander Machniak
34500a4fa4 Fix "missing return statement" phpstan errors 2024-01-27 19:07:52 +01:00
Aleksander Machniak
a73a53c8ef Replace deprecated methods use 2024-01-27 09:58:01 +01:00
Michael Voříšek
ff2d721680 Fix more CS whitespace (#9318)
* fix "no_useless_else" manually

* fix some "blank_line_before_statement"

* two manual changes

* Revert "fix some "blank_line_before_statement""

This reverts commit 2cc857c00e.

* fix some "blank_line_before_statement" using patched fixer (after "}" only)

* fix continue/break too
2024-01-25 19:17:29 +01:00