Fixed tests

This commit is contained in:
Jan Böhmer
2026-02-22 23:50:32 +01:00
parent 430a564592
commit a67f106bc6
2 changed files with 5 additions and 7 deletions

View File

@@ -87,7 +87,7 @@ class CanopySettings
*/
public function getRealDomain(): string
{
$domain = array_search($this->domain, self::ALLOWED_DOMAINS);
$domain = array_search($this->domain, self::ALLOWED_DOMAINS, true);
if ($domain === false) {
throw new \InvalidArgumentException("Invalid domain selected");
}

View File

@@ -92,7 +92,7 @@ final class BarcodeScanResultHandlerTest extends KernelTestCase
$this->assertNull($url);
}
public function testGetRedirectURLThrowsOnUnknownScanType(): void
public function testGetRedirectURLReturnsNullOnUnknownScanType(): void
{
$unknown = new class implements BarcodeScanResultInterface {
public function getDecodedForInfoMode(): array
@@ -101,8 +101,7 @@ final class BarcodeScanResultHandlerTest extends KernelTestCase
}
};
$this->expectException(InvalidArgumentException::class);
$this->service->getInfoURL($unknown);
$this->assertNull($this->service->getInfoURL($unknown));
}
public function testEIGPBarcodeResolvePartOrNullReturnsNullWhenNotFound(): void
@@ -124,7 +123,7 @@ final class BarcodeScanResultHandlerTest extends KernelTestCase
$this->assertNull($this->service->getInfoURL($scan));
}
public function testResolveEntityThrowsOnUnknownScanType(): void
public function testResolveEntityReturnNullOnUnknownScanType(): void
{
$unknown = new class implements BarcodeScanResultInterface {
public function getDecodedForInfoMode(): array
@@ -133,8 +132,7 @@ final class BarcodeScanResultHandlerTest extends KernelTestCase
}
};
$this->expectException(InvalidArgumentException::class);
$this->service->resolvePart($unknown);
$this->assertNull($this->service->resolvePart($unknown));
}
public function testResolveEntity(): void