Mirrors/ICEcoder
2
0
Fork 0
mirror of https://github.com/icecoder/ICEcoder.git synced 2026-03-06 08:44:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

array_splice, numPlugins to avoid extending loop cond, use i in array, exit dont die with msg

Browse Source
This commit is contained in:
mattpass
2020-07-21 09:23:05 +01:00
parent f54460319f
commit 39388dd077
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/plugins-manager.php
View File

@@ -74,12 +74,11 @@ if (false === $demoMode && isset($_SESSION['loggedIn']) && $_SESSION['loggedIn']
// ============
// UNINSTALLING
// ============
if ("uninstall" === $_GET['action']) {
// Remove the old plugin
for ($i = 0; $i < count($ICEcoder["plugins"]); $i++) {
if ($ICEcoder["plugins"][$i][0] === $pluginsData[$_GET['plugin']]['name']) {
unset($ICEcoder["plugins"][$i]);
array_splice($ICEcoder["plugins"], $i, 1);
}
}
@@ -95,12 +94,13 @@ if (false === $demoMode && isset($_SESSION['loggedIn']) && $_SESSION['loggedIn']
if ("update" === $_GET['action']) {
// Redo the arrays using the form data
for ($i = 0; $i < count($ICEcoder["plugins"]); $i++) {
$numPlugins = count($ICEcoder["plugins"]);
for ($i = 0; $i < $numPlugins; $i++) {
$timer = intval($_POST['timer' . $i]);
if ($timer == 0) {
if (0 === $timer) {
$timer = "";
}
$ICEcoder["plugins"][] = [
$ICEcoder["plugins"][$i] = [
$_POST['name' . $i],
$_POST['icon' . $i],
$_POST['style' . $i],
@@ -120,7 +120,8 @@ if (false === $demoMode && isset($_SESSION['loggedIn']) && $_SESSION['loggedIn']
header("Location: plugins-manager.php?updatedPlugins&csrf=" . $_SESSION["csrf"]);
echo "<script>window.location = 'plugins-manager.php?updatedPlugins&csrf=' + ICEcoder.csrf;</script>";
}
die("<span style='color: #fff'>" . $t['saving plugins'] . "</span>");
exit;
// die("<span style='color: #fff'>" . $t['saving plugins'] . "</span>");
} else {
echo "<script>parent.ICEcoder.message('" . $t['Cannot update config...'] . " data/" . $settingsFile . " " . $t['and try again'] . "');</script>";
}