Switch to eslint-plugin-es (#8075)

* Switch to eslint-plugin-es

* Restore eslint-config-chartjs

* Sort

.eslintrc.yml

@@ -1,6 +1,6 @@
 extends:
   - chartjs
-  - esnext
+  - plugin:es/no-2019
 
 env:
   es6: true
@@ -8,17 +8,24 @@ env:
   node: true
 
 parserOptions:
-  ecmaVersion: 7
+  ecmaVersion: 2018
   sourceType: module
   ecmaFeatures:
     impliedStrict: true
     modules: true
-    experimentalObjectRestSpread: true
 
-plugins: ['html']
+plugins: ['html', 'es']
 
 rules:
-  class-methods-use-this: 0
-  no-empty-function: 0
-  complexity: [1, 10]
-  max-statements: [1, 30]
+  class-methods-use-this: "off"
+  complexity: ["warn", 10]
+  max-statements: ["warn", 30]
+  no-empty-function: "off"
+  no-use-before-define: ["error", { "functions": false }]
+  # disable everything, except Rest/Spread Properties in ES2018
+  es/no-async-iteration: "error"
+  es/no-malformed-template-literals: "error"
+  es/no-regexp-lookbehind-assertions: "error"
+  es/no-regexp-named-capture-groups: "error"
+  es/no-regexp-s-flag: "error"
+  es/no-regexp-unicode-property-escapes: "error"

package.json

@@ -53,9 +53,9 @@
     "concurrently": "^5.3.0",
     "coveralls": "^3.1.0",
     "cross-env": "^7.0.2",
-    "eslint": "^7.12.1",
+    "eslint": "^7.13.0",
     "eslint-config-chartjs": "^0.2.0",
-    "eslint-config-esnext": "^4.1.0",
+    "eslint-plugin-es": "^3.0.1",
     "eslint-plugin-html": "^6.1.0",
     "glob": "^7.1.6",
     "jasmine": "^3.6.3",

src/core/core.config.js

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-namespace, import/namespace */
 import defaults from './core.defaults';
 import {mergeIf, merge, _merger} from '../helpers/helpers.core';
 

src/core/core.controller.js

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-namespace, import/namespace */
 import animator from './core.animator';
 import defaults from './core.defaults';
 import Interaction from './core.interaction';

src/helpers/index.js

@@ -1,5 +1,3 @@
-/* eslint-disable import/no-namespace */
-
 export * from './helpers.core';
 export * from './helpers.canvas';
 export * from './helpers.collection';

src/index.js

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-namespace, import/namespace */
 // @ts-nocheck
 
 /**