Mirrors/yii2
2
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2026-03-04 06:24:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #14903: Fixed route with extra dashes is executed controller while it should not

Browse Source
This commit is contained in:
Elvira Sheina
2018-01-09 19:59:07 +05:00
committed by Alexander Makarov
parent 72b69e359a
commit a559b9fa76
3 changed files with 57 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
tests/framework/base/ModuleTest.php
View File

@@ -120,6 +120,33 @@ class ModuleTest extends TestCase
$this->assertTrue($child->has('test'));
$this->assertFalse($parent->has('test'));
}
public function testCreateControllerByID()
{
$module = new TestModule('test');
$module->controllerNamespace = 'yiiunit\framework\base';
$route = 'module-test';
$this->assertInstanceOf(ModuleTestController::className(), $module->createControllerByID($route));
$route = 'module-test-';
$this->assertNotInstanceOf(ModuleTestController::className(), $module->createControllerByID($route));
$route = '-module-test';
$this->assertNotInstanceOf(ModuleTestController::className(), $module->createControllerByID($route));
$route = 'very-complex-name-test';
$this->assertInstanceOf(VeryComplexNameTestController::className(), $module->createControllerByID($route));
$route = 'very-complex-name-test--';
$this->assertNotInstanceOf(VeryComplexNameTestController::className(), $module->createControllerByID($route));
$route = '--very-complex-name-test';
$this->assertNotInstanceOf(VeryComplexNameTestController::className(), $module->createControllerByID($route));
$route = 'very---complex---name---test';
$this->assertNotInstanceOf(VeryComplexNameTestController::className(), $module->createControllerByID($route));
}
}
class TestModule extends \yii\base\Module
@@ -141,3 +168,11 @@ class ModuleTestController extends Controller
ModuleTest::$actionRuns[] = $this->action->uniqueId;
}
}
class VeryComplexNameTestController extends Controller
{
public function actionIndex()
{
ModuleTest::$actionRuns[] = $this->action->uniqueId;
}
}