Mirrors/yii2
2
0
Fork 0
mirror of https://github.com/yiisoft/yii2.git synced 2026-03-24 16:07:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #13467: yii\data\ActiveDataProvider no longer queries models if models count is zero

Browse Source
This commit is contained in:
Nikolay Oleynikov
2017-02-20 12:00:00 +03:00
committed by Alexander Makarov
parent ecd2dc0d1b
commit 7d82bbcd37
4 changed files with 50 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/framework/data/ActiveDataProviderTest.php
View File

@@ -7,12 +7,14 @@
namespace yiiunit\framework\data;
use yii\base\InvalidCallException;
use yii\data\ActiveDataProvider;
use yii\db\Query;
use yiiunit\data\ar\ActiveRecord;
use yiiunit\data\ar\Customer;
use yiiunit\data\ar\Item;
use yiiunit\framework\db\DatabaseTestCase;
use yiiunit\framework\db\UnqueryableQueryMock;
use yiiunit\data\ar\Order;
/**
@@ -177,4 +179,23 @@ abstract class ActiveDataProviderTest extends DatabaseTestCase
$provider->refresh();
$this->assertEquals(2, count($provider->getModels()));
}
public function testDoesNotPerformQueryWhenHasNoModels()
{
$query = new UnqueryableQueryMock;
$provider = new ActiveDataProvider([
'db' => $this->getConnection(),
'query' => $query->from('order')->where('0=1'),
]);
$pagination = $provider->getPagination();
$this->assertEquals(0, $pagination->getPageCount());
try {
$this->assertCount(0, $provider->getModels());
} catch (InvalidCallException $exception) {
$this->fail('An excessive models query was executed.');
}
$this->assertEquals(0, $pagination->getPageCount());
}
}