From 9122cb80e8f476100a7a7af4b04736641ffdfcf4 Mon Sep 17 00:00:00 2001
From: resurtm <resurtm@gmail.com>
Date: Sun, 23 Sep 2012 17:29:00 +0600
Subject: [PATCH] Better unit tests for CFileHelper.

---
 tests/framework/utils/CFileHelperTest.php | 21 +++++++++++++--------
 tests/framework/utils/data/mimeTypes1.php |  6 ------
 tests/framework/utils/data/mimeTypes2.php |  6 ------
 3 files changed, 13 insertions(+), 20 deletions(-)
 delete mode 100644 tests/framework/utils/data/mimeTypes1.php
 delete mode 100644 tests/framework/utils/data/mimeTypes2.php

diff --git a/tests/framework/utils/CFileHelperTest.php b/tests/framework/utils/CFileHelperTest.php
index e67dc904c..00801387b 100644
--- a/tests/framework/utils/CFileHelperTest.php
+++ b/tests/framework/utils/CFileHelperTest.php
@@ -4,6 +4,13 @@ class CFileHelperTest extends CTestCase
 {
 	public function testGetMimeTypeByExtension()
 	{
+		// create temporary testing data files
+		$runtimePath=dirname(__FILE__).DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'runtime'.DIRECTORY_SEPARATOR;
+		if(!(@file_put_contents($runtimePath.'mimeTypes1.php',"<?php return array('txa'=>'application/json','txb'=>'another/mime');")))
+			$this->markTestIncomplete('Unit tests runtime directory should have writable permissions!');
+		if(!(@file_put_contents($runtimePath.'mimeTypes2.php',"<?php return array('txt'=>'text/plain','txb'=>'another/mime2');")))
+			$this->markTestIncomplete('Unit tests runtime directory should have writable permissions!');
+
 		// run everything ten times in one test action to be sure that caching inside
 		// CFileHelper::getMimeTypeByExtension() is working the right way
 		for($i=0; $i<10; $i++)
@@ -12,15 +19,13 @@ class CFileHelperTest extends CTestCase
 			$this->assertNull(CFileHelper::getMimeTypeByExtension('test.txb'));
 			$this->assertEquals('text/plain',CFileHelper::getMimeTypeByExtension('test.txt'));
 
-			$path=dirname(__FILE__).DIRECTORY_SEPARATOR.'data'.DIRECTORY_SEPARATOR.'mimeTypes1.php';
-			$this->assertEquals('application/json',CFileHelper::getMimeTypeByExtension('test.txa',$path));
-			$this->assertEquals('another/mime',CFileHelper::getMimeTypeByExtension('test.txb',$path));
-			$this->assertNull(CFileHelper::getMimeTypeByExtension('test.txt',$path));
+			$this->assertEquals('application/json',CFileHelper::getMimeTypeByExtension('test.txa',$runtimePath.'mimeTypes1.php'));
+			$this->assertEquals('another/mime',CFileHelper::getMimeTypeByExtension('test.txb',$runtimePath.'mimeTypes1.php'));
+			$this->assertNull(CFileHelper::getMimeTypeByExtension('test.txt',$runtimePath.'mimeTypes1.php'));
 
-			$path=dirname(__FILE__).DIRECTORY_SEPARATOR.'data'.DIRECTORY_SEPARATOR.'mimeTypes2.php';
-			$this->assertNull(CFileHelper::getMimeTypeByExtension('test.txa',$path));
-			$this->assertEquals('another/mime2',CFileHelper::getMimeTypeByExtension('test.txb',$path));
-			$this->assertEquals('text/plain',CFileHelper::getMimeTypeByExtension('test.txt',$path));
+			$this->assertNull(CFileHelper::getMimeTypeByExtension('test.txa',$runtimePath.'mimeTypes2.php'));
+			$this->assertEquals('another/mime2',CFileHelper::getMimeTypeByExtension('test.txb',$runtimePath.'mimeTypes2.php'));
+			$this->assertEquals('text/plain',CFileHelper::getMimeTypeByExtension('test.txt',$runtimePath.'mimeTypes2.php'));
 		}
 	}
 }
diff --git a/tests/framework/utils/data/mimeTypes1.php b/tests/framework/utils/data/mimeTypes1.php
deleted file mode 100644
index f6752d17a..000000000
--- a/tests/framework/utils/data/mimeTypes1.php
+++ /dev/null
@@ -1,6 +0,0 @@
-<?php
-
-return array(
-	'txa'=>'application/json',
-	'txb'=>'another/mime',
-);
diff --git a/tests/framework/utils/data/mimeTypes2.php b/tests/framework/utils/data/mimeTypes2.php
deleted file mode 100644
index 2fc0de0ed..000000000
--- a/tests/framework/utils/data/mimeTypes2.php
+++ /dev/null
@@ -1,6 +0,0 @@
-<?php
-
-return array(
-	'txt'=>'text/plain',
-	'txb'=>'another/mime2',
-);