Mirrors/yii
2
0
Fork 0
mirror of https://github.com/yiisoft/yii.git synced 2026-03-03 06:44:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #4043: Fixed CJavaScript::quote() to properly escape Unicode characters

Browse Source
This commit is contained in:
Alexander Makarov
2017-04-18 15:45:27 +03:00
committed by GitHub
parent 7e45fa1a08
commit 1e1c5b7b05
7 changed files with 453 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
tests/framework/web/helpers/CJavaScriptTest.php
View File

@@ -13,12 +13,33 @@ class CJavaScriptTest extends CTestCase
public function testLegacyEncodeSafe()
{
$expression=CJavaScript::encode("js:function() { /* callback */ }",true);
$this->assertEquals("'js:function() { /* callback */ }'",$expression);
$this->assertEquals("'js\\x3Afunction\\x28\\x29\\x20\\x7B\\x20\\x2F\\x2A\\x20callback\\x20\\x2A\\x2F\\x20\\x7D'",$expression);
}
public function testEncode()
{
$expression=CJavaScript::encode(new CJavaScriptExpression("function() { /* callback */ }"));
$this->assertEquals("function() { /* callback */ }",$expression);
}
public function testEncode()
{
$expression=CJavaScript::encode(new CJavaScriptExpression("function() { /* callback */ }"));
$this->assertEquals("function() { /* callback */ }",$expression);
}
private function getUnicodeTestString()
{
$unicodeChar1 = json_decode('"'.'\u2028'.'"');
$unicodeChar2 = json_decode('"'.'\u2029'.'"');
return "test {$unicodeChar1}\ntest $unicodeChar2";
}
public function testQuote()
{
$input=$this->getUnicodeTestString();
$output=CJavaScript::quote($input);
$this->assertEquals('test\x20\u2028\x0Atest\x20\u2029',$output);
}
public function testQuoteForUrl()
{
$input=$this->getUnicodeTestString();
$output=CJavaScript::quote($input,true);
$this->assertEquals('test%20%E2%80%A8%0Atest%20%E2%80%A9',$output);
}
}