From 32ce58eba74e33d91fad71a768bc0ccb925a090c Mon Sep 17 00:00:00 2001 From: Evgeny Kochetkov Date: Wed, 17 May 2017 20:20:06 +0300 Subject: [PATCH] refactor(xod-project): remove isPinCurried function --- packages/xod-project/README.md | 2 +- packages/xod-project/src/node.js | 17 ----------------- packages/xod-project/test/node.spec.js | 17 ----------------- 3 files changed, 1 insertion(+), 35 deletions(-) diff --git a/packages/xod-project/README.md b/packages/xod-project/README.md index bed0a359..38a363b4 100644 --- a/packages/xod-project/README.md +++ b/packages/xod-project/README.md @@ -70,7 +70,7 @@ Manipulate with entities only using API functions or you can get unhandled excep * **Check functions** If function checks something and returns boolean, it looks like a question. - For example, `isPinCurried`, `hasPins`. + For example, `isValidIdentifier`, `hasPins`. ### Getters, setters and their return values diff --git a/packages/xod-project/src/node.js b/packages/xod-project/src/node.js index 1555deae..1e76f7fe 100644 --- a/packages/xod-project/src/node.js +++ b/packages/xod-project/src/node.js @@ -303,23 +303,6 @@ export const curryPin = def( // TODO: deprecated ) ); -/** - * @function isPinCurried - * @param {string} key - * @param {Node} node - * @returns {boolean} - */ -export const isPinCurried = def( // TODO: deprecated - 'isPinCurried :: PinKey -> Node -> Boolean', - R.useWith( - R.pathSatisfies(R.equals(true)), - [ - getPathToPinProperty('curried'), - R.identity, - ] - ) -); - /** * Returns data type extracted from pinNode type * @function getPinNodeDataType diff --git a/packages/xod-project/test/node.spec.js b/packages/xod-project/test/node.spec.js index 400f1bdf..0c78fa9e 100644 --- a/packages/xod-project/test/node.spec.js +++ b/packages/xod-project/test/node.spec.js @@ -288,23 +288,6 @@ describe('Node', () => { expect(Node.isPinNode(nodeOfType('xod/patch-nodes/output-number'))).to.be.true(); }); }); - describe('isPinCurried', () => { - it('should return false for non-existent pin', () => { - expect(Node.isPinCurried('test', emptyNode)).to.be.false(); - }); - it('should return false for pin without `curried` property equal to true', () => { - const node = Helper.defaultizeNode({ boundValues: { test: {} } }); - expect(Node.isPinCurried('test', node)).to.be.false(); - }); - it('should return true for pin that curried', () => { - const node = Helper.defaultizeNode({ boundValues: { test: { value: 1, curried: true } } }); - expect(Node.isPinCurried('test', node)).to.be.true(); - }); - it('should return true for pin that curried, even it haven\'t a value', () => { - const node = Helper.defaultizeNode({ boundValues: { test: { curried: true } } }); - expect(Node.isPinCurried('test', node)).to.be.true(); - }); - }); // etc describe('getPinNodeDataType', () => { it('should throw error for non-existent data-type', () => {