From a91f306c9492b3b90a61dac5d4192e1e4c6438da Mon Sep 17 00:00:00 2001 From: Evgeny Kochetkov Date: Mon, 11 Dec 2017 16:19:42 +0300 Subject: [PATCH 1/2] =?UTF-8?q?fix(xod-client):=20make=20Node=20component?= =?UTF-8?q?=E2=80=99s=20SCU=20less=20strict?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../src/project/components/Node.jsx | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/packages/xod-client/src/project/components/Node.jsx b/packages/xod-client/src/project/components/Node.jsx index 561f4357..0276e35e 100644 --- a/packages/xod-client/src/project/components/Node.jsx +++ b/packages/xod-client/src/project/components/Node.jsx @@ -23,21 +23,10 @@ class Node extends React.Component { shouldComponentUpdate(newProps) { return !R.eqBy( - R.pick([ - 'id', - 'label', - 'type', - 'pins', - 'size', - 'position', - 'dead', - 'isSelected', - 'isGhost', - 'isDragged', - 'hidden', - 'noEvents', - 'linkingPin', - 'pinLinkabilityValidator', + R.omit([ + 'onMouseDown', + 'onMouseUp', + 'onDoubleClick', ]), newProps, this.props From 313c6ed1455910d7cd3399342381b8e923fb5818 Mon Sep 17 00:00:00 2001 From: Evgeny Kochetkov Date: Mon, 11 Dec 2017 18:15:20 +0300 Subject: [PATCH 2/2] test(xod-client-electron): remove unneeded assertion --- packages/xod-client-electron/test-func/1-blink.spec.js | 1 - packages/xod-client-electron/test-func/pageObject.js | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/xod-client-electron/test-func/1-blink.spec.js b/packages/xod-client-electron/test-func/1-blink.spec.js index fcf1bcd6..97cdf95d 100644 --- a/packages/xod-client-electron/test-func/1-blink.spec.js +++ b/packages/xod-client-electron/test-func/1-blink.spec.js @@ -38,7 +38,6 @@ describe('IDE: Blink project', () => { .then(() => ide.page.assertNoPatchesAreOpen()) // close patch group to restore initial state .then(() => ide.page.findPatchGroup(patchGroup).click()) - .then(() => ide.page.assertPatchGroupCollapsed(patchGroup)) ); }); diff --git a/packages/xod-client-electron/test-func/pageObject.js b/packages/xod-client-electron/test-func/pageObject.js index cf917063..20cd6c33 100644 --- a/packages/xod-client-electron/test-func/pageObject.js +++ b/packages/xod-client-electron/test-func/pageObject.js @@ -4,7 +4,7 @@ const chai = require('chai'); const chaiAsPromised = require('chai-as-promised'); chai.use(chaiAsPromised); -const assert = chai.assert; +const { assert } = chai; //----------------------------------------------------------------------------- // Func utils