From 2124cb3cab240d6dbf871a102fc5abcdc22ced14 Mon Sep 17 00:00:00 2001
From: Kirill Shumilov <brusher.designer@gmail.com>
Date: Fri, 30 Dec 2016 18:15:08 +0300
Subject: [PATCH] fix(xod-client, xod-core): fix errors caused by pulse type

---
 .../src/editor/components/inspectorWidgets/BoolWidget.jsx  | 5 +----
 .../src/editor/components/inspectorWidgets/Widget.jsx      | 7 +++++--
 .../src/editor/components/inspectorWidgets/index.js        | 6 +++---
 packages/xod-core/src/project/constants.js                 | 4 ++--
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/packages/xod-client/src/editor/components/inspectorWidgets/BoolWidget.jsx b/packages/xod-client/src/editor/components/inspectorWidgets/BoolWidget.jsx
index 018428f2..82580863 100644
--- a/packages/xod-client/src/editor/components/inspectorWidgets/BoolWidget.jsx
+++ b/packages/xod-client/src/editor/components/inspectorWidgets/BoolWidget.jsx
@@ -7,7 +7,7 @@ function BoolWidget(props) {
     'is-disabled': props.disabled,
   });
   const onChange = (event) => {
-    props.onChange(event.target.value);
+    props.onChange(event.target.checked);
   };
   return (
     <div className={cls}>
@@ -16,10 +16,7 @@ function BoolWidget(props) {
         type="checkbox"
         value="1"
         checked={props.value}
-        autoFocus={props.focused}
         disabled={props.disabled}
-        onFocus={props.onFocus}
-        onBlur={props.onBlur}
         onChange={onChange}
       />
       <label
diff --git a/packages/xod-client/src/editor/components/inspectorWidgets/Widget.jsx b/packages/xod-client/src/editor/components/inspectorWidgets/Widget.jsx
index ee19c1f4..2447c26e 100644
--- a/packages/xod-client/src/editor/components/inspectorWidgets/Widget.jsx
+++ b/packages/xod-client/src/editor/components/inspectorWidgets/Widget.jsx
@@ -25,6 +25,7 @@ export default function composeWidget(Component, widgetProps) {
     constructor(props) {
       super(props);
       this.type = widgetProps.type;
+      this.commitOnChange = widgetProps.commitOnChange;
 
       const val = this.parseValue(props.value);
       this.state = {
@@ -87,13 +88,15 @@ export default function composeWidget(Component, widgetProps) {
 
     updateValue(value) {
       const newValue = this.parseValue(value);
+      const commitCallback = (this.commitOnChange) ? this.commit.bind(this) : noop;
+
       this.setState({
         value: newValue,
-      });
+      }, commitCallback);
     }
 
     commit() {
-      if (this.state.value !== this.props.value && this.props.injected) {
+      if (this.parseValue(this.state.value) !== this.parseValue(this.props.value)) {
         this.props.onPropUpdate(
           this.props.entityId,
           this.props.kind,
diff --git a/packages/xod-client/src/editor/components/inspectorWidgets/index.js b/packages/xod-client/src/editor/components/inspectorWidgets/index.js
index b93430f3..627a806f 100644
--- a/packages/xod-client/src/editor/components/inspectorWidgets/index.js
+++ b/packages/xod-client/src/editor/components/inspectorWidgets/index.js
@@ -56,10 +56,10 @@ export const WIDGET_MAPPING = {
       props: { type: 'string' },
     },
     [WIDGET_TYPE.PULSE]: {
-      component: PulseWidget,
+      component: BoolWidget,
       props: {
-        type: 'pulse',
-        keyDownHandlers: widgetNumberKeysDownHandlers,
+        type: 'bool',
+        commitOnChange: true,
       },
     },
     [WIDGET_TYPE.IO_LABEL]: {
diff --git a/packages/xod-core/src/project/constants.js b/packages/xod-core/src/project/constants.js
index cd255a5c..edd3cf2a 100644
--- a/packages/xod-core/src/project/constants.js
+++ b/packages/xod-core/src/project/constants.js
@@ -49,7 +49,7 @@ export const PROPERTY_DEFAULT_VALUE = {
   BOOL: false,
   NUMBER: 0,
   STRING: '',
-  PULSE: 'once',
+  PULSE: false,
 };
 
 export const PROPERTY_TYPE_PARSE = {
@@ -60,7 +60,7 @@ export const PROPERTY_TYPE_PARSE = {
     return isNaN(newValue) ? '' : newValue;
   },
   [PROPERTY_TYPE.STRING]: v => String(v),
-  [PROPERTY_TYPE.PULSE]: v => (v !== null ? String(v) : PROPERTY_DEFAULT_VALUE.PULSE),
+  [PROPERTY_TYPE.PULSE]: v => !!v,
 };
 
 export const SIZE = {