From b02bcf9be5c510d22aa794a637b45b4cb7edfd8d Mon Sep 17 00:00:00 2001 From: Martin Varmuza Date: Fri, 12 Jan 2024 11:50:22 +0100 Subject: [PATCH] ci: workflows cleanup and standardization --- .github/workflows/blockchain-link-test.yml | 2 +- .github/workflows/codeql_analysis.yml | 2 +- .github/workflows/connect-explorer_deploy.yml | 2 +- .../workflows/connect-pre-release-init.yml | 2 +- .github/workflows/connect-release-init.yml | 2 +- .github/workflows/connect-test-params.yml | 2 +- .github/workflows/connect-test.yml | 2 +- .github/workflows/connect-version_check.yml | 46 ------------------- .../workflows/connect-webextension.test.yml | 21 --------- .github/workflows/crowdin_sync.yml | 2 +- .github/workflows/fixup_check.yml | 2 +- .../workflows/remove_disabled_workflows.yml | 16 ------- .github/workflows/shell_validation.yml | 2 +- .github/workflows/suite-native_develop_ci.yml | 2 +- .../workflows/suite-native_production_ci.yml | 2 +- .github/workflows/suite-native_staging_ci.yml | 2 +- .github/workflows/validation.yml | 2 +- 17 files changed, 14 insertions(+), 97 deletions(-) delete mode 100644 .github/workflows/connect-version_check.yml delete mode 100644 .github/workflows/connect-webextension.test.yml delete mode 100644 .github/workflows/remove_disabled_workflows.yml diff --git a/.github/workflows/blockchain-link-test.yml b/.github/workflows/blockchain-link-test.yml index de52e8ed6b..900c77f53a 100644 --- a/.github/workflows/blockchain-link-test.yml +++ b/.github/workflows/blockchain-link-test.yml @@ -1,4 +1,4 @@ -name: "@trezor/blockchain-link" +name: "[Test] @trezor/blockchain-link" on: push: diff --git a/.github/workflows/codeql_analysis.yml b/.github/workflows/codeql_analysis.yml index 55cd2dd390..43deaa2143 100644 --- a/.github/workflows/codeql_analysis.yml +++ b/.github/workflows/codeql_analysis.yml @@ -1,4 +1,4 @@ -name: "CodeQL check" +name: "[Check] CodeQL check" on: push: diff --git a/.github/workflows/connect-explorer_deploy.yml b/.github/workflows/connect-explorer_deploy.yml index 9ca0b257e4..d201306ac9 100644 --- a/.github/workflows/connect-explorer_deploy.yml +++ b/.github/workflows/connect-explorer_deploy.yml @@ -1,4 +1,4 @@ -name: connect-explorer build and deploy +name: "[Deploy] connect-explorer" on: push: diff --git a/.github/workflows/connect-pre-release-init.yml b/.github/workflows/connect-pre-release-init.yml index ead153c39b..636ad30f47 100644 --- a/.github/workflows/connect-pre-release-init.yml +++ b/.github/workflows/connect-pre-release-init.yml @@ -1,4 +1,4 @@ -name: pre-release-npm - connect v9 - init +name: "[Release] connect npm init" on: workflow_dispatch: diff --git a/.github/workflows/connect-release-init.yml b/.github/workflows/connect-release-init.yml index a35a241aaf..96588a277d 100644 --- a/.github/workflows/connect-release-init.yml +++ b/.github/workflows/connect-release-init.yml @@ -1,4 +1,4 @@ -name: release - connect v9 - init +name: "[Release] connect init" on: workflow_dispatch: diff --git a/.github/workflows/connect-test-params.yml b/.github/workflows/connect-test-params.yml index dfaac4afd6..f87f62b2ea 100644 --- a/.github/workflows/connect-test-params.yml +++ b/.github/workflows/connect-test-params.yml @@ -1,4 +1,4 @@ -name: Test with trezor-user-env +name: "[Test] connect" on: workflow_call: inputs: diff --git a/.github/workflows/connect-test.yml b/.github/workflows/connect-test.yml index a0f51783e2..522bb7a499 100644 --- a/.github/workflows/connect-test.yml +++ b/.github/workflows/connect-test.yml @@ -1,4 +1,4 @@ -name: "@trezor/connect" +name: "[Test] connect" # run only if there are changes in connect or related libs paths on: diff --git a/.github/workflows/connect-version_check.yml b/.github/workflows/connect-version_check.yml deleted file mode 100644 index 484f924443..0000000000 --- a/.github/workflows/connect-version_check.yml +++ /dev/null @@ -1,46 +0,0 @@ -name: "Connect version check" - -on: - pull_request: - branches: - - release/connect-v9 - -jobs: - version_beta_check: - name: Check if connect version is beta - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - run: | - bash ./ci/scripts/check-beta-version.sh - continue-on-error: true - - version_bump_check: - name: Check connect version bump - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - name: Setup node - uses: actions/setup-node@v3 - with: - node-version-file: ".nvmrc" - - run: | - yarn install - node ci/scripts/check-version.js connect npm-release latest - continue-on-error: true - - dependencies_check: - name: Check connect dependencies - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - name: Setup node - uses: actions/setup-node@v3 - with: - node-version-file: ".nvmrc" - - name: "check npm dependencies" - continue-on-error: true - run: | - yarn install - node ci/scripts/check-npm-dependencies connect - node ci/scripts/check-npm-dependencies connect-web diff --git a/.github/workflows/connect-webextension.test.yml b/.github/workflows/connect-webextension.test.yml deleted file mode 100644 index 354fa480a9..0000000000 --- a/.github/workflows/connect-webextension.test.yml +++ /dev/null @@ -1,21 +0,0 @@ -name: "@trezor/connect-webextension" - -# TODO: until we are able to build and deploy webextension from github, this workflow can not be used -on: - workflow_dispatch: - -jobs: - connect-webextension-test: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - with: - submodules: recursive - - run: yarn install - - run: yarn build:libs - - name: Build extension - # this does not make much sense, in fact, we are testing what is already in production and we cant change that - # unless we have build and deploys in github - run: node ./packages/connect-examples/update-webextensions.js --npm-src "https://connect.trezor.io/9/trezor-connect.js" - - name: Run connect web extension test - run: "./docker/docker-connect-webextension-ci.sh" diff --git a/.github/workflows/crowdin_sync.yml b/.github/workflows/crowdin_sync.yml index 6427a20bba..43ff1f931c 100644 --- a/.github/workflows/crowdin_sync.yml +++ b/.github/workflows/crowdin_sync.yml @@ -1,4 +1,4 @@ -name: Crowdin translations update +name: "[Bot] Crowdin translations update" on: [workflow_dispatch] diff --git a/.github/workflows/fixup_check.yml b/.github/workflows/fixup_check.yml index a018b47d04..f27822d918 100644 --- a/.github/workflows/fixup_check.yml +++ b/.github/workflows/fixup_check.yml @@ -1,4 +1,4 @@ -name: Fixup commit check +name: "[Check] Fixup commit" on: [pull_request] diff --git a/.github/workflows/remove_disabled_workflows.yml b/.github/workflows/remove_disabled_workflows.yml deleted file mode 100644 index 975d651379..0000000000 --- a/.github/workflows/remove_disabled_workflows.yml +++ /dev/null @@ -1,16 +0,0 @@ -name: "[Bot] Remove disabled workflows" - -on: [workflow_dispatch] - -jobs: - crowdin-sync: - runs-on: ubuntu-latest - steps: - - name: Remove disabled workflows - run: | - git config --global user.name "trezor-ci" - git config --global user.email "${{ secrets.TREZOR_BOT_EMAIL }}" - ./ci/scripts/remove_disabled_workflows.sh - env: - GITHUB_TOKEN: ${{ secrets.TREZOR_BOT_TOKEN }} - BRANCH_NAME: trezor-ci/crowdin-sync-${{ env.NOW }} diff --git a/.github/workflows/shell_validation.yml b/.github/workflows/shell_validation.yml index 561e4abb90..182407db67 100644 --- a/.github/workflows/shell_validation.yml +++ b/.github/workflows/shell_validation.yml @@ -1,4 +1,4 @@ -name: Shell validation check +name: "[Check]: Shell validation" on: pull_request: diff --git a/.github/workflows/suite-native_develop_ci.yml b/.github/workflows/suite-native_develop_ci.yml index d3a4ed8b21..3f4ab68051 100644 --- a/.github/workflows/suite-native_develop_ci.yml +++ b/.github/workflows/suite-native_develop_ci.yml @@ -1,4 +1,4 @@ -name: suite-native develop ci +name: "[Release] suite-native develop" on: push: diff --git a/.github/workflows/suite-native_production_ci.yml b/.github/workflows/suite-native_production_ci.yml index 55787e8e75..aa167e032b 100644 --- a/.github/workflows/suite-native_production_ci.yml +++ b/.github/workflows/suite-native_production_ci.yml @@ -1,4 +1,4 @@ -name: suite-native production release +name: "[Release] suite-native production" on: workflow_dispatch: diff --git a/.github/workflows/suite-native_staging_ci.yml b/.github/workflows/suite-native_staging_ci.yml index 49fbe0c0c8..025d2a3ded 100644 --- a/.github/workflows/suite-native_staging_ci.yml +++ b/.github/workflows/suite-native_staging_ci.yml @@ -1,4 +1,4 @@ -name: suite-native staging release +name: "[Release]: suite-native staging" on: workflow_dispatch: diff --git a/.github/workflows/validation.yml b/.github/workflows/validation.yml index c5e43a9a79..49e862ec7c 100644 --- a/.github/workflows/validation.yml +++ b/.github/workflows/validation.yml @@ -1,4 +1,4 @@ -name: Validation check +name: "[Check] Validation" on: [pull_request]