diff --git a/inc/SP/Auth/Ldap/LdapMsAds.class.php b/inc/SP/Auth/Ldap/LdapMsAds.class.php index a31b1536..ee999067 100644 --- a/inc/SP/Auth/Ldap/LdapMsAds.class.php +++ b/inc/SP/Auth/Ldap/LdapMsAds.class.php @@ -43,9 +43,13 @@ class LdapMsAds extends LdapBase */ protected function getGroupDnFilter() { - $groupDN = (!empty($this->group)) ? $this->searchGroupDN() : '*'; + if (empty($this->group)) { + return '(|(objectClass=inetOrgPerson)(objectClass=person)(objectClass=simpleSecurityObject))'; + } else { + $groupDN = $this->searchGroupDN(); - return '(&(|(memberOf=' . $groupDN . ')(groupMembership=' . $groupDN . ')(memberof:1.2.840.113556.1.4.1941:=' . $groupDN . '))(|(objectClass=inetOrgPerson)(objectClass=person)(objectClass=simpleSecurityObject)))'; + return '(&(|(memberOf=' . $groupDN . ')(groupMembership=' . $groupDN . ')(memberof:1.2.840.113556.1.4.1941:=' . $groupDN . '))(|(objectClass=inetOrgPerson)(objectClass=person)(objectClass=simpleSecurityObject)))'; + } } /** diff --git a/inc/SP/Auth/Ldap/LdapStd.class.php b/inc/SP/Auth/Ldap/LdapStd.class.php index b6db04f5..634cfeb3 100644 --- a/inc/SP/Auth/Ldap/LdapStd.class.php +++ b/inc/SP/Auth/Ldap/LdapStd.class.php @@ -42,9 +42,13 @@ class LdapStd extends LdapBase */ protected function getGroupDnFilter() { - $groupDN = (!empty($this->group)) ? $this->searchGroupDN() : '*'; + if (empty($this->group)){ + return '(|(objectClass=inetOrgPerson)(objectClass=person)(objectClass=simpleSecurityObject))'; + } else { + $groupDN = $this->searchGroupDN(); - return '(&(|(memberOf=' . $groupDN . ')(groupMembership=' . $groupDN . '))(|(objectClass=inetOrgPerson)(objectClass=person)(objectClass=simpleSecurityObject)))'; + return '(&(|(memberOf=' . $groupDN . ')(groupMembership=' . $groupDN . '))(|(objectClass=inetOrgPerson)(objectClass=person)(objectClass=simpleSecurityObject)))'; + } } /**