test(IT): Test Config Backup use cases (WIP)

Signed-off-by: Rubén D <nuxsmin@syspass.org>

app/modules/web/Controllers/ConfigBackup/DownloadBackupAppController.php

@@ -24,16 +24,18 @@
 
 namespace SP\Modules\Web\Controllers\ConfigBackup;
 
-
-use Exception;
+use Klein\Response;
 use SP\Core\Application;
 use SP\Core\Bootstrap\Path;
 use SP\Core\Bootstrap\PathsContext;
 use SP\Core\Context\Session;
 use SP\Core\Events\Event;
 use SP\Core\Events\EventMessage;
+use SP\Domain\Common\Attributes\Action;
+use SP\Domain\Common\Dtos\ActionResponse;
+use SP\Domain\Common\Enums\ResponseStatus;
+use SP\Domain\Common\Enums\ResponseType;
 use SP\Domain\Core\Acl\AclActionsInterface;
-use SP\Domain\Core\Acl\UnauthorizedPageException;
 use SP\Domain\Core\Exceptions\SessionTimeout;
 use SP\Domain\Core\Exceptions\SPException;
 use SP\Domain\Export\Dtos\BackupFile;
@@ -43,8 +45,8 @@ use SP\Modules\Web\Controllers\SimpleControllerBase;
 use SP\Modules\Web\Controllers\Traits\JsonTrait;
 use SP\Mvc\Controller\SimpleControllerHelper;
 
+use function SP\__;
 use function SP\__u;
-use function SP\processException;
 
 /**
  * Class DownloadBackupController
@@ -63,56 +65,51 @@ final class DownloadBackupAppController extends SimpleControllerBase
 
 
     /**
-     * @return string
+     * @return ActionResponse
      */
-    public function downloadBackupAppAction(): string
+    #[Action(ResponseType::CALLBACK)]
+    public function downloadBackupAppAction(): ActionResponse
     {
         if ($this->configData->isDemoEnabled()) {
-            return __('Ey, this is a DEMO!!');
+            return ActionResponse::warning(__('Ey, this is a DEMO!!'));
         }
 
-        try {
-            Session::close();
+        Session::close();
 
-            $filePath = new BackupFile(
-                BackupType::app,
-                $this->configData->getBackupHash(),
-                $this->pathsContext[Path::BACKUP],
-                'gz'
-            );
+        $filePath = new BackupFile(
+            BackupType::app,
+            $this->configData->getBackupHash(),
+            $this->pathsContext[Path::BACKUP],
+            'gz'
+        );
 
-            $file = new FileHandler((string)$filePath);
-            $file->checkFileExists();
+        $file = new FileHandler((string)$filePath);
 
-            $this->eventDispatcher->notify(
-                'download.backupAppFile',
-                new Event(
-                    $this,
-                    EventMessage::build()
-                        ->addDescription(__u('File downloaded'))
-                        ->addDetail(__u('File'), str_replace(APP_ROOT, '', $file->getFile()))
-                )
-            );
+        $this->eventDispatcher->notify(
+            'download.backupAppFile',
+            new Event(
+                $this,
+                EventMessage::build(__u('File downloaded'))
+                            ->addDetail(__u('File'), str_replace(APP_ROOT, '', $file->getFile()))
+            )
+        );
 
-            $this->router
-                ->response()
-                ->header('Cache-Control', 'max-age=60, must-revalidate')
-                ->header('Content-length', $file->getFileSize())
-                ->header('Content-type', $file->getFileType())
-                ->header('Content-Description', ' sysPass file')
-                ->header('Content-transfer-encoding', 'chunked')
-                ->header('Content-Disposition', 'attachment; filename="' . basename($file->getFile()) . '"')
-                ->header('Set-Cookie', 'fileDownload=true; path=/')
-                ->send();
+        return new ActionResponse(
+            ResponseStatus::OK,
+            function (Response $response) use ($file) {
+                $response
+                    ->header('Cache-Control', 'max-age=60, must-revalidate')
+                    ->header('Content-length', $file->getFileSize())
+                    ->header('Content-type', $file->getFileType())
+                    ->header('Content-Description', ' sysPass file')
+                    ->header('Content-transfer-encoding', 'chunked')
+                    ->header('Content-Disposition', 'attachment; filename="' . basename($file->getFile()) . '"')
+                    ->header('Set-Cookie', 'fileDownload=true; path=/')
+                    ->send();
 
-            $file->readChunked();
-        } catch (Exception $e) {
-            processException($e);
-
-            $this->eventDispatcher->notify('exception', new Event($e));
-        }
-
-        return '';
+                $file->readChunked();
+            }
+        );
     }
 
     /**
@@ -123,13 +120,7 @@ final class DownloadBackupAppController extends SimpleControllerBase
      */
     protected function initialize(): void
     {
-        try {
-            $this->checks();
-            $this->checkAccess(AclActionsInterface::CONFIG_BACKUP);
-        } catch (UnauthorizedPageException $e) {
-            $this->eventDispatcher->notify('exception', new Event($e));
-
-            $this->returnJsonResponseException($e);
-        }
+        $this->checks();
+        $this->checkAccess(AclActionsInterface::CONFIG_BACKUP);
     }
 }