Commit Graph

7719 Commits

Author SHA1 Message Date
Aleksander Machniak
ee2a541b99 Contact form mode: private/business (#7630) 2020-09-27 11:32:06 +02:00
Michael Stilkerich
67825e6320 MySQL: Don't reissue query after deadlock error (#7529)
When a deadlock error occurs, MySQL rolls back the _entire_ ongoing
transaction. The application would have to restart the transaction from
the beginning to retry if wanted.

Now roundcube in that case simply retries the statement that raised the
deadlock error, even though everything else in the transaction was
rolled back. This breaks transaction isolation, leaves the database in a
potentially inconsistent state (from the application's data consistency
model point of view), and does not indicate to the application there was
a problem at all to it may even continue executing other potentially
remaining statements of a transaction that has already been rolled back.

-> Remove the retries from roundcube. Retries have to be initiated by
the application if desired, not only retrying the last statement but the
entire transaction from the beginning.
2020-09-25 12:32:25 +02:00
Aleksander Machniak
0213c2daa7 Fix so autocompletion list does not hide on scroll inside it (#7592) 2020-09-25 09:35:19 +02:00
johndoh
6a25f2611d Make auto generated button ids unique between main screen and iframe (#7619) 2020-09-24 18:36:12 +02:00
Aleksander Machniak
8c4c211cb0 Fix scroll jump on key press in plain text mode of the HTML editor (#7622) 2020-09-24 17:20:23 +02:00
Aleksander Machniak
d81b8447fb Fix empty output from HTML5 parser when content contains XML tag (#7624) 2020-09-23 15:15:02 +02:00
Aleksander Machniak
1cc9d4f566 Bump minimum PHP version to 5.5, bump guzzle version (#7616) 2020-09-23 11:00:57 +02:00
Aleksander Machniak
f0084b6f54 Fix empty space on mail printouts in Chrome (#7604) 2020-09-23 10:49:16 +02:00
Aleksander Machniak
e7597d920c $rcmail -> $RCMAIL 2020-09-22 07:32:24 +02:00
Aleksander Machniak
4c8f8f247a Capitalize "Collected Recipients" and "Trusted Senders"
.. as we already have "Personal Addresses" (shouldn't that be Personal Contacts?).
2020-09-20 15:08:18 +02:00
Aleksander Machniak
d30f039e5a Use PDO::ATTR_CLIENT_VERSION when PDO::ATTR_DRIVER_VERSION does not exist (#7564) 2020-09-20 14:45:43 +02:00
Michael Steininger
6345982655 Add $lang argument to read_localization (#7599) 2020-09-20 11:13:15 +02:00
Aleksander Machniak
9713ce364c Automatically collected recipients and trusted senders (#6904)
Added configurable Collected Recipients addressbook source (#4971)
Added configurable Trusted Senders addressbook source (#5046)
Added 'contact_exists' hook
2020-09-20 10:00:08 +02:00
Aleksander Machniak
7d3d806411 Fix PHP Fatal error: Cannot access protected property rcube_message::$body (#7588) 2020-09-05 08:46:01 +02:00
Aleksander Machniak
5264534c46 Fix bug where some parts of a message could have been missing in a reply/forward body (#7568) 2020-08-30 10:56:13 +02:00
Aleksander Machniak
77bc3f2427 Fix incorrect PDO::lastInsertId() use in sqlsrv driver (#7564) 2020-08-28 09:41:19 +02:00
Aleksander Machniak
d40681237a Replace Import/Cancel buttons with Close button after successful contacts import 2020-08-23 12:05:22 +02:00
Aleksander Machniak
e476211230 Fix error when dealing with message/rfc822 attachments using Gmail IMAP (#6854) 2020-08-23 10:18:10 +02:00
Aleksander Machniak
535816db22 Describe all() method on more detail (#6219) 2020-08-23 09:39:55 +02:00
Aleksander Machniak
e4832118a4 Plugin API: Added 'message' argument to 'message_compose_body' hook 2020-08-21 09:57:57 +02:00
Aleksander Machniak
d6ce6170f6 Fix restoring Cc/Bcc fields from local storage (#7554) 2020-08-21 09:05:30 +02:00
Aleksander Machniak
b7d4596aa9 Fix regression (#7557) 2020-08-16 16:32:18 +02:00
Aleksander Machniak
bf15b5ed92 Fix regression 2020-08-16 12:28:04 +02:00
Aleksander Machniak
a5c2b4360c Fixes in context of undefined variables, and code style 2020-08-15 12:13:31 +02:00
atomindtechnology
d9afc5376c Add variable in app.js to setup the ajax timeout for file uploads (#7551)
* Add variable in app.js to setup the ajax timeout upload file
In this way, we can control the ajax timeout on client side when we upload attachments
2020-08-14 09:20:52 +02:00
Aleksander Machniak
d445f8ad12 Fix importing birthday dates from Gmail vCards (BDAY:YYYYMMDD) 2020-08-12 11:25:44 +02:00
Thomas B
9020797d0d Merge pull request #7425 from thomascube/pr-xoauth2
Add OAuth/XOauth support
2020-08-10 21:40:01 +02:00
Ratting Gergely
f0b5f5d413 Fix unclosed a tag (#7539)
Put a closing a tag after the word vCard in the hungarian localisation.
2020-08-10 10:40:07 +02:00
Aleksander Machniak
ec4cc29c88 Fix cross-site scripting (XSS) via HTML messages with malicious svg or math content 2020-08-09 18:02:16 +02:00
Achim Leitner
8e0ee8b1c4 Fix: Keep children of object tag (#6453)
The HTML tag <object> optionally has embedded (child) tags that serve as an
alternative (fallback) HTML representation for the object. Of course, the
object and its parameters are considered harmful in HTML mail, but the
alternative representation is meant for exactly this kind of situation. They
should display the object contents without loading possibly insecure code.

- By ignoring <object> tags, roundcube also removes all their child nodes
- As <object> is not in the list of allowed $html_elements and <param> gets
  cleaned through $void_elements, they get ignored anyway, without removing the
  valuable child nodes.

Co-authored-by: root <root@coreboso-kolab.coreboso.de>
2020-08-07 11:06:14 +02:00
johndoh
4c8ea71e3a Fix so setting 'login' in config['skin_logo'] does not change the favicon (#7456, #7470)
* Fix skin_logo config, again
* Elastic: add support for dark mode logos
* Add new additional_logo_types config for skins
2020-08-07 10:34:40 +02:00
Aleksander Machniak
3e2f076628 Fix bug in conversion of email addresses to mailto links in plain text messages (#7526) 2020-08-07 10:03:56 +02:00
Aleksander Machniak
60ccb25bd5 Fix detecting special folders on servers with both SPECIAL-USE and LIST-STATUS (#7525) 2020-07-31 14:36:57 +02:00
Aleksander Machniak
90280ed690 Cleanup 2020-07-31 11:11:20 +02:00
Aleksander Machniak
18f2693364 Merge branch 'mailvelope-fixes' of https://github.com/gurnec/roundcubemail into gurnec-mailvelope-fixes 2020-07-31 10:12:29 +02:00
Aleksander Machniak
ef9b375ef6 Fix paging of search results on IMAP servers with no SORT capability (#7462)
And simplify some code around.
2020-07-30 13:23:37 +02:00
Aleksander Machniak
17deadfe56 Fix handling links without defined protocol (#7454) 2020-07-29 15:17:48 +02:00
Aleksander Machniak
0d9bffa878 Fix incorrect rewriting of internal links in HTML content (#7512) 2020-07-29 14:19:02 +02:00
johndoh
dc342ffc5e Fix regression in message list col type detection (#7496) 2020-07-26 08:10:37 +02:00
Michael Stilkerich
25e42439d2 Fix inconsistencies in phpdoc type annotations (#7474) 2020-07-25 09:59:01 +02:00
Aleksander Machniak
58978b721d Fix format=flowed formatting on plain text part derived from the HTML content (#7504) 2020-07-25 09:20:02 +02:00
Aleksander Machniak
0ccb351380 Fix regression in DB cache (#7499) 2020-07-21 20:15:05 +02:00
Aleksander Machniak
d7d7ca046f Cache refactoring (#6312) (#6781) 2020-07-18 13:51:47 +02:00
Aleksander Machniak
2de9d11070 Fix regression where drag-n-drop content was empty on mail messages list 2020-07-18 09:47:37 +02:00
Aleksander Machniak
e2c25a1949 Fix support for an error as a string in message_before_send hook (#7475) 2020-07-18 08:24:44 +02:00
Aleksander Machniak
cd3cad6aae TinyMCE 5 (#7403) 2020-07-11 18:46:17 +02:00
Aleksander Machniak
36bf280a97 Elastic: Minimize forms/colors blink on page load 2020-07-11 10:52:24 +02:00
Aleksander Machniak
d6aca6b6b7 Elastic: Drak mode (#6709) 2020-07-07 18:58:28 +02:00
Aleksander Machniak
1e1ea25b6c Added special value 'email' to login_username_filter, it changes also logon input type (#7179) 2020-07-03 12:56:17 +02:00
Aleksander Machniak
32a7709ddf Fix cross-site scripting (XSS) via HTML messages with malicious svg/namespace
Credits to SSD Secure Disclosure (https://ssd-disclosure.com/)
2020-07-03 11:29:50 +02:00