Commit Graph

95 Commits

Author SHA1 Message Date
Aleksander Machniak
f2688ba492 Use ?? operator where applicable 2021-09-21 19:12:06 +02:00
Aleksander Machniak
a493a31d84 Fix bug where consecutive LDAP searches could return wrong results (#8064) 2021-05-23 09:15:03 +02:00
Michael Stilkerich
74fab3e730 More extensive documentation for query-related rcube_addressbook API (#7958)
Also add list_records()'s $nocount parameter to all implementations
2021-05-15 14:15:21 +02:00
Josh Soref
203f456620 Spelling (#8001) 2021-04-18 08:43:18 +02:00
Aleksander Machniak
5aa0d09def Add array_first() helper, fix some code issues 2020-12-20 09:44:17 +01:00
Aleksander Machniak
f4ed1024dc PHP8 fixes, CS fixes, short array syntax, tests 2020-12-02 20:15:00 +01:00
Aleksander Machniak
66ca4f0f72 CS fixes, PHP8 fixes, short array syntax, tests 2020-11-30 14:03:11 +01:00
Aleksander Machniak
602c4a649d Un-skip the rcube_ldap test, fix some PHP8 compat. bugs 2020-11-02 10:23:10 +01:00
Aleksander Machniak
545a1569f1 Steps -> Actions refactoring (#7688)
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
a5c2b4360c Fixes in context of undefined variables, and code style 2020-08-15 12:13:31 +02:00
Aleksander Machniak
4cc20eef72 Fix bug where cache keys could exceed length limit specified in db schema (#7004) 2019-11-10 08:56:11 +01:00
Aleksander Machniak
66fab8cdb2 CS fixes, Avoid usused variables, fixed minor bugs 2019-10-05 19:44:39 +02:00
Aleksander Machniak
1afa46d28d PHPDoc and CS fixes 2019-08-25 14:15:09 +02:00
Aleksander Machniak
8932abd2e7 CS fixes 2019-06-05 10:47:17 +02:00
Aleksander Machniak
57c67db029 Remove year(s) from copyright headers + some cleanup 2019-04-16 10:42:45 +02:00
Aleksander Machniak
a35699637d Fix PHP error when using Net_LDAP3 from master
get_entry() method signature has changed. We don't really needed
that override in rcube_ldap_generic, so it's now removed.
2019-04-02 12:35:25 +02:00
Aleksander Machniak
c1aa2169f6 Plugin API: Added 'ldap_connected' hook 2018-11-26 09:43:43 +01:00
Aleksander Machniak
03fef0d6ca New_user_identity: Fix %fu/%u vars substitution in user specific LDAP params (#6419) 2018-09-12 11:06:05 +02:00
Aleksander Machniak
a2875cdda9 - Fix searching contacts by address in LDAP source (#6084) 2017-12-26 08:34:21 +00:00
Aleksander Machniak
97bf251dc6 Don't use create_function() deprecated in PHP 7.2 2017-07-08 16:12:58 +02:00
Aleksander Machniak
336a0cd87b strncasecmp() -> strcasecmp() 2017-05-19 14:41:25 +02:00
Aleksander Machniak
253aac5d9e Fix var name 2017-05-19 08:36:05 +02:00
Aleksander Machniak
0a7a95b714 Support LDAP GSSAPI authentication (#5703)
Requires https://git.kolab.org/rPNL1d87f98d300645e15b7ad2819fcffb19010a060f
2017-05-18 11:08:31 +02:00
Aleksander Machniak
712875bde1 Fix bug where base_dn setting was ignored inside group_filters (#5720) 2017-04-10 13:22:09 +02:00
Aleksander Machniak
19fcc35a55 Fix regression in LDAP fuzzy search where it always used prefix search instead (#5713) 2017-03-31 09:45:21 +02:00
Aleksander Machniak
a99e479cb4 Fix variable substitution in ldap host for some use-cases, e.g. new_user_identity (#5544) 2016-12-01 08:46:15 +01:00
Aleksander Machniak
55cdf1569e Support contact+group searches in all relevant places (T1360)
Before the search worked only in Addressbook, not also in Compose.
The point of the change is also to align group searches with contact searches
in that it now uses the same set of attributes. Previously groups
in Compose were searched by name only.
2016-08-08 07:12:39 -04:00
Aleksander Machniak
53b5ccfb0c Fix regression where LDAP results could be counted incorrectly when using VLV
... broken by d08bd0a51f where we added searching in users+groups in one request
2016-08-05 09:47:27 -04:00
dsoares
8e7e22c656 Avoid PHP fatal error
After last change to file `rcube_ldap.php`, my roundcube instance was getting this error:
```
PHP Fatal error:  Cannot use object of type Net_LDAP3_Result as array in ...
```
In
```php
protected function extended_search($count = false)
```
`$result = $this->ldap->search()` returns a LDAP object (whatever package we use).
If the search returns no results (and if `$is_extended_search` is false), then it gets to line 971 trying to do a `usort()` and then a `count()` on an object, instead of an array.
2016-06-27 12:44:59 +01:00
Aleksander Machniak
d08bd0a51f Searching in both contacts and groups when LDAP addressbook with group_filters option is used 2016-06-20 09:02:38 +02:00
Aleksander Machniak
7e3298753a Use ternary operator where aplicable 2015-11-14 10:08:07 +01:00
Aleksander Machniak
c8c4cafb1f Add possibility to define date format in write operations for ldap attributes (#1488741) 2015-10-09 13:44:45 +02:00
Aleksander Machniak
1b39d9a6c7 PHP7: Fixed some E_WARNING errors that previously were E_STRICT 2015-08-08 09:32:24 +02:00
Aleksander Machniak
212e332cef Get rid of array_walk() when simple foreach() can be used 2015-07-02 10:03:24 +02:00
Aleksander Machniak
d2890372c1 Fix Fatal error after last commit 2015-07-02 09:58:05 +02:00
Aleksander Machniak
6a8c4fc73b Fix issue when first search() argument is not an array 2015-07-02 09:09:24 +02:00
Aleksander Machniak
a958748947 CS fixes 2015-06-07 15:26:33 +02:00
Thomas Bruederli
0f63418b7e Use Net_LDAP3::domain_root_dn() to resolve the domain DN for the %dc variable; replaces PR #268 2015-04-29 14:02:23 +02:00
Aleksander Machniak
6cdffbf1b6 Fix "PHP Fatal error: Using $this when not in object context" 2015-03-04 11:55:52 -05:00
Thomas Bruederli
36ee2c8427 Improve LDAP search by ignoring words order in fuzzy substring matching mode 2015-03-03 14:53:02 +01:00
Aleksander Machniak
5aa1d2005b Fix parsing ldap URI for cases where hostname is non-empty 2015-02-27 10:06:30 +01:00
Aleksander Machniak
bf99c50cc1 Fix bug where empty fieldmap config entries caused empty results of ldap search (#1490229) 2015-01-21 10:29:08 +01:00
Aleksander Machniak
aafccefb88 Properly set fuzzy_search for vlv searches 2014-12-18 08:49:36 -05:00
Aleksander Machniak
9e4246d957 Code improvements and fixes (mostly unused variables and methods) 2014-11-16 14:04:53 +01:00
Thomas Bruederli
028734b25c Make LDAP errors available to the application 2014-08-18 17:21:03 +02:00
Thomas Bruederli
834fb6858e Allow to search for LDAP groups with 'group_filter' enabled 2014-08-13 13:04:24 +02:00
Jeroen van Meeuwen (Kolab Systems)
8ee8be9b86 Correct reference to old function get_dn() 2014-08-02 16:51:51 +02:00
Jeroen van Meeuwen (Kolab Systems)
6ac9395fbd Use Net_LDAP3 2014-08-02 16:46:29 +02:00
Thomas Bruederli
a2cf7c41b9 Fix accidental key replacements 2014-04-09 08:48:28 +02:00
Thomas Bruederli
1e9a59ab89 Don't remove messages from list when moving to another folder in multi-folder search mode, just update the list 2014-04-08 14:38:54 +02:00