Commit Graph

68 Commits

Author SHA1 Message Date
Aleksander Machniak
f2688ba492 Use ?? operator where applicable 2021-09-21 19:12:06 +02:00
Aleksander Machniak
5043255f7e Example_addressbook: Various improvements and fixes 2021-06-09 15:33:40 +02:00
Michael Stilkerich
74fab3e730 More extensive documentation for query-related rcube_addressbook API (#7958)
Also add list_records()'s $nocount parameter to all implementations
2021-05-15 14:15:21 +02:00
Josh Soref
203f456620 Spelling (#8001) 2021-04-18 08:43:18 +02:00
Michael Stilkerich
0608af9814 phpdoc type annotations to aid static analysis tools (#7957) 2021-03-21 14:39:17 +01:00
Aleksander Machniak
5ac44fd4ed PHPDoc fixes 2021-02-28 11:58:27 +01:00
Aleksander Machniak
a03a1db73c Tabs to spaces
[skip ci]
2021-02-06 16:59:05 +01:00
Michael Stilkerich
ae3f9c215e Improve preciseness of some PHPdoc annotations (#7809) 2021-01-09 10:05:46 +01:00
Aleksander Machniak
17ae3693c3 PHP8 fixes + fix fatal error when refreshing compose page in forward-as-attachment state 2020-12-18 19:27:25 +01:00
Aleksander Machniak
3bbb01fe13 PHP8 fixes, regression fixes 2020-12-13 12:14:15 +01:00
Michael Stilkerich
208e627198 Restore compatibility in rcube_addressbook::set_sort_order API (#7758) 2020-12-06 20:38:15 +01:00
Aleksander Machniak
66ca4f0f72 CS fixes, PHP8 fixes, short array syntax, tests 2020-11-30 14:03:11 +01:00
Aleksander Machniak
37d75d96a3 Short array syntax, CS fixes 2020-11-27 19:51:33 +01:00
Michael Stilkerich
bad1dedbf6 Phpdoc type annotations (#7733) 2020-11-21 09:34:24 +01:00
Aleksander Machniak
97991b59be Add more tests for contact actions, fix various code issues 2020-11-05 11:59:02 +01:00
Aleksander Machniak
e99fb3968d Add tests for contacts export action, fix PHP8 issues 2020-11-02 18:49:39 +01:00
Aleksander Machniak
e2572b8984 PHP8 compat. fixes, added some tests 2020-11-02 08:55:42 +01:00
Aleksander Machniak
545a1569f1 Steps -> Actions refactoring (#7688)
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
9713ce364c Automatically collected recipients and trusted senders (#6904)
Added configurable Collected Recipients addressbook source (#4971)
Added configurable Trusted Senders addressbook source (#5046)
Added 'contact_exists' hook
2020-09-20 10:00:08 +02:00
Aleksander Machniak
a5c2b4360c Fixes in context of undefined variables, and code style 2020-08-15 12:13:31 +02:00
Michael Stilkerich
25e42439d2 Fix inconsistencies in phpdoc type annotations (#7474) 2020-07-25 09:59:01 +02:00
Aleksander Machniak
66fab8cdb2 CS fixes, Avoid usused variables, fixed minor bugs 2019-10-05 19:44:39 +02:00
Aleksander Machniak
1afa46d28d PHPDoc and CS fixes 2019-08-25 14:15:09 +02:00
Aleksander Machniak
57c67db029 Remove year(s) from copyright headers + some cleanup 2019-04-16 10:42:45 +02:00
Aleksander Machniak
d3c65d752b Remove useless "return null;" at the end of function block 2018-12-27 11:03:47 +01:00
Aleksander Machniak
6691756ea1 Fix bug where unicode contact names could have been broken/emptied or caused DB errors (#6299) 2018-05-25 12:29:36 +02:00
Aleksander Machniak
ce338164e3 Fix bug where contacts search could skip some records (#6130) 2018-01-10 11:52:35 +01:00
Aleksander Machniak
d151afd229 Fix addressbook searching by gender (#5757) 2017-05-11 08:56:42 +02:00
Aleksander Machniak
9b554cd3d5 Remove redundant spaces from generated contact names 2017-03-20 09:15:50 +01:00
ka7
9a35768c26 spelling fixes (#5690) 2017-03-12 12:14:19 +01:00
Aleksander Machniak
184de7735c CS fixes (mostly phpdoc) 2016-08-18 08:50:59 +02:00
Aleksander Machniak
55cdf1569e Support contact+group searches in all relevant places (T1360)
Before the search worked only in Addressbook, not also in Compose.
The point of the change is also to align group searches with contact searches
in that it now uses the same set of attributes. Previously groups
in Compose were searched by name only.
2016-08-08 07:12:39 -04:00
Aleksander Machniak
52106ffd39 Fix bug where rcube_contacts::get_record() could return cached result when requested record wasn't found (#5218) 2016-04-20 20:25:23 +02:00
Aleksander Machniak
d5f7490b08 Fix PHP Fatal error: Can't use function return value in write context 2016-01-11 12:52:49 +01:00
James Buncle
fd0244dabf Ensure roundcube doesn't render contact names as blank (when the name is whitespace) 2016-01-07 16:21:22 +00:00
Aleksander Machniak
7e3298753a Use ternary operator where aplicable 2015-11-14 10:08:07 +01:00
Aleksander Machniak
a03233ceba CS fixes 2015-10-07 09:14:18 +02:00
Aleksander Machniak
a958748947 CS fixes 2015-06-07 15:26:33 +02:00
Aleksander Machniak
83f1f6b12f Improve compose_search_name() to not return "email@address <email@address>" entries
which may happen for contacts without name(s)
2015-02-25 09:24:14 -05:00
Aleksander Machniak
4d90e6596d Use also Organization field as a fallback if contact has no name(s) specified 2015-02-24 05:15:35 -05:00
Thomas Bruederli
25a9ec7bb7 Allow caller to supply the template for contact name composition 2014-08-18 14:16:20 +02:00
Thomas Bruederli
6a0a4a3a52 Remove empty brackets, slashes and spaces from contact search name 2014-08-18 10:00:45 +02:00
Aleksander Machniak
83316e175d Reset $value in a loop 2014-07-23 12:15:50 +02:00
Aleksander Machniak
36d004e3d0 Added 'contact_search_name' option to define autocompletion entry format 2014-07-03 14:25:19 +02:00
Aleksander Machniak
029f7a157d Clarify update() result description, return boolean when ID didn't change 2013-12-08 09:39:33 +01:00
Aleksander Machniak
18b40c1a32 Fix issue where groups were not deleted when "Replace entire addressbook" option on contacts import was used (#1489420) 2013-12-04 13:58:43 +01:00
Takika
03713dbf5d Add contact_listname hook to handle special name order
I can modify the addressbook_name_listing variable via main config or preferences_list_hook but I have to change the rcube_addressbook class to use the modified value. Some contry use special [name orders](http://en.wikipedia.org/wiki/Personal_name#Name_order) and we can handle them with this hook.
I changed the hook name to contact_listname as proposed by thomascube in the original PR#127.
2013-10-21 15:33:07 +02:00
Thomas Bruederli
d29f781080 Let plugins state a validation error message 2013-10-19 16:01:13 +02:00
Thomas Bruederli
a693639613 Require name or email for sql address book only 2013-10-19 15:51:12 +02:00
Thomas Bruederli
49b8e5d0bb Add plugin hook 'contact_validate' to let plugins validate contact records 2013-10-19 15:49:49 +02:00