Commit Graph

1335 Commits

Author SHA1 Message Date
Aleksander Machniak
b4b24f93df Fix some PHP8 warnings 2021-01-15 18:56:48 +01:00
Michael Stilkerich
ae3f9c215e Improve preciseness of some PHPdoc annotations (#7809) 2021-01-09 10:05:46 +01:00
Aleksander Machniak
39b3c0049e Fix cross-site scripting (XSS) via HTML or Plain text messages with malicious content [CVE-2020-35730]
Credits to Alex Birnberg <birnbergalex@gmail.com>
2020-12-27 18:27:42 +01:00
Aleksander Machniak
02ab855c8b Never return null from rcube_addresses::search() 2020-12-27 12:10:49 +01:00
johndoh
dec10e51da Support providing skins for plugins inside the main skin folder (#7445) 2020-12-21 09:45:34 +01:00
Aleksander Machniak
5aa0d09def Add array_first() helper, fix some code issues 2020-12-20 09:44:17 +01:00
Aleksander Machniak
66062846ec Fix "unitialized string offset" warnings 2020-12-19 19:43:36 +01:00
johndoh
cfd4fa170f Fix a few PHP notices (#7791) 2020-12-19 19:36:58 +01:00
Aleksander Machniak
8b83d29f24 PHP8 fixes, do not require specific error_reporting setting anymore 2020-12-19 10:01:10 +01:00
Aleksander Machniak
17ae3693c3 PHP8 fixes + fix fatal error when refreshing compose page in forward-as-attachment state 2020-12-18 19:27:25 +01:00
Aleksander Machniak
c0510aaab3 GA: See if we can test PHP8 now 2020-12-13 12:27:23 +01:00
Aleksander Machniak
3bbb01fe13 PHP8 fixes, regression fixes 2020-12-13 12:14:15 +01:00
Aleksander Machniak
12547ccf01 Require php-intl extension, get rid of Net_IDNA2, PHP8 fixes, short array syntax
Net_IDNA2 is not compatible, and Intl is a bundled ext since PHP 5.3.
Fixed some regressions.
2020-12-13 10:21:52 +01:00
Aleksander Machniak
61a5ade872 PHP8 fixes, short array syntax 2020-12-12 16:20:14 +01:00
Aleksander Machniak
8eb382b4ca PHP8 fixes 2020-12-11 20:29:41 +01:00
Michael Stilkerich
208e627198 Restore compatibility in rcube_addressbook::set_sort_order API (#7758) 2020-12-06 20:38:15 +01:00
Aleksander Machniak
f4ed1024dc PHP8 fixes, CS fixes, short array syntax, tests 2020-12-02 20:15:00 +01:00
Aleksander Machniak
8110ed9a9d PHP8 fixes, CS fixes, short array syntax, tests 2020-11-30 20:37:50 +01:00
Aleksander Machniak
66ca4f0f72 CS fixes, PHP8 fixes, short array syntax, tests 2020-11-30 14:03:11 +01:00
Aleksander Machniak
85cfacc882 PHP8 fixes, CS fixes, short array syntax, tests 2020-11-29 12:20:51 +01:00
Aleksander Machniak
7e5301f636 CS fixes, short array syntax, PHP8 fixes, tests 2020-11-28 18:52:36 +01:00
Aleksander Machniak
007f9b81cf Lower SQLite version requirement 2020-11-28 16:05:19 +01:00
Aleksander Machniak
066faa1485 CS fixes, short array syntax, PHP8 fixes, tests
also fixed listing of table columns on SQLite database
2020-11-28 10:06:41 +01:00
Aleksander Machniak
37d75d96a3 Short array syntax, CS fixes 2020-11-27 19:51:33 +01:00
Aleksander Machniak
c98059e43d Short array syntax, CS fixes, tests 2020-11-26 20:34:35 +01:00
Aleksander Machniak
c94ad33280 Bump dusk version 2020-11-23 09:52:58 +01:00
Aleksander Machniak
0cbe4a4acc PHP8 fixes, CS fixes, short array syntax, added more tests 2020-11-22 12:03:02 +01:00
Michael Stilkerich
bad1dedbf6 Phpdoc type annotations (#7733) 2020-11-21 09:34:24 +01:00
Aleksander Machniak
1164d9e103 rcmail_utils::get_http_client() -> rcube::get_instance()->get_http_client() 2020-11-21 09:28:25 +01:00
ATA
8f81fda450 Support proxy for server-side HTTP requests #7658 (#7659)
Co-authored-by: Andrzej Talarek <andrzej.talarek@efinity.com>
2020-11-21 09:07:49 +01:00
Jacques Belin
8ad73423d4 Plugin API: Added 'preferences' parameter to 'user_create' hook (#7692) 2020-11-21 09:05:59 +01:00
Aleksander Machniak
8b16a7dfe7 More tests 2020-11-08 11:06:42 +01:00
Aleksander Machniak
596004beb3 More actions tests, code improvements 2020-11-07 12:54:12 +01:00
Aleksander Machniak
97991b59be Add more tests for contact actions, fix various code issues 2020-11-05 11:59:02 +01:00
Aleksander Machniak
e99fb3968d Add tests for contacts export action, fix PHP8 issues 2020-11-02 18:49:39 +01:00
Aleksander Machniak
4a3bed3183 Merge branch 'master' of github.com:roundcube/roundcubemail 2020-11-02 13:42:28 +01:00
Aleksander Machniak
602c4a649d Un-skip the rcube_ldap test, fix some PHP8 compat. bugs 2020-11-02 10:23:10 +01:00
Aleksander Machniak
318f91417f Add rcube_utils::explode() 2020-11-02 09:02:38 +01:00
Aleksander Machniak
e2572b8984 PHP8 compat. fixes, added some tests 2020-11-02 08:55:42 +01:00
Thomas P
57a77dbace Fixing typo (#7689)
Typo for work_dept value
2020-11-01 21:12:44 +01:00
Aleksander Machniak
ad05e97254 Fix parsing small eml attachments (#7671) 2020-11-01 11:26:48 +01:00
Aleksander Machniak
545a1569f1 Steps -> Actions refactoring (#7688)
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
f95212d626 PHP8: More warnings fixed 2020-10-11 15:24:30 +02:00
PhilW
7b2f135bc6 add field mapping step to csv contact import 2020-10-11 10:25:30 +01:00
Aleksander Machniak
bde383d051 PHP8: Fix various issues
for now only these I found by running our unit tests, there will be much more
2020-10-11 10:32:41 +02:00
Michael Stilkerich
67825e6320 MySQL: Don't reissue query after deadlock error (#7529)
When a deadlock error occurs, MySQL rolls back the _entire_ ongoing
transaction. The application would have to restart the transaction from
the beginning to retry if wanted.

Now roundcube in that case simply retries the statement that raised the
deadlock error, even though everything else in the transaction was
rolled back. This breaks transaction isolation, leaves the database in a
potentially inconsistent state (from the application's data consistency
model point of view), and does not indicate to the application there was
a problem at all to it may even continue executing other potentially
remaining statements of a transaction that has already been rolled back.

-> Remove the retries from roundcube. Retries have to be initiated by
the application if desired, not only retrying the last statement but the
entire transaction from the beginning.
2020-09-25 12:32:25 +02:00
Aleksander Machniak
d81b8447fb Fix empty output from HTML5 parser when content contains XML tag (#7624) 2020-09-23 15:15:02 +02:00
Aleksander Machniak
1cc9d4f566 Bump minimum PHP version to 5.5, bump guzzle version (#7616) 2020-09-23 11:00:57 +02:00
Aleksander Machniak
f0084b6f54 Fix empty space on mail printouts in Chrome (#7604) 2020-09-23 10:49:16 +02:00
Aleksander Machniak
d30f039e5a Use PDO::ATTR_CLIENT_VERSION when PDO::ATTR_DRIVER_VERSION does not exist (#7564) 2020-09-20 14:45:43 +02:00