Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Edouard Vanbelle
77aca18bd5
Refactorize request_access_token() returning a simple boolean ( #9299 )
2024-01-06 08:34:12 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
a9167a0d2f
Fix "static_lambda" CS ( #9276 )
2023-12-20 20:01:00 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
93946f4ca7
Fix "self_accessor" PHP CS Fixer rule ( #9269 )
2023-12-17 09:44:43 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Michael Voříšek
f9a9ec49b0
Fix format_date with "x" format for Windows ( #9250 )
...
* Fix format_date with "x" format for Windows
* set default Intl locale and use it
* harden default test config
2023-12-10 15:30:22 +01:00
Aleksander Machniak
7c1665b08f
Fix PHP8 warning ( #9160 )
2023-10-08 09:51:37 +02:00
Aleksander Machniak
6f35b2cc5b
More fixes regarding rcmail::url() ( #9052 )
2023-07-10 18:27:56 +02:00
Aleksander Machniak
d2e8a889c4
Fix regression that broke use_secure_urls feature ( #9052 )
2023-07-09 11:23:44 +02:00
Aleksander Machniak
bac152444b
Fix listing subfolders of Trash in logout actions on servers with specific NAMESPACE definition
2023-05-10 21:34:19 +02:00
Aleksander Machniak
63f63e8f4d
Fix regression in OAuth request URI caused by use of REQUEST_URI instead of SCRIPT_NAME as a default ( #8878 )
2023-01-26 18:14:36 +01:00
Aleksander Machniak
6251d38ecd
Fix PHP warning
2023-01-08 11:45:44 +01:00
Aleksander Machniak
2d00d18e6c
Rename 'request_uri_field' to 'request_path' and allow a path in it ( #8738 , #8770 )
2023-01-08 09:54:19 +01:00
Aleksander Machniak
c65763f59b
Make rcmail::format_date() to work with DateTimeImmutable
2022-12-29 14:14:54 +01:00
Aleksander Machniak
631dc5a839
Fix get_address_book() issue for addressbooks that have a string identifier starting with a digit
2022-12-01 10:00:16 +01:00
Thomas B
409aee8b3c
Add config option for request uri field ( #8738 ) ( #8770 )
...
This can be used to read a custom header sent by a reverse proxy to resolve the absolute path to Roundcube
* add check against the proxy_whitelist option before using a HTTP header field value for the request uri composition.
* refactor the rcmail::url() method to also work when composing fully qualified urls.
* fix/adapt tests
2022-11-23 21:05:00 +01:00
Aleksander Machniak
80404a8674
Store uploads metadata in a separate sql database table instead of a session ( #8415 )
2022-10-09 11:35:14 +02:00
Aleksander Machniak
aac9b696b8
Fix various PHP 8.2 warnings
2022-08-06 09:22:12 +02:00
Aleksander Machniak
f8b2afac0c
Update changelog and tests
2022-06-25 09:48:23 +02:00
Player701
82fec17d34
Fix so rcmail::contact_exists() works with IDNA addresses ( #8545 )
2022-06-25 09:21:17 +02:00
Aleksander Machniak
7b81a71393
Don't use TLS by default ( #8359 )
...
Also unify the common code with a new rcube_utils::parse_host_uri() method
2021-12-11 09:52:23 +01:00
Aleksander Machniak
893216cb29
Unified and simplified services connection options ( #8310 )
2021-12-07 15:07:54 +01:00
Aleksander Machniak
28b6351750
Fix compatibility with Referrer-Policy: "strict-origin" ( #8170 )
2021-11-13 10:02:24 +01:00
Aleksander Machniak
a968f52dcd
Fix PHP8 warnings ( #8286 )
2021-11-06 09:09:19 +01:00
Aleksander Machniak
8a4eecbcb0
Don't write stats info to console.log when in CLI
...
If the file was created by the web server user, user executing the CLI command
might have no permissions. This leads to an error, and e.g. when installing
a plugin/skin via composer is converted to an ugly exception. We want to prevent that.
Anyway, these stats are most useful for the webmail use not for CLI commands.
2021-10-24 15:53:47 +02:00
Aleksander Machniak
81cc8ac0e0
Purge also subfolders of Trash (and/or messages in them) on logout ( #1037 )
2021-10-09 16:55:28 +02:00
Aleksander Machniak
14522d7108
get_input_value() -> get_input_string()
2021-09-26 11:34:31 +02:00
Aleksander Machniak
f2688ba492
Use ?? operator where applicable
2021-09-21 19:12:06 +02:00
Aleksander Machniak
d7338a4203
Add option to purge deleted mails older than 30, 60 or 90 days ( #5493 )
2021-08-29 11:06:04 +02:00
Aleksander Machniak
cb37d14c5c
Support responses (snippets) in HTML format ( #5315 )
2021-08-28 19:17:19 +02:00
Aleksander Machniak
e2187b8f2d
Fix various PHP 8.1 warnings
2021-08-27 16:52:54 +02:00
Aleksander Machniak
67d3b0fe63
Update changelog, code cleanup
2021-08-04 10:51:08 +02:00
Nico Antkowiak
12c7ea581d
Add option to control links handling behavior on html to text conversion ( #6485 )
...
Co-authored-by: NAN <antkowiak@dionera.com >
2021-08-04 10:37:14 +02:00
Aleksander Machniak
1aa52f89cb
Dropped support for strftime-like format (with % sign) in date and time format configuration
2021-08-01 10:11:26 +02:00
Josh Soref
203f456620
Spelling ( #8001 )
2021-04-18 08:43:18 +02:00
Aleksander Machniak
39f8f639b5
Fix PHP8 fatal error when allowing images in an email ( #7968 )
2021-03-26 18:43:28 +01:00
Aleksander Machniak
b7ac23ea5d
new_user_identity: Fix missing password for user-specific LDAP operations ( #7667 )
2021-02-07 09:55:41 +01:00
johndoh
1eebfd723b
Improve detection of external urls for redirect ( #7823 )
2021-01-23 10:15:09 +01:00
Aleksander Machniak
ec9c352ecb
Fix regression in handling save-pref action
2021-01-18 19:34:19 +01:00
Aleksander Machniak
118453c6ae
Initialise output also in cli mode
2021-01-10 18:07:24 +01:00
Aleksander Machniak
66062846ec
Fix "unitialized string offset" warnings
2020-12-19 19:43:36 +01:00
Aleksander Machniak
8b83d29f24
PHP8 fixes, do not require specific error_reporting setting anymore
2020-12-19 10:01:10 +01:00
Aleksander Machniak
21e1ed5c32
Remove redundant func_get_arg() call
2020-11-27 09:20:35 +01:00
