Commit Graph

1691 Commits

Author SHA1 Message Date
Aleksander Machniak
e99fb3968d Add tests for contacts export action, fix PHP8 issues 2020-11-02 18:49:39 +01:00
Aleksander Machniak
4a3bed3183 Merge branch 'master' of github.com:roundcube/roundcubemail 2020-11-02 13:42:28 +01:00
Aleksander Machniak
602c4a649d Un-skip the rcube_ldap test, fix some PHP8 compat. bugs 2020-11-02 10:23:10 +01:00
Aleksander Machniak
318f91417f Add rcube_utils::explode() 2020-11-02 09:02:38 +01:00
Aleksander Machniak
e2572b8984 PHP8 compat. fixes, added some tests 2020-11-02 08:55:42 +01:00
Thomas P
57a77dbace Fixing typo (#7689)
Typo for work_dept value
2020-11-01 21:12:44 +01:00
Aleksander Machniak
ad05e97254 Fix parsing small eml attachments (#7671) 2020-11-01 11:26:48 +01:00
Aleksander Machniak
545a1569f1 Steps -> Actions refactoring (#7688)
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
f95212d626 PHP8: More warnings fixed 2020-10-11 15:24:30 +02:00
PhilW
7b2f135bc6 add field mapping step to csv contact import 2020-10-11 10:25:30 +01:00
Aleksander Machniak
bde383d051 PHP8: Fix various issues
for now only these I found by running our unit tests, there will be much more
2020-10-11 10:32:41 +02:00
Michael Stilkerich
67825e6320 MySQL: Don't reissue query after deadlock error (#7529)
When a deadlock error occurs, MySQL rolls back the _entire_ ongoing
transaction. The application would have to restart the transaction from
the beginning to retry if wanted.

Now roundcube in that case simply retries the statement that raised the
deadlock error, even though everything else in the transaction was
rolled back. This breaks transaction isolation, leaves the database in a
potentially inconsistent state (from the application's data consistency
model point of view), and does not indicate to the application there was
a problem at all to it may even continue executing other potentially
remaining statements of a transaction that has already been rolled back.

-> Remove the retries from roundcube. Retries have to be initiated by
the application if desired, not only retrying the last statement but the
entire transaction from the beginning.
2020-09-25 12:32:25 +02:00
Aleksander Machniak
d81b8447fb Fix empty output from HTML5 parser when content contains XML tag (#7624) 2020-09-23 15:15:02 +02:00
Aleksander Machniak
1cc9d4f566 Bump minimum PHP version to 5.5, bump guzzle version (#7616) 2020-09-23 11:00:57 +02:00
Aleksander Machniak
f0084b6f54 Fix empty space on mail printouts in Chrome (#7604) 2020-09-23 10:49:16 +02:00
Aleksander Machniak
d30f039e5a Use PDO::ATTR_CLIENT_VERSION when PDO::ATTR_DRIVER_VERSION does not exist (#7564) 2020-09-20 14:45:43 +02:00
Michael Steininger
6345982655 Add $lang argument to read_localization (#7599) 2020-09-20 11:13:15 +02:00
Aleksander Machniak
9713ce364c Automatically collected recipients and trusted senders (#6904)
Added configurable Collected Recipients addressbook source (#4971)
Added configurable Trusted Senders addressbook source (#5046)
Added 'contact_exists' hook
2020-09-20 10:00:08 +02:00
Aleksander Machniak
7d3d806411 Fix PHP Fatal error: Cannot access protected property rcube_message::$body (#7588) 2020-09-05 08:46:01 +02:00
Aleksander Machniak
5264534c46 Fix bug where some parts of a message could have been missing in a reply/forward body (#7568) 2020-08-30 10:56:13 +02:00
Aleksander Machniak
77bc3f2427 Fix incorrect PDO::lastInsertId() use in sqlsrv driver (#7564) 2020-08-28 09:41:19 +02:00
Aleksander Machniak
e476211230 Fix error when dealing with message/rfc822 attachments using Gmail IMAP (#6854) 2020-08-23 10:18:10 +02:00
Aleksander Machniak
535816db22 Describe all() method on more detail (#6219) 2020-08-23 09:39:55 +02:00
Aleksander Machniak
b7d4596aa9 Fix regression (#7557) 2020-08-16 16:32:18 +02:00
Aleksander Machniak
bf15b5ed92 Fix regression 2020-08-16 12:28:04 +02:00
Aleksander Machniak
a5c2b4360c Fixes in context of undefined variables, and code style 2020-08-15 12:13:31 +02:00
Aleksander Machniak
d445f8ad12 Fix importing birthday dates from Gmail vCards (BDAY:YYYYMMDD) 2020-08-12 11:25:44 +02:00
Thomas B
9020797d0d Merge pull request #7425 from thomascube/pr-xoauth2
Add OAuth/XOauth support
2020-08-10 21:40:01 +02:00
Aleksander Machniak
ec4cc29c88 Fix cross-site scripting (XSS) via HTML messages with malicious svg or math content 2020-08-09 18:02:16 +02:00
Achim Leitner
8e0ee8b1c4 Fix: Keep children of object tag (#6453)
The HTML tag <object> optionally has embedded (child) tags that serve as an
alternative (fallback) HTML representation for the object. Of course, the
object and its parameters are considered harmful in HTML mail, but the
alternative representation is meant for exactly this kind of situation. They
should display the object contents without loading possibly insecure code.

- By ignoring <object> tags, roundcube also removes all their child nodes
- As <object> is not in the list of allowed $html_elements and <param> gets
  cleaned through $void_elements, they get ignored anyway, without removing the
  valuable child nodes.

Co-authored-by: root <root@coreboso-kolab.coreboso.de>
2020-08-07 11:06:14 +02:00
Aleksander Machniak
3e2f076628 Fix bug in conversion of email addresses to mailto links in plain text messages (#7526) 2020-08-07 10:03:56 +02:00
Aleksander Machniak
60ccb25bd5 Fix detecting special folders on servers with both SPECIAL-USE and LIST-STATUS (#7525) 2020-07-31 14:36:57 +02:00
Aleksander Machniak
ef9b375ef6 Fix paging of search results on IMAP servers with no SORT capability (#7462)
And simplify some code around.
2020-07-30 13:23:37 +02:00
Aleksander Machniak
17deadfe56 Fix handling links without defined protocol (#7454) 2020-07-29 15:17:48 +02:00
Aleksander Machniak
0d9bffa878 Fix incorrect rewriting of internal links in HTML content (#7512) 2020-07-29 14:19:02 +02:00
Michael Stilkerich
25e42439d2 Fix inconsistencies in phpdoc type annotations (#7474) 2020-07-25 09:59:01 +02:00
Aleksander Machniak
0ccb351380 Fix regression in DB cache (#7499) 2020-07-21 20:15:05 +02:00
Aleksander Machniak
d7d7ca046f Cache refactoring (#6312) (#6781) 2020-07-18 13:51:47 +02:00
Aleksander Machniak
e2c25a1949 Fix support for an error as a string in message_before_send hook (#7475) 2020-07-18 08:24:44 +02:00
Aleksander Machniak
1e1ea25b6c Added special value 'email' to login_username_filter, it changes also logon input type (#7179) 2020-07-03 12:56:17 +02:00
Aleksander Machniak
32a7709ddf Fix cross-site scripting (XSS) via HTML messages with malicious svg/namespace
Credits to SSD Secure Disclosure (https://ssd-disclosure.com/)
2020-07-03 11:29:50 +02:00
Aleksander Machniak
bb3975adbe Fix insert_or_update() broken on SQLite/MSSQL/Oracle (#7465) 2020-07-02 08:41:50 +02:00
Aleksander Machniak
b22f1c9a1b Add skip-empty option to get_edit_field() (#7444) 2020-06-27 10:29:40 +02:00
Thomas Bruederli
1e6a2f4f49 Basic support for OAuth2 user login and IMAP/SMTP authentication
- Add "Login with XXX" button to login screen if oauth is configured
- Perform OAuth login procedure and get an access token
- Implement XOAUTH2 authentication type for IAMP and SMTP

Requires a patched and not yet released version of Net_SMTP.
2020-06-16 08:17:52 +02:00
Aleksander Machniak
9ee1f4b636 Merge branch 'master' of github.com:roundcube/roundcubemail 2020-06-13 13:00:11 +02:00
Aleksander Machniak
30610e867e Merge branch 'fix_encode' of https://github.com/shirosaki/roundcubemail into shirosaki-fix_encode
Refactor the new code
2020-06-13 12:53:31 +02:00
johndoh
9dbe666d4c Allow skins to define which layout options they support (#7235) 2020-06-13 09:25:50 +02:00
Kent Varmedal
b4dabff26c Add newline when writing logs to stdout (#7418)
Add newline on the end of the line when printing to stdout.
2020-06-13 07:48:13 +02:00
Aleksander Machniak
e9c592a6e8 Fix bug where subfolders of special folders could have been duplicated on folder list 2020-06-08 20:35:19 +02:00
Aleksander Machniak
4e00237cc4 Allow opening application/octet-stream attachments according to filename extension (#6821) 2020-06-07 10:45:33 +02:00