Commit Graph

7602 Commits

Author SHA1 Message Date
Aleksander Machniak
0df8e97476 Small code improvement + tests 2021-03-22 16:11:38 +01:00
Aleksander Machniak
12562a7b0e Remove redundant code from rcube_charset::clean() 2021-03-22 08:36:19 +01:00
Michael Stilkerich
2e88de27db Fix phpdoc for rcube::decrypt() (#7956)
* Fix phpdoc for rcube::decrypt()
* Adapt rcube::decrypt() to return false on error
2021-03-21 14:46:14 +01:00
Michael Stilkerich
0608af9814 phpdoc type annotations to aid static analysis tools (#7957) 2021-03-21 14:39:17 +01:00
Aleksander Machniak
1aa7b15f6d Fix spoofchecker on PHP <= 7.0 2021-03-21 10:14:02 +01:00
Aleksander Machniak
b913d2fbde Add IDN homograph attack (spoofing) detection [CVE-2019-15237] (#6891) 2021-03-21 09:25:57 +01:00
Aleksander Machniak
75c604aa39 Upgrade to TinyMCE 5.7.1 2021-03-18 19:03:21 +01:00
Thomas Bruederli
8fdf37bf21 Set absolute path for assets if PATH_INFO is set (#7812,#7923) 2021-03-15 21:20:07 +01:00
Aleksander Machniak
435d6c6fc2 Don't cache disabled_actions setting in memory
If some plugin changed the setting after first button() method
use, the change would not have been seen in the rest of the method calls.
2021-03-15 14:12:37 +01:00
Aleksander Machniak
1b08ccd384 Fix so selecting the same folder to reset search resets also the page number (#7125) 2021-03-14 09:46:33 +01:00
Aleksander Machniak
39086d4c87 Fix so session expiration is more precise and do not depend on the garbage collector (#7576) 2021-03-13 10:08:00 +01:00
Aleksander Machniak
9508059b90 Plugin API: Allow modification of 'error' argument in 'message_send_error' hook (#7914) 2021-03-13 08:54:30 +01:00
Aleksander Machniak
6722ba0da3 Fix bug where the list page wasn't reset when changing a folder on mail view page (#7932) 2021-03-13 08:17:43 +01:00
Aleksander Machniak
5ec509f87e FIX PHP8 fatal error and some warnings (#7931) 2021-03-10 18:24:18 +01:00
Aleksander Machniak
7091e65f80 Fix bug when sending an email and recipient's email address contains a trailing dot (#7899) 2021-03-06 09:59:35 +01:00
Aleksander Machniak
dd6aefe1fd Fix bug where imap_conn_options settings were ignored (#7912) 2021-03-04 19:14:28 +01:00
Aleksander Machniak
5ac44fd4ed PHPDoc fixes 2021-02-28 11:58:27 +01:00
Aleksander Machniak
ac8e067ae6 Use official GPL-3.0-or-later license identifier (#7901) 2021-02-24 15:39:36 +01:00
Aleksander Machniak
a8afce5fb4 Fix so allowing remote resources does not add an entry to browser history (#6620) 2021-02-21 11:49:36 +01:00
Aleksander Machniak
8cf8a47381 new_user_identity: Make sure email_list includes the main user email (#7085) 2021-02-21 10:20:52 +01:00
Aleksander Machniak
ab37678da8 Fix PHP8 warning 2021-02-21 09:48:46 +01:00
Thomas P
98b105aed8 Do not remove commas in groups/categories list (#7690) 2021-02-20 10:10:14 +01:00
Aleksander Machniak
529c1a29a3 Fix invalid IMAP SEARCH command in some rare case on messages cache synchronization (#7895) 2021-02-20 09:36:47 +01:00
Aleksander Machniak
277e66b2ac Fix undefined index warning 2021-02-15 11:34:14 +01:00
Aleksander Machniak
747bcd2ff4 Fix handling of table prefix and quoting in insert_or_update()
In all places we use this function the $table argument has already
been passed through table_name() method, i.e. it contains the prefix
and is quoted. So, we should not do this again.
2021-02-15 11:31:06 +01:00
Aleksander Machniak
fdd52a5312 Give more prio to $user_email property in get_user_email(), follow up fix for #7667 2021-02-09 18:31:57 +01:00
Aleksander Machniak
cdd65d91c0 Update localization 2021-02-09 09:47:15 +01:00
Aleksander Machniak
9f19b931e3 Fix cross-site scripting (XSS) via HTML messages with malicious CSS content
and improve css parsing code.

Thanks to Mateusz Szymaniec (CERT Polska) for reporting the issue.
2021-02-08 13:42:12 +01:00
Aleksander Machniak
b7ac23ea5d new_user_identity: Fix missing password for user-specific LDAP operations (#7667) 2021-02-07 09:55:41 +01:00
Aleksander Machniak
a03a1db73c Tabs to spaces
[skip ci]
2021-02-06 16:59:05 +01:00
hefee
8ef57a4173 Add 'reconnect' plugin to retry IMAP connection (#7844)
* Make storage_connect hook ready to be usable for reconnect plugins.
* Add reconnect plugin to retry to login into IMAP server.

Co-authored-by: Sandro Knauß <hefee@debian.org>
2021-02-06 16:46:21 +01:00
Aleksander Machniak
79b5343563 Fix handling of address groups in email headers by ignoring their names (#7663) 2021-02-06 16:41:50 +01:00
johndoh
2d38d6e30b fix typo (#7866) 2021-01-31 11:37:33 +01:00
Aleksander Machniak
79f839b2f6 Fix so message flags are updated on refresh also for multifolder search results (#7774) 2021-01-31 10:25:49 +01:00
Aleksander Machniak
cdeccac627 Also ignore PHP8 warnings on iconv() use with invalid encoding 2021-01-30 17:59:09 +01:00
johndoh
79af30e924 Add preauth_ident parameter (#7863) 2021-01-30 15:53:39 +01:00
Aleksander Machniak
d258f845ab Fix PHP8 Fatal error: Uncaught ValueError: mb_convert_encoding() (#7850)
Also, bring back iconv() fallback, it supports much more charsets than mbstring.
2021-01-30 15:51:23 +01:00
Aleksander Machniak
5975742bcb Fix so IMAP ID command is send only after authentication (#7517) 2021-01-24 09:39:25 +01:00
johndoh
1eebfd723b Improve detection of external urls for redirect (#7823) 2021-01-23 10:15:09 +01:00
Aleksander Machniak
5d2668a260 Bring the old error_reporting setting back 2021-01-23 10:02:41 +01:00
Thomas Bruederli
375d668064 Hide login form fields when oauth_login_redirect is configured (#7830) 2021-01-18 21:17:48 +01:00
Aleksander Machniak
ec9c352ecb Fix regression in handling save-pref action 2021-01-18 19:34:19 +01:00
Aleksander Machniak
b4b24f93df Fix some PHP8 warnings 2021-01-15 18:56:48 +01:00
Aleksander Machniak
a9e50951ee Fix PHP warnings/notices 2021-01-14 19:18:53 +01:00
Thomas Bruederli
1d8fc71cad Do not auto-redirect on oauth login failures (#7812) 2021-01-12 22:14:54 +01:00
Aleksander Machniak
118453c6ae Initialise output also in cli mode 2021-01-10 18:07:24 +01:00
Aleksander Machniak
6a12cb7b67 Remove browser compatibility check
Improved code style, localized some more errors.
Added tests for utils/error action
2021-01-10 11:46:47 +01:00
Aleksander Machniak
837078cd23 Fix mail search error on invalid search_mods definition (#7789) 2021-01-10 10:30:43 +01:00
johndoh
5fdf8e62df Add placeholder text when no responses on compose screen (#7807) 2021-01-09 18:59:16 +01:00
Aleksander Machniak
703c9287b1 Use SameSite=Lax for cookies set client-side
to silence an annoying warning in Firefox console.
2021-01-09 13:10:33 +01:00