Aleksander Machniak
4e7d5c601e
Code improvements
2024-03-17 08:47:00 +01:00
Michael Voříšek
332c165d28
Fix some basic JS CS ( #9328 )
...
* fix "nonblock-statement-body-position" (fixed already)
* fix "comma-dangle"
* fix "no-regex-spaces"
* fix "new-parens"
* fix "object-curly-newline"
* fix "object-property-newline"
* fix "spaced-comment" semimanually
* fix "no-constant-condition" manually
* fix "unicorn/no-hex-escape"
* fix "unicorn/escape-case"
* fix "quote-props"
* fix "no-whitespace-before-property" - fix bug/typo
* fix "unicorn/empty-brace-spaces"
* fix "keyword-spacing"
* fix "dot-notation"
* fix "no-return-assign" manually
* fix "padding-line-between-statements"
* fix "key-spacing"
* fix "no-else-return" semimanually
* fix some "no-undef"
* fix case cs
* Revert "fix "padding-line-between-statements""
* improve switch/case format I.
* improve switch/case format II.
regex: (^ *(break|return).*)\n *(\n)
* fix safe "eqeqeq"
* fix "radix"
* fix v3.49.0 CS (static providers)
* fix "string_implicit_backslashes" in php files
* fix comments align
* fix test static providers
* fix stan
* disable "final_internal_class" rule
2024-02-06 08:28:19 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Michael Voříšek
54f4aa33f9
Fix CS - imports ( #9316 )
...
* fix Tests\Browser\TestCase imports
* fix remaining imports
* fix PHPUnit\Framework\TestCase imports
* import GuzzleHttp\Client
* fix remaining
* "php_unit_method_casing" is not todo
* fix "single_line_comment_spacing"
* fix 2nd commit done using older fixer
2024-01-21 19:13:31 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
8c82b29baf
Assert expected data types in tests ( #9268 )
...
* fix test skips for local testing
* fix Actions_Mail_Search tests when run /w non-UTC default TZ
* improve tests before PHP CS Fixer is run
* fix "php_unit_strict"
2023-12-17 15:03:08 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Aleksander Machniak
16ee6865ca
Fix cross-site scripting (XSS) vulnerability in handling of linkrefs in plain text messages
...
Thanks to Niraj Shivtarkar for the report.
2023-09-14 08:39:51 +02:00
Aleksander Machniak
a5fd211712
Improve/Fix wrapping of plain text messages on preview and reply ( #6974 , #8391 , #8378 , #8289 )
...
In short, we always wrap, but we detect patches/diffs in the text and make them unwrappable.
2022-01-09 16:29:09 +01:00
Aleksander Machniak
df7d8f1178
Improve auto-wrapping of plain text messages on preview and reply ( #6974 )
...
- fix auto-wrapping of some specific cases
- do not auto-wrap non-format=flowed content on preview
- do not auto-wrap content on reply
2021-10-15 10:44:02 +02:00
Aleksander Machniak
4b5e9c10f9
Fix handling of multiple link references with the same index in plain text message ( #8021 )
...
Second attempt that should work on all supported PHP versions
2021-04-25 10:57:17 +02:00
Aleksander Machniak
dc89e18a0f
Revert "Fix handling of multiple link references with the same index in plain text message ( #8021 )"
...
This reverts commit 2be7e1cb61
2021-04-25 09:15:05 +02:00
Aleksander Machniak
2be7e1cb61
Fix handling of multiple link references with the same index in plain text message ( #8021 )
2021-04-25 09:05:51 +02:00
Aleksander Machniak
39b3c0049e
Fix cross-site scripting (XSS) via HTML or Plain text messages with malicious content [CVE-2020-35730]
...
Credits to Alex Birnberg <birnbergalex@gmail.com >
2020-12-27 18:27:42 +01:00
Aleksander Machniak
f4ed1024dc
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-02 20:15:00 +01:00
Aleksander Machniak
47d9ed6d0c
Add support for PHPUnit 6 and 7 ( #6870 )
...
Fixes composer dependencies: Package phpunit/phpunit-mock-objects is abandoned
We cannot support v8 yet because of errors like:
Declaration of MailFunc::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void
It would require dropping PHP < 7.1 support.
2019-12-28 09:37:45 +01:00
dfukagaw28
89a4134064
Add support for DelSp=Yes messages ( #5702 )
2017-03-22 08:30:36 +01:00
Aleksander Machniak
afd090672c
Small performance optimization
2016-05-08 11:52:54 +02:00
Aleksander Machniak
c4ad7edd53
Fix font artifacts in text2html conversion ( #1490353 )
...
Use white-space:nowrap elements instead of unicode word-joiner character
2015-05-19 10:54:16 +02:00
Aleksander Machniak
d86ff98339
Fix font artifact in Google Chrome on Windows ( #1490353 )
2015-04-09 15:55:30 +02:00
Aleksander Machniak
59b765d839
Don't remove links when html signature is converted to text ( #1489621 )
...
Fix so when switching editor mode original version of signature is used (#1488849 )
2014-05-18 09:01:12 +02:00
Aleksander Machniak
c0a5aa5f5f
Improved handling of new-lines in quoted paragraphs on text2html conversion
2014-05-15 10:41:35 +02:00
Aleksander Machniak
f0992426d9
Bring back the old behaviour where text messages without format=flowed are auto-wrapped.
...
Make it the default in text2html class.
2014-05-13 19:40:00 +02:00
Aleksander Machniak
eda92ed4c0
Improved display of plain text messages and text to HTML conversion ( #1488937 )
...
Now instead of <pre> we use <div class="pre"> styled with monospace
font. We replace whitespace characters with non-breaking spaces where
needed. I.e. plain text is always unwrappable, until it uses format=flowed,
in such a case only flowed paragraphs are wrappable.
Also conversion of text to HTML in compose editor was modified in the same way.
2014-05-11 11:03:45 +02:00
