Aleksander Machniak
7b127faec5
Code improvements
2024-03-17 12:05:14 +01:00
Aleksander Machniak
97cdcf88b8
Fix some phpstan errors
2024-03-09 12:54:40 +01:00
Aleksander Machniak
a1f39f47b7
Fix phpstan errors
2024-02-10 19:20:04 +01:00
Aleksander Machniak
91816ca187
Fix phpstan errors
2024-02-10 09:23:12 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
c47accb867
Fix incorrect use of rcube_utils::explode()
2024-01-28 15:06:21 +01:00
Aleksander Machniak
34500a4fa4
Fix "missing return statement" phpstan errors
2024-01-27 19:07:52 +01:00
Michael Voříšek
ff2d721680
Fix more CS whitespace ( #9318 )
...
* fix "no_useless_else" manually
* fix some "blank_line_before_statement"
* two manual changes
* Revert "fix some "blank_line_before_statement""
This reverts commit 2cc857c00e
2024-01-25 19:17:29 +01:00
Aleksander Machniak
6dac0e1b65
Fix various PHPDoc issues
2024-01-25 14:51:09 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Aleksander Machniak
104a992e35
Fix PHP8 warnings ( #9242 )
2023-12-09 08:47:35 +01:00
Aleksander Machniak
04767b6b47
Fix bug where images attached to application/smil messages weren't displayed ( #8870 )
2023-10-21 18:15:00 +02:00
Christian Mollekopf
e495fc73b5
Enigma: WOAT Support ( #8626 )
...
* Enigma: WOAT Support
* Fixed public key extraction from dns record
Co-authored-by: Aleksander Machniak <alec@alec.pl >
Co-authored-by: Christian Mollekopf <mollekopf@apheleia-it.ch >
2022-08-01 11:51:32 +02:00
Aleksander Machniak
6303d3177e
Fix broken encoding of HTML content encapsulated in a RTF attachment ( #8444 )
2022-04-17 09:20:01 +02:00
Aleksander Machniak
f23aaed10e
Remove use of unreliable charset detection ( #8344 )
2022-04-09 14:13:50 +02:00
Aleksander Machniak
5208400bcd
Fix handling of message/rfc822 parts that are small and are multipart structures with a single part ( #8458 )
2022-03-08 19:53:09 +01:00
Aleksander Machniak
78b3049ce5
Fix PHPDoc
2022-02-18 19:19:07 +01:00
Arkadiusz Miśkiewicz
03e8c51c7f
Fix regression in showing attachments ( #8425 ). ( #8430 )
...
a5c2b4360c
2022-01-31 18:09:34 +01:00
Aleksander Machniak
e38d4e1eac
Fix setting HTML mode on reply/forward of a signed message ( #8405 )
...
Simplify and unify has_html_part() and has_text_part() methods.
2022-01-30 09:17:45 +01:00
Aleksander Machniak
f546d7216c
Fix setting HTML mode on reply/forward of a signed message ( #8405 )
2022-01-22 15:31:26 +01:00
Aleksander Machniak
ca5ba9550f
Fix bug where small message/rfc822 parts could not be decoded ( #8408 )
2022-01-22 09:43:01 +01:00
Aleksander Machniak
f429b26810
Fix various PHP8 warnings ( #8392 )
2022-01-11 19:04:24 +01:00
Aleksander Machniak
e2187b8f2d
Fix various PHP 8.1 warnings
2021-08-27 16:52:54 +02:00
Aleksander Machniak
25214753cb
Support displaying RTF content (including encapsulated HTML) from a TNEF attachment
2021-07-11 09:31:09 +02:00
Aleksander Machniak
7da8437a25
Fix PHP8 warnings
2021-07-03 08:16:03 +02:00
Aleksander Machniak
67bb509f2d
Fix displaying HTML body with inline images encapsulated using TNEF format (winmail.dat)
2021-07-01 14:28:37 +02:00
Aleksander Machniak
044398ca82
Add an option to disable TNEF decoding
2021-06-24 11:42:31 +02:00
Josh Soref
203f456620
Spelling ( #8001 )
2021-04-18 08:43:18 +02:00
Aleksander Machniak
352a31ec07
Fix errors/warnings when fetching replied/forwarded message headers fails ( #7970 )
2021-04-04 10:15:02 +02:00
johndoh
cfd4fa170f
Fix a few PHP notices ( #7791 )
2020-12-19 19:36:58 +01:00
Aleksander Machniak
17ae3693c3
PHP8 fixes + fix fatal error when refreshing compose page in forward-as-attachment state
2020-12-18 19:27:25 +01:00
Aleksander Machniak
3bbb01fe13
PHP8 fixes, regression fixes
2020-12-13 12:14:15 +01:00
Aleksander Machniak
8eb382b4ca
PHP8 fixes
2020-12-11 20:29:41 +01:00
Aleksander Machniak
f4ed1024dc
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-02 20:15:00 +01:00
Aleksander Machniak
66ca4f0f72
CS fixes, PHP8 fixes, short array syntax, tests
2020-11-30 14:03:11 +01:00
Aleksander Machniak
ad05e97254
Fix parsing small eml attachments ( #7671 )
2020-11-01 11:26:48 +01:00
Aleksander Machniak
7d3d806411
Fix PHP Fatal error: Cannot access protected property rcube_message::$body ( #7588 )
2020-09-05 08:46:01 +02:00
Aleksander Machniak
5264534c46
Fix bug where some parts of a message could have been missing in a reply/forward body ( #7568 )
2020-08-30 10:56:13 +02:00
Aleksander Machniak
e476211230
Fix error when dealing with message/rfc822 attachments using Gmail IMAP ( #6854 )
2020-08-23 10:18:10 +02:00
Aleksander Machniak
a5c2b4360c
Fixes in context of undefined variables, and code style
2020-08-15 12:13:31 +02:00
Aleksander Machniak
d340f18295
Fix display issues with mail subject that contains line-breaks ( #7191 )
2020-01-25 08:44:46 +01:00
Aleksander Machniak
1376b5a647
Fix bug where message parts with no Content-Disposition header and no name were not listed on attachments list ( #7117 )
2020-01-18 18:31:06 +01:00
Aleksander Machniak
66fab8cdb2
CS fixes, Avoid usused variables, fixed minor bugs
2019-10-05 19:44:39 +02:00
Aleksander Machniak
e7ebff56df
PHPDoc fixes
2019-09-30 20:43:07 +02:00
