Aleksander Machniak
3a76c9b3b6
Code improvements
2024-03-23 18:28:22 +01:00
Aleksander Machniak
b978a55060
Fix fatal error when http_client option is undefined ( #9358 )
2024-02-25 10:05:23 +01:00
Aleksander Machniak
a1f39f47b7
Fix phpstan errors
2024-02-10 19:20:04 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
9e5c019936
Fix some phpstan errors
2024-01-28 14:44:28 +01:00
Aleksander Machniak
21dc4f2667
Small code improvements
2024-01-26 15:57:53 +01:00
Michael Voříšek
ff2d721680
Fix more CS whitespace ( #9318 )
...
* fix "no_useless_else" manually
* fix some "blank_line_before_statement"
* two manual changes
* Revert "fix some "blank_line_before_statement""
This reverts commit 2cc857c00e
2024-01-25 19:17:29 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
54f4aa33f9
Fix CS - imports ( #9316 )
...
* fix Tests\Browser\TestCase imports
* fix remaining imports
* fix PHPUnit\Framework\TestCase imports
* import GuzzleHttp\Client
* fix remaining
* "php_unit_method_casing" is not todo
* fix "single_line_comment_spacing"
* fix 2nd commit done using older fixer
2024-01-21 19:13:31 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Edouard Vanbelle
c5a84f7d73
fix: correct language_prop() to support language like es_419 from user agent ( #9292 )
2023-12-29 18:48:50 +01:00
Edouard Vanbelle
0e4c35797d
core: correct coding style warning ( #9284 )
...
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr >
2023-12-26 09:04:54 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Aleksander Machniak
a689d4cda0
Fix potential "undefined index" warning
2023-12-19 10:44:47 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
93946f4ca7
Fix "self_accessor" PHP CS Fixer rule ( #9269 )
2023-12-17 09:44:43 +01:00
Michael Voříšek
1aef271290
Fix class/method names case typos ( #9261 )
...
* fix Mail_Mime case
* fix StdErrMock case
* fix method calls case
2023-12-16 15:39:59 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
a2b5bb8f05
Fix rcube::decrypt() ( #9264 )
...
* do not skip test_encrypt_and_decrypt test
* Fix rcube::decrypt()
2023-12-13 08:27:39 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
9f044f004c
Don't log anything if per_user_logging=true and user is not authenticated yet
2023-11-27 13:12:01 +01:00
Aleksander Machniak
efad759e80
Fix PHP8 warning
2023-08-03 11:54:04 +02:00
Aleksander Machniak
94c78b350e
Fix so install/update scripts do not require PEAR ( #9037 )
2023-07-15 18:43:00 +02:00
Aleksander Machniak
a20445fcc5
Fix potential HTTP protocol version mismatch ( #8982 )
2023-05-07 16:37:17 +02:00
Aleksander Machniak
ff96e7724a
Set timeout=30, connect_timeout=5, read_timeout=120 as defaults for HTTP client ( #8865 )
2023-04-10 09:46:54 +02:00
Aleksander Machniak
32ddb7b8d1
Use precise session lifetime for garbage collector ( #8671 )
2022-10-09 17:13:41 +02:00
Aleksander Machniak
80404a8674
Store uploads metadata in a separate sql database table instead of a session ( #8415 )
2022-10-09 11:35:14 +02:00
Stuart Henderson
ba5ea75f46
Don't return undefined $_SESSION['secure_token'] ( #8705 )
...
Avoid `PHP Warning: Undefined array key "secure_token" in /roundcubemail/program/lib/Roundcube/rcube.php on line 1002` seen with PHP 8 and secure_urls enabled.
2022-09-24 09:10:18 +02:00
Aleksander Machniak
bae45d5728
Always define 'abort' arg in rcube_dummy_plugin_api handler ( #8669 )
2022-08-13 08:58:52 +02:00
Aleksander Machniak
aac9b696b8
Fix various PHP 8.2 warnings
2022-08-06 09:22:12 +02:00
Aleksander Machniak
68be98817f
Fix so "Found unconstructed Spoofchecker" error is not fatal ( #8537 )
2022-07-10 08:52:42 +02:00
Aleksander Machniak
e247209280
Fix various PHP 8.1 warnings ( #8584 )
2022-06-25 08:33:03 +02:00
Aleksander Machniak
fa65a68389
Use ... oprator instead of func_get_args() for variadic functions
2022-04-27 19:21:00 +02:00
Aleksander Machniak
ac9b91f4c7
Strip HTML tags in URL logged with an error
2022-01-23 09:43:01 +01:00
Aleksander Machniak
f429b26810
Fix various PHP8 warnings ( #8392 )
2022-01-11 19:04:24 +01:00
Aleksander Machniak
b987892524
Fix openssl_encrypt() warning on PHP 7.3
2021-10-29 16:14:32 +02:00
Aleksander Machniak
318d6d0859
Simplify code according to the minimum PHP version supported
2021-10-05 19:29:57 +02:00
Aleksander Machniak
6ed101f5e1
Add support for encryption with AEAD ciphers, e.g. aes-256-gcm ( #7097 )
2021-10-04 19:22:34 +02:00
Aleksander Machniak
f2688ba492
Use ?? operator where applicable
2021-09-21 19:12:06 +02:00
johndoh
693252edfe
Remove redudant php version checks ( #8154 )
2021-08-01 17:39:12 +02:00
Aleksander Machniak
0d4a395464
Fix PHP 8.1 deprecation warnings
2021-07-31 07:53:14 +02:00
Aleksander Machniak
ed17ce58b1
Remove (incorrect) use of Return-Receipt-To header ( #8069 )
2021-05-22 09:13:42 +02:00
Josh Soref
203f456620
Spelling ( #8001 )
2021-04-18 08:43:18 +02:00
Michael Stilkerich
2e88de27db
Fix phpdoc for rcube::decrypt() ( #7956 )
...
* Fix phpdoc for rcube::decrypt()
* Adapt rcube::decrypt() to return false on error
2021-03-21 14:46:14 +01:00
Aleksander Machniak
9508059b90
Plugin API: Allow modification of 'error' argument in 'message_send_error' hook ( #7914 )
2021-03-13 08:54:30 +01:00
Aleksander Machniak
5ac44fd4ed
PHPDoc fixes
2021-02-28 11:58:27 +01:00
Aleksander Machniak
277e66b2ac
Fix undefined index warning
2021-02-15 11:34:14 +01:00
