Commit Graph

1983 Commits

Author SHA1 Message Date
Aleksander Machniak
4ea35f44ff CS fixes 2024-03-16 14:26:59 +01:00
Aleksander Machniak
92f6b279c5 Code style improvements 2024-03-16 13:16:58 +01:00
Philip Weir
b3e5efa870 Add set-unread-count JS event on unread message count change (#9344) 2024-02-11 18:04:17 +01:00
Michael Voříšek
332c165d28 Fix some basic JS CS (#9328)
* fix "nonblock-statement-body-position" (fixed already)

* fix "comma-dangle"

* fix "no-regex-spaces"

* fix "new-parens"

* fix "object-curly-newline"

* fix "object-property-newline"

* fix "spaced-comment" semimanually

* fix "no-constant-condition" manually

* fix "unicorn/no-hex-escape"

* fix "unicorn/escape-case"

* fix "quote-props"

* fix "no-whitespace-before-property" - fix bug/typo

* fix "unicorn/empty-brace-spaces"

* fix "keyword-spacing"

* fix "dot-notation"

* fix "no-return-assign" manually

* fix "padding-line-between-statements"

* fix "key-spacing"

* fix "no-else-return" semimanually

* fix some "no-undef"

* fix case cs

* Revert "fix "padding-line-between-statements""

* improve switch/case format I.

* improve switch/case format II.

regex: (^ *(break|return).*)\n *(\n)

* fix safe "eqeqeq"

* fix "radix"

* fix v3.49.0 CS (static providers)

* fix "string_implicit_backslashes" in php files

* fix comments align

* fix test static providers

* fix stan

* disable "final_internal_class" rule
2024-02-06 08:28:19 +01:00
Michael Voříšek
ecd2796622 Fix JS whitespace CS (#9327)
* fix "no-extra-semi"

* fix "object-curly-spacing"

* fix "block-spacing"

* fix "padded-blocks"

* fix "space-before-blocks"

* fix "space-before-function-paren"

* fix "operator-linebreak"

* fix "space-unary-ops"

* fix "space-infix-ops"

* fix most "brace-style"

* fix "curly"

* fix most "brace-style" II

* fix "no-multi-spaces"

* search regex: (?<=\n)( +)(?! ).*\n(?!\1)( +)(&&|\|\||\()

* search regex: (?<=\n)( +)(?! |\*/).*(?<!;)\n(?!\1)( +)(?! |\}|\]|\)|\.)

* fix mostly "brace-style" /w allowSingleLine: false

* fix cs

* search regex: (//|/\*).*\n\s+\{
2024-01-30 07:50:02 +01:00
Aleksander Machniak
6c45fa40d7 Add missing comma 2024-01-28 10:38:48 +01:00
Aleksander Machniak
7f459502ab Fix bug in collapsing/expanding folders with some special characters in names (#9324) 2024-01-28 10:35:21 +01:00
Michael Voříšek
2643be3eaa Fix single quotes CS (#9283)
* Fix "single_quote"

* fix "escape_implicit_backslashes"

* fix typo from f363481c

* fix single quotes in JS

* fix some minor JS CS

* fix CS v3.45.0
2023-12-31 16:36:55 +01:00
Michael Voříšek
740267fac0 Lint JS files using eslint and normalize JS indentation (#9280)
* Lint JS using eslint

* Fix "comma-spacing"

* Fix "semi"

* Fix indent to unified 4 spaces as for PHP

* ignore symlinked public_html/* files
2023-12-23 17:08:32 +01:00
Michael Voříšek
28c778b7a0 Modernize more CS III (#9270)
* fix "single_trait_insert_per_statement"

* fix "empty_loop_condition"

* fix "backtick_to_shell_exec"

* fix "phpdoc_to_comment"

* fix "no_empty_statement"

* fix "heredoc_to_nowdoc"

* fix "class_reference_name_casing"

* fix "align_multiline_comment"

* fix "heredoc_indentation"

* fix "constant_case"

* fix "single_line_comment_style"

* fix "no_null_property_initialization"

* fix "standardize_increment"

* fix "no_unneeded_control_parentheses"

* fix missing NL after "<?php"

* fix php in *.sh files too

* fix trailing spaces from all text files

* fix "explicit_indirect_variable"

* Revert "fix "align_multiline_comment""

This reverts commit 42e584f8e3.

* fix "align_multiline_comment" properly

* Revert "fix trailing spaces from all text files" - diff files only

* Revert "Revert "fix trailing spaces from all text files" - diff files only"

This reverts commit 2101c2a3a3.

* rm useless "setup-php" config
2023-12-18 07:46:51 +01:00
Pablo Zmdl
f59738b133 Initialize Mailvelope earlier (#9243)
This helps fresh users to have a site-specific keyring directly after
the first login (see below). And it hurts no one else because the heavy
Mailvelope lifting works with Promises, which don't block the main code
flow.

If Mailvelope's main keyring is not to be used (configurable in
Roundcubemail's settings), users with a fresh setup previously had only
Mailvelope's main keyring after a login to Roundcubemail. Only after
opening an encrypted message, or going to the compose page, they got a
site-specific keyring. This lead to some users being confused where the
keys went they created after logging in.
2023-12-10 12:32:16 +01:00
Aleksander Machniak
b19689e4f1 Update to TinyMCE 5.10.9 security release (#9228) 2023-11-28 20:25:52 +01:00
Aleksander Machniak
2bfd4f1ef5 Fix page jump menu flickering on click (#9196) 2023-11-26 11:27:33 +01:00
Philip Weir
89ce052242 Unify HTML editor font settings (#9177) 2023-11-25 14:23:17 +01:00
vladimirdulov
e7360d87b1 Make mail search scope configurable (#9077, #7556)
Co-authored-by: Vladimir D <vladimir@brandlight.org>
2023-10-08 10:24:28 +02:00
Aleksander Machniak
1aaf86f139 Fix one more regression regarding mail delete 2023-06-27 13:37:30 +02:00
Aleksander Machniak
d766cb56cd Fix one more regression regarding mail delete 2023-06-27 12:06:08 +02:00
Aleksander Machniak
02682a5351 Fix Delete button regression (#7141) 2023-06-26 18:52:38 +02:00
Aleksander Machniak
b8c83aa204 Use no-referrer policy for images pasted into HTML editor 2023-06-25 13:40:06 +02:00
Aleksander Machniak
d3bcfba010 Convert images in HTML content pasted into HTML editor to data: URIs (and later to attachments) (#6938) 2023-06-25 10:07:00 +02:00
Aleksander Machniak
9427ec1d35 Mouse-over menu on messages list (#7141) 2023-06-23 21:04:17 +02:00
Aleksander Machniak
5723849978 Remove 'alt' attribute for contact photo images
Loading a contact photo may take a while, displaying the alt text looks ugly
and is redundant.
2023-06-04 10:29:14 +02:00
Aleksander Machniak
1b138d4f4d Fix so recipients with a domain ending with .s are allowed (#8854) 2023-04-10 10:09:56 +02:00
Aleksander Machniak
ef9d345441 Drop dependency on JsTimeZoneDetect (#8965) 2023-04-09 16:06:00 +02:00
Aleksander Machniak
1250a420ae Fix bug where it wasn't possible to scroll lists by clicking middle mouse button (#8942) 2023-03-19 11:11:00 +01:00
Aleksander Machniak
642b772087 Fix Help plugin menu (#8898) 2023-02-19 14:52:44 +01:00
Aleksander Machniak
e237054490 Fix bug where a non-ASCII character in app.js could cause error in javascript engine (#8894) 2023-01-28 18:33:18 +01:00
Aleksander Machniak
a2c0f79efb Fix return to previous contact source/group after search reset 2022-11-11 11:25:48 +01:00
Aleksander Machniak
6c2da12218 Fix bug where some dialogs in an eml attachment preview would not close on mobile (#8627) 2022-08-28 13:26:02 +02:00
Aleksander Machniak
1a3a253a77 Remove redundant gettext() calls 2022-08-28 11:43:48 +02:00
Aleksander Machniak
45b184e337 Fix bug where the attachment menu wouldn't disappear after an action is selected (#8691) 2022-08-27 17:01:18 +02:00
Aleksander Machniak
3b16cbf371 Fix bug where "about:blank" page could trigger "load error" (#8554)
Use javascript:false; instead
2022-08-15 09:58:56 +02:00
Aleksander Machniak
907448df76 Fix TinyMCE configuration for handling styles of pasted content in webkit browsers (#8555) 2022-06-18 19:04:12 +02:00
Aleksander Machniak
ca264770fd Fix possible js error (#8543) 2022-05-29 10:28:48 +02:00
Aleksander Machniak
ff96c78606 Use navigator.pdfViewerEnabled for PDF viewer detection
Drop ActiveXObject based detection code
2022-04-08 08:28:13 +02:00
Aleksander Machniak
5626e26c58 Fix slow loading of long HTML content into the HTML editor (#8108) 2022-04-03 12:30:16 +02:00
Aleksander Machniak
2dbb5165da Fix bug where attachment download could sometimes fail with a CSRF check error (#8283) 2021-11-03 19:31:00 +01:00
Aleksander Machniak
a14098ac81 Fix bug where adding a contact to trusted senders via "Always allow from..." button didn't work (#8264, #8268)
...if the contact already existed in Personal addresses (or another default contacts source)
2021-10-28 14:39:34 +02:00
Aleksander Machniak
4402605be9 Fix bug where \u200b characters were added into the recipient input preventing mail delivery (#8269) 2021-10-28 13:01:05 +02:00
Aleksander Machniak
d1f16ebb97 Fix so dark mode state is retained after closing the browser (#8237) 2021-10-22 18:30:58 +02:00
Aleksander Machniak
8a5d9a1984 Add ability to mark multiple messages as not deleted at once (#5133)
The option is visible when flag_for_deletion=true and skip_deleted=false.
2021-09-18 10:40:06 +02:00
Aleksander Machniak
cb37d14c5c Support responses (snippets) in HTML format (#5315) 2021-08-28 19:17:19 +02:00
Aleksander Machniak
535f5b6fe2 Elastic: Fix unwanted scrollbars in QR-Code dialog
The usual dialog padding is 28px in Elastic
2021-08-04 11:55:09 +02:00
Aleksander Machniak
41f69f3d5f Simplify the code by making env.attachments always initialized 2021-07-19 12:40:59 +02:00
Aleksander Machniak
4903ef616f - Fix bug where expanding a group in the recipient input could corrupt the input content (#7569) 2021-07-18 11:08:41 +02:00
Aleksander Machniak
13cc4f43fd Fix contacts list title for groups from example_addressbook 2021-07-16 13:05:56 +02:00
Aleksander Machniak
e01ec25aac Use setTimeout() without window. prefix consistently 2021-07-14 13:18:58 +02:00
johndoh
7aa4b94461 Fix Firefox infinate loading display on mail screen #8128 (#8129) 2021-07-14 13:05:58 +02:00
johndoh
5cc4021670 Fix handling of group names with @ character in autocomplete and contacts widget #8098 (#8101) 2021-07-14 12:51:41 +02:00
Aleksander Machniak
2f643141b4 Fix size of Mailvelope iframe for PGP-inlined mail, again (#8126) 2021-07-11 09:42:13 +02:00