Commit Graph

2068 Commits

Author SHA1 Message Date
Aleksander Machniak
7da322371f Fix command injection via crafted im_convert_path/im_identify_path on Windows
Reported by Huy Nguyễn Phạm Nhật.
2024-05-19 10:10:32 +02:00
Aleksander Machniak
cfd108399e Simplify use of rcube::raise_error() 2024-05-17 15:43:17 +02:00
Aleksander Machniak
6c54254a2f Fix folders hierarchy when special folders are subfolders of INBOX, with no personal namespace prefix (#9452) 2024-05-16 16:22:57 +02:00
Aleksander Machniak
6342206239 Fix PHP8 warning (#9429) 2024-04-29 11:10:32 +02:00
Edouard Vanbelle
f71ae0298a oauth: select auth scheme (XOAUTH2 vs OAUTHBEARER) (#9289) 2024-04-21 11:52:05 +02:00
Michael Voříšek
a30e0ad438 Infer file/line location in rcube::raise_error() from backtrace (#9422)
* \n\s+'file' => __FILE__,

* \n\s+'line' => __LINE__,

* 'line' => __LINE__, 'file' => __FILE__,

* 'file' => __FILE__, 'line' => __LINE__,

* rest

* more

* improve cs

* more cs

* revert rcube_utils::preg_error changes

* impl file/line from backtrace

* Revert "revert rcube_utils::preg_error changes"
2024-04-21 11:48:35 +02:00
Aleksander Machniak
ff59ade31a Get rid of phpstan/phpstan-strict-rules 2024-04-21 11:33:51 +02:00
Aleksander Machniak
15659d7815 PHPCS: phpdoc_annotation_without_dot=true (default) 2024-04-14 10:32:35 +02:00
Michael Voříšek
1e360999b2 Use composer autoloader for bundled plugins testing (#9412)
* use fixed "roundcube/plugin-installer"

* Use composer autoloader for plugins testing

* cherrypick remaining from 9241 related with testing

* minor legacy autoload improvements
2024-04-11 18:28:46 +02:00
Aleksander Machniak
e086c2c97c Code improvements 2024-04-07 09:20:52 +02:00
Aleksander Machniak
a13f61cc7f Free enchant dictionary resources
Fixes errors in tests
2024-04-05 18:22:12 +02:00
Michael Voříšek
bdd5de55b5 Rename composer.json.dist to composer.json (#9279)
* Rename composer.json.dist to composer.json
* fix update
2024-04-03 18:06:01 +02:00
Aleksander Machniak
4959abe07b Fix regression, cleanup 2024-04-01 13:41:31 +02:00
Aleksander Machniak
5c603344fe Code improvements 2024-04-01 11:50:56 +02:00
Aleksander Machniak
20d9edce04 Code improvements 2024-03-31 19:22:56 +02:00
Aleksander Machniak
8adb052d35 Code improvements, PHPDoc fixes 2024-03-30 14:17:34 +01:00
Aleksander Machniak
58d28297a3 Code improvements, PHPDoc fixes 2024-03-29 16:18:20 +01:00
Aleksander Machniak
337e906650 Plugin API: Fix action handlers after registering also a task 2024-03-29 11:25:41 +01:00
Aleksander Machniak
8133acba68 Code improvements (and fixes to recent commits) 2024-03-24 12:06:39 +01:00
Aleksander Machniak
2f5f3bd0de Code improvements 2024-03-24 10:29:31 +01:00
Aleksander Machniak
15c1228cf3 Code improvements 2024-03-24 08:52:17 +01:00
Philip Weir
ed47e11319 csv2vard: store labels by key not value (#9394) 2024-03-24 08:00:38 +01:00
Aleksander Machniak
818945a8a2 Code improvements 2024-03-23 18:50:34 +01:00
Aleksander Machniak
3a76c9b3b6 Code improvements 2024-03-23 18:28:22 +01:00
Aleksander Machniak
7713b7c1bd Enigma: Code improvements 2024-03-21 14:52:51 +01:00
Aleksander Machniak
7b127faec5 Code improvements 2024-03-17 12:05:14 +01:00
Aleksander Machniak
3b159a1c25 Code improvements in the spellchecker classes 2024-03-17 10:19:25 +01:00
Aleksander Machniak
4e7d5c601e Code improvements 2024-03-17 08:47:00 +01:00
Aleksander Machniak
5ed3b29a0a Code improvements 2024-03-16 21:30:10 +01:00
Aleksander Machniak
02e49ed236 Fix phpstan errors 2024-03-10 18:37:52 +01:00
Aleksander Machniak
97cdcf88b8 Fix some phpstan errors 2024-03-09 12:54:40 +01:00
Aleksander Machniak
3dbbbd4ce1 Fix attachment name decoding when 'charset' parameter exists in the headers (#9376) 2024-03-09 11:58:33 +01:00
Aleksander Machniak
0afb437219 Fix PHP8 warnings (#9363) 2024-02-25 10:22:39 +01:00
Aleksander Machniak
567681c3a3 Remove redundant code 2024-02-25 10:13:37 +01:00
Aleksander Machniak
b978a55060 Fix fatal error when http_client option is undefined (#9358) 2024-02-25 10:05:23 +01:00
Aleksander Machniak
1c706cc987 Fix CS/phpstan error 2024-02-10 20:51:38 +01:00
Aleksander Machniak
a1f39f47b7 Fix phpstan errors 2024-02-10 19:20:04 +01:00
Aleksander Machniak
91816ca187 Fix phpstan errors 2024-02-10 09:23:12 +01:00
Aleksander Machniak
966274d835 Fix phpstan errors 2024-02-09 21:11:50 +01:00
Michael Voříšek
332c165d28 Fix some basic JS CS (#9328)
* fix "nonblock-statement-body-position" (fixed already)

* fix "comma-dangle"

* fix "no-regex-spaces"

* fix "new-parens"

* fix "object-curly-newline"

* fix "object-property-newline"

* fix "spaced-comment" semimanually

* fix "no-constant-condition" manually

* fix "unicorn/no-hex-escape"

* fix "unicorn/escape-case"

* fix "quote-props"

* fix "no-whitespace-before-property" - fix bug/typo

* fix "unicorn/empty-brace-spaces"

* fix "keyword-spacing"

* fix "dot-notation"

* fix "no-return-assign" manually

* fix "padding-line-between-statements"

* fix "key-spacing"

* fix "no-else-return" semimanually

* fix some "no-undef"

* fix case cs

* Revert "fix "padding-line-between-statements""

* improve switch/case format I.

* improve switch/case format II.

regex: (^ *(break|return).*)\n *(\n)

* fix safe "eqeqeq"

* fix "radix"

* fix v3.49.0 CS (static providers)

* fix "string_implicit_backslashes" in php files

* fix comments align

* fix test static providers

* fix stan

* disable "final_internal_class" rule
2024-02-06 08:28:19 +01:00
Michael Voříšek
d18406a8bd Fix binary operator spaces CS (#9330)
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
372c8bd0cd Small PHPDoc fix 2024-01-30 13:19:38 +01:00
Aleksander Machniak
845db4cc34 Fix various phpstan issues 2024-01-28 19:08:01 +01:00
Aleksander Machniak
c47accb867 Fix incorrect use of rcube_utils::explode() 2024-01-28 15:06:21 +01:00
Aleksander Machniak
9e5c019936 Fix some phpstan errors 2024-01-28 14:44:28 +01:00
Aleksander Machniak
34500a4fa4 Fix "missing return statement" phpstan errors 2024-01-27 19:07:52 +01:00
Aleksander Machniak
dfb88b50c1 Fix bug where HTML entities in URLs were not decoded on HTML to plain text conversion (#9312) 2024-01-27 14:52:46 +01:00
Aleksander Machniak
c47484cf3d Small improvement to rcube_user::get_identity() 2024-01-26 19:20:37 +01:00
Aleksander Machniak
21dc4f2667 Small code improvements 2024-01-26 15:57:53 +01:00
Michael Voříšek
ff2d721680 Fix more CS whitespace (#9318)
* fix "no_useless_else" manually

* fix some "blank_line_before_statement"

* two manual changes

* Revert "fix some "blank_line_before_statement""

This reverts commit 2cc857c00e.

* fix some "blank_line_before_statement" using patched fixer (after "}" only)

* fix continue/break too
2024-01-25 19:17:29 +01:00