Aleksander Machniak
8b11a9843e
Cleanup raise_error() use in password drivers
2024-05-16 19:29:08 +02:00
Aleksander Machniak
2aa7098224
Wording improvement
...
[skip ci]
2024-05-16 16:36:20 +02:00
Aleksander Machniak
58d2b2f1ee
Doc cleanup [skip ci]
2024-04-21 20:55:43 +02:00
Aleksander Machniak
3d31036aad
Password: Use Guzzle HTTP Client in the cpanel driver
2024-04-21 20:19:09 +02:00
Aleksander Machniak
ad25c6f7ce
Password: Use Guzzle HTTP Client in the domainfactory driver
2024-04-21 16:58:53 +02:00
Aleksander Machniak
543dde3c04
Password: Use Guzzle HTTP Client in the modoboa driver
2024-04-21 15:26:37 +02:00
Aleksander Machniak
8b024bffd3
Password: Use Guzzle HTTP Client in the plesk driver
2024-04-21 15:06:39 +02:00
Aleksander Machniak
24435fed26
Password: Use Guzzle HTTP Client in 'directadmin' driver
2024-04-21 12:56:55 +02:00
Michael Voříšek
a30e0ad438
Infer file/line location in rcube::raise_error() from backtrace ( #9422 )
...
* \n\s+'file' => __FILE__,
* \n\s+'line' => __LINE__,
* 'line' => __LINE__, 'file' => __FILE__,
* 'file' => __FILE__, 'line' => __LINE__,
* rest
* more
* improve cs
* more cs
* revert rcube_utils::preg_error changes
* impl file/line from backtrace
* Revert "revert rcube_utils::preg_error changes"
2024-04-21 11:48:35 +02:00
Aleksander Machniak
ff59ade31a
Get rid of phpstan/phpstan-strict-rules
2024-04-21 11:33:51 +02:00
Aleksander Machniak
7839820d25
Password: Check that a user email is part of password in zxcvbn checker ( #9404 )
2024-04-14 11:07:08 +02:00
Aleksander Machniak
15659d7815
PHPCS: phpdoc_annotation_without_dot=true (default)
2024-04-14 10:32:35 +02:00
Michael Voříšek
1e360999b2
Use composer autoloader for bundled plugins testing ( #9412 )
...
* use fixed "roundcube/plugin-installer"
* Use composer autoloader for plugins testing
* cherrypick remaining from 9241 related with testing
* minor legacy autoload improvements
2024-04-11 18:28:46 +02:00
Michael Voříšek
52d8172b0f
Allow composer autoloading (to coexist) ( #9407 )
...
* Replace custom loader in favor of composer native
* Load plugins using composer
* finish debug_logger plugin
* finish markasjunk plugin
* finish password plugin
* finish enigma plugin
* finish managesieve plugin
* fix ExtensionInstaller run on first install
* fix phpstan "Implicit array creation" in plugin config files
* simplify composer.json
* keep non-composer autoloading relying on include_path set in plugins
* update minimal "roundcube/plugin-installer" version
* "plugins.roundcube.net" root-only package repo is not needed
* REVERT ALL
* fix phpstan "Implicit array creation" in plugin config files
* update minimal "roundcube/plugin-installer" version
* reland composer.json changes
* fix ExtensionInstaller run on first install
* Roundcube (non plugin) tests are fine to rely on composer autoload
* fix CS of master
* not needed until strict composer autoloading
* improve comment
* revert rcmail_oauth change - fixed in plugin installer
* require fixed plugin installer
2024-04-10 12:27:43 +02:00
Aleksander Machniak
d9d51b8d9c
CS fix
2024-04-07 12:09:22 +02:00
Michael Voříšek
b5a3fd646b
Fix "Implicit array creation" in plugin config files ( #9406 )
...
* fix phpstan "Implicit array creation" in plugin config files
* update minimal "roundcube/plugin-installer" version
2024-04-07 12:00:03 +02:00
Aleksander Machniak
2334876063
Password: Use Guzzle HTTP Client in 'pwned' driver
2024-04-07 11:59:13 +02:00
Aleksander Machniak
e1925c47a4
Code improvements
2024-04-07 11:27:01 +02:00
Michael Voříšek
736795326c
Fix plugins composer.json format ( #9405 )
...
* Check plugins composer.json using CI
* Add "require-dev" and "config.allow-plugins" to plugins
* fix composer.json format - rm invalid email
* fix composer.json format - fix ext require
* fix composer.json format - fix plugin name
* tmp
* Revert "tmp"
* fix ext in ext install
* disable plugin in plugin install until Roundcube is fully autoloadable
* fix composer.json format - fix non-canonical license name
* Revert "Add "require-dev" and "config.allow-plugins" to plugins"
* no composer install for plugins needed
* Revert "fix ext in ext install"
* add standard "Test" suffix to phpunit files
* rm unneeded "suffix" in phpunit config
* simplify phpunit config
* fix default "xhtml" doctype in unit testing
* fix test_format_date test to not rely on other tests
* even more phpunit config simplify
* stricter/unify phpunit params for E2E tests
* run E2E tests on maximal php version too with lowest deps
* "repositories" in bundled plugins are useless as for root package only
* add/unify missing plugin test
2024-04-05 17:55:46 +02:00
Michael Voříšek
bdd5de55b5
Rename composer.json.dist to composer.json ( #9279 )
...
* Rename composer.json.dist to composer.json
* fix update
2024-04-03 18:06:01 +02:00
Aleksander Machniak
4959abe07b
Fix regression, cleanup
2024-04-01 13:41:31 +02:00
Aleksander Machniak
20d9edce04
Code improvements
2024-03-31 19:22:56 +02:00
Aleksander Machniak
58d28297a3
Code improvements, PHPDoc fixes
2024-03-29 16:18:20 +01:00
Aleksander Machniak
49a40ea126
Code improvements
2024-03-23 13:48:51 +01:00
Aleksander Machniak
b1596b76b6
CS fixes
2024-03-21 15:21:47 +01:00
Aleksander Machniak
7713b7c1bd
Enigma: Code improvements
2024-03-21 14:52:51 +01:00
Aleksander Machniak
f9186b303e
CS fix
2024-03-17 12:29:24 +01:00
Aleksander Machniak
7b127faec5
Code improvements
2024-03-17 12:05:14 +01:00
Aleksander Machniak
02e49ed236
Fix phpstan errors
2024-03-10 18:37:52 +01:00
Aleksander Machniak
0bf292c939
Update changelog, CS fixes
2024-02-11 16:21:30 +01:00
Aleksander Machniak
1ce4492e60
Merge branch 'master' of https://github.com/Popyllol/roundcubemail into Popyllol-master
2024-02-11 15:36:25 +01:00
Aleksander Machniak
a1f39f47b7
Fix phpstan errors
2024-02-10 19:20:04 +01:00
Aleksander Machniak
966274d835
Fix phpstan errors
2024-02-09 21:11:50 +01:00
Aleksander Machniak
bb630b367d
Fix flaky test
2024-02-09 19:59:54 +01:00
Michael Voříšek
332c165d28
Fix some basic JS CS ( #9328 )
...
* fix "nonblock-statement-body-position" (fixed already)
* fix "comma-dangle"
* fix "no-regex-spaces"
* fix "new-parens"
* fix "object-curly-newline"
* fix "object-property-newline"
* fix "spaced-comment" semimanually
* fix "no-constant-condition" manually
* fix "unicorn/no-hex-escape"
* fix "unicorn/escape-case"
* fix "quote-props"
* fix "no-whitespace-before-property" - fix bug/typo
* fix "unicorn/empty-brace-spaces"
* fix "keyword-spacing"
* fix "dot-notation"
* fix "no-return-assign" manually
* fix "padding-line-between-statements"
* fix "key-spacing"
* fix "no-else-return" semimanually
* fix some "no-undef"
* fix case cs
* Revert "fix "padding-line-between-statements""
* improve switch/case format I.
* improve switch/case format II.
regex: (^ *(break|return).*)\n *(\n)
* fix safe "eqeqeq"
* fix "radix"
* fix v3.49.0 CS (static providers)
* fix "string_implicit_backslashes" in php files
* fix comments align
* fix test static providers
* fix stan
* disable "final_internal_class" rule
2024-02-06 08:28:19 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Michael Voříšek
ecd2796622
Fix JS whitespace CS ( #9327 )
...
* fix "no-extra-semi"
* fix "object-curly-spacing"
* fix "block-spacing"
* fix "padded-blocks"
* fix "space-before-blocks"
* fix "space-before-function-paren"
* fix "operator-linebreak"
* fix "space-unary-ops"
* fix "space-infix-ops"
* fix most "brace-style"
* fix "curly"
* fix most "brace-style" II
* fix "no-multi-spaces"
* search regex: (?<=\n)( +)(?! ).*\n(?!\1)( +)(&&|\|\||\()
* search regex: (?<=\n)( +)(?! |\*/).*(?<!;)\n(?!\1)( +)(?! |\}|\]|\)|\.)
* fix mostly "brace-style" /w allowSingleLine: false
* fix cs
* search regex: (//|/\*).*\n\s+\{
2024-01-30 07:50:02 +01:00
Aleksander Machniak
845db4cc34
Fix various phpstan issues
2024-01-28 19:08:01 +01:00
Aleksander Machniak
d363a6a7b7
PHPDoc fixes
2024-01-28 14:16:42 +01:00
Aleksander Machniak
1f6a9b8843
Fix phpstan errors regarding rcube_uploads trait methods
2024-01-27 19:17:41 +01:00
Aleksander Machniak
34500a4fa4
Fix "missing return statement" phpstan errors
2024-01-27 19:07:52 +01:00
Aleksander Machniak
d976801918
Fix phpstan errors regarding a mocked storage use
2024-01-27 12:08:26 +01:00
Aleksander Machniak
a73a53c8ef
Replace deprecated methods use
2024-01-27 09:58:01 +01:00
Michael Voříšek
ff2d721680
Fix more CS whitespace ( #9318 )
...
* fix "no_useless_else" manually
* fix some "blank_line_before_statement"
* two manual changes
* Revert "fix some "blank_line_before_statement""
This reverts commit 2cc857c00e .
* fix some "blank_line_before_statement" using patched fixer (after "}" only)
* fix continue/break too
2024-01-25 19:17:29 +01:00
Aleksander Machniak
6f8fc03fe8
Solve some phpstan errors
2024-01-24 14:20:21 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
54f4aa33f9
Fix CS - imports ( #9316 )
...
* fix Tests\Browser\TestCase imports
* fix remaining imports
* fix PHPUnit\Framework\TestCase imports
* import GuzzleHttp\Client
* fix remaining
* "php_unit_method_casing" is not todo
* fix "single_line_comment_spacing"
* fix 2nd commit done using older fixer
2024-01-21 19:13:31 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
a797873ef5
Fix "phpdoc_no_empty_return" CS ( #9302 )
...
* replace void with never return type
* replace "return void" phpdoc with native type in tests
* replace "return void" phpdoc with native type in rcube_addressbook
* replace "return void" phpdoc with native type in rcmail_oauth
* fix remaining
2024-01-05 19:03:58 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00