Commit Graph

1181 Commits

Author SHA1 Message Date
Aleksander Machniak
7bf868767e Fix security issue where it was possible to bypass the position:fixed CSS check in received messages (#6898) 2019-08-27 13:50:09 +02:00
Aleksander Machniak
3b4d9f3fb5 PHPDoc updates 2019-08-25 19:24:08 +02:00
Aleksander Machniak
1afa46d28d PHPDoc and CS fixes 2019-08-25 14:15:09 +02:00
Aleksander Machniak
f7832a1a26 Removed 'delete_always' option (#6782) 2019-08-20 15:21:17 +02:00
Aleksander Machniak
902c264cf0 PHPRedis 5 compat. fix in session handler 2019-08-09 16:11:49 +02:00
Jack Cherng
198585d8a0 Fix implode() wrong parameter order (#6866)
It has been deprecated in PHP 7.4.

Such as PHP deprecated:  implode(): Passing glue string after array is deprecated. Swap the parameters in /var/www/roundcubemail/program/lib/Roundcube/rcube_db.php on line 917

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
2019-08-09 16:04:51 +02:00
Sandor Takacs
adcfa53532 Redis::delete() is deprecated in phpredis 5.0.0 (#6883)
Redis::delete() is deprecated in phpredis 5.0.0
2019-08-09 16:03:47 +02:00
Jack Cherng
17d8423299 Fix PHP 7.4 deprecation: array/string curly braces access (#6884)
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
2019-08-09 16:03:20 +02:00
Aleksander Machniak
9b88e9e5c2 Correct vendor string for GMail is 'gimap' 2019-08-01 08:53:38 +02:00
Aleksander Machniak
a80c5569ab Added flag to disable server certificate validation via Mysql DSN argument (#6848) 2019-07-15 09:12:18 +02:00
Aleksander Machniak
786bde62f2 Fix wrong messages order after returning to a multi-folder search result (#6836) 2019-07-14 15:06:24 +02:00
Aleksander Machniak
44bdca4ab9 Enigma: Fix bug where signature verification could have been skipped for some message structures (#6838) 2019-07-10 14:01:51 +02:00
Aleksander Machniak
8f895cb17f Replace function alias: getallheaders() -> apache_request_headers() 2019-07-06 08:28:53 +02:00
Jack Cherng
20bf625733 Remove a unused variable in rcube_plugin::include_stylesheet() (#6832)
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
2019-07-02 09:03:32 +02:00
Aleksander Machniak
b7b2ce7b91 Small code improvement 2019-06-30 11:19:01 +02:00
Aleksander Machniak
0869f02b7c Fix bug in converting multi-page Tiff images into Jpeg (#6824)
When using 'convert' binary we have to use -flatten argument (the same
as we do with thumbnails) otherwise it will produce multiple output files
with -0, -1, etc. suffix. This way we make sure to generate only one image
until we support multi-page Tiff properly.
2019-06-26 13:40:30 +02:00
Aleksander Machniak
0a0ad2c9b7 Switch to IDNA2008 variant (#6806)
After switching IDNA_NONTRANSITIONAL_TO_ASCII on, switch to
IDNA2008 variant in Net_LDAP2. Add test, update changelog.
2019-06-16 12:03:27 +02:00
Max Bosse
f1d3f9ee44 Fix: Use IDNA_NONTRANSITIONAL_TO_UNICODE for idn_to_utf8 call 2019-06-16 10:41:25 +02:00
Max Boße
70c20740e7 Set 'IDNA_NONTRANSITIONAL_TO_ASCII' idn-option 2019-06-16 10:24:37 +02:00
Aleksander Machniak
f6807bcc4c Added 'keyservers' option to define list of HKP servers for Enigma/Mailvelope (#6326) 2019-06-14 19:06:32 +02:00
Aleksander Machniak
8932abd2e7 CS fixes 2019-06-05 10:47:17 +02:00
Aleksander Machniak
24913e51d3 Mention Kolab/Net_LDAP3 as a dependency 2019-06-05 09:51:39 +02:00
Aleksander Machniak
ed9da6cb7f Memcached: Don't add the same server to the pool many times when using persistent connections 2019-05-29 14:58:52 +02:00
Aleksander Machniak
e0792c3287 Skip RSET after authentication failure and QUIT 2019-05-29 11:08:09 +02:00
Aleksander Machniak
fdac30e544 Support PECL memcached extension as a session and cache storage driver (experimental) 2019-05-26 11:50:33 +02:00
Aleksander Machniak
4ef87fe856 Support $HasAttachment/$HasNoAttachment keywords (#6201)
We use these only to display the attachment icon on the messages list.
2019-05-25 09:37:45 +02:00
Aleksander Machniak
6e5027ba24 Fix so userlogins and sendmail logs are never put into the per_user_logging folder 2019-05-21 12:58:43 +02:00
Aleksander Machniak
2dccbf2879 Redis: Support connection to unix socket
Also handle exceptions thrown on connection and remove support for
specifying hosts with redis:// scheme.
2019-05-19 09:41:00 +02:00
Amir Caspi
6b5fa52ec1 Update rcube_utils::parse_host, fixes #6746
Updated regexps used in parse_host to ensure that %t, %d, %z do not cut off domain and return only tld when underlying host has no subdomain (i.e., is just domain.tld rather than mail.domain.tld).  Update fixes #6746, now returns nothing shorter than domain.tld.

Also removed backslash from character class, period does not need to be escaped within character class.
2019-05-19 08:32:26 +02:00
Aleksander Machniak
7c8ce07e8c Fix bug where bold/strong text was converted to upper-case on html-to-text conversion (6758) 2019-05-19 08:12:50 +02:00
Aleksander Machniak
0c4d78aa11 Remove language code from charset name as per the RFC2231.5 2019-05-15 10:09:57 +02:00
Aleksander Machniak
fe90903fa1 Fix bug in parsing vCard data using PHP 7.3 due to an invalid regexp (#6744)
Looks like \R is not allowed in character class, but \r\n is fine.
On PHP 7.3.5 it throws warnings and empty result from preg_replace(),
though I couldn't reproduce.
2019-05-10 21:08:18 +02:00
Aleksander Machniak
f3d16240f2 Fix bug where bmp images couldn't be displayed on some systems (#6728) 2019-05-06 19:57:29 +02:00
Aleksander Machniak
e3014de2ce Simplify code around detected mimetype string 2019-05-06 13:30:09 +02:00
Aleksander Machniak
45a6ad1ba7 Fix so an error is logged when more than one attachment plugin has been enabled, initialize the first one (#6735) 2019-05-01 21:51:22 +02:00
Aleksander Machniak
593188559a Fix regression where non-terminating errors were sent to the browser 2019-05-01 21:45:46 +02:00
Aleksander Machniak
55cca61134 Workaround more invalid HTML cases parsed incorrectly by Mastermind/HTML5 (#6713) 2019-04-28 12:43:10 +02:00
Aleksander Machniak
fbb5a5bc4f Small code simplification in raise_error() 2019-04-22 09:46:38 +02:00
Aleksander Machniak
02dc6ce41c Don't init the session in CLI mode
This prevents from PHP warnings when using CLI scripts e.g. installto.sh.
2019-04-22 09:34:53 +02:00
Aleksander Machniak
72ad567db6 Add new line at the end of error message in CLI mode 2019-04-22 09:32:30 +02:00
Aleksander Machniak
00173a7622 Update some code documentation 2019-04-21 09:36:09 +02:00
Aleksander Machniak
32612f0b8f Log some more info with session_debug 2019-04-19 10:49:01 +02:00
Aleksander Machniak
c87ac075ae Renamed 'log_session' option to 'session_debug' 2019-04-19 10:26:26 +02:00
Aleksander Machniak
57c67db029 Remove year(s) from copyright headers + some cleanup 2019-04-16 10:42:45 +02:00
Aleksander Machniak
69080457b1 Code simplification 2019-04-15 13:01:14 +02:00
Aleksander Machniak
92ed0154d5 Followup fix on handling HTML content w/o html/head/body tag (#6713) 2019-04-15 09:25:12 +02:00
Aleksander Machniak
03d56926d8 Fix bug in HTML parser that could cause missing text fragments when there was no head/body tag (#6713) 2019-04-14 09:53:02 +02:00
Aleksander Machniak
711e46a018 Force HIGHESTMODSEQ use on dovecot
This may fix some messages cache issues. Dovecot does not return
HIGHESTMODSEQ nor NOMODSEQ metadata on SELECT until it is "forced"
to switch to "permanent mod-seq mode". It can be done either by
ENABLE QRESYNC/CONDSTORE or by requesting the metadata explicitely
on SELECT/STATUS. We'll use STATUS for that.
2019-04-11 15:53:50 +02:00
Aleksander Machniak
6f479096d5 Merge branch 'wash-xml-namespace' of https://github.com/dsoares/roundcubemail into dsoares-wash-xml-namespace 2019-04-07 08:20:50 +02:00
Aleksander Machniak
a35699637d Fix PHP error when using Net_LDAP3 from master
get_entry() method signature has changed. We don't really needed
that override in rcube_ldap_generic, so it's now removed.
2019-04-02 12:35:25 +02:00