Commit Graph

7232 Commits

Author SHA1 Message Date
Aleksander Machniak
7bf868767e Fix security issue where it was possible to bypass the position:fixed CSS check in received messages (#6898) 2019-08-27 13:50:09 +02:00
Aleksander Machniak
3b4d9f3fb5 PHPDoc updates 2019-08-25 19:24:08 +02:00
Aleksander Machniak
1afa46d28d PHPDoc and CS fixes 2019-08-25 14:15:09 +02:00
Aleksander Machniak
b35c9c1fdc Apply image preview centering styles only if there's an image
For cases when we display a security warning about the image attachment
the image centering styles would make the warning centered, which
we do not want.
2019-08-23 10:22:54 +02:00
Aleksander Machniak
f7832a1a26 Removed 'delete_always' option (#6782) 2019-08-20 15:21:17 +02:00
johndoh
3a40f6cd91 Add expand_all/collapse_all treelist methods (#6860)
* add expand_all()/collapse_all() treelist methods
* prevent possible race condition in rcmail.folder_collapsed()
2019-08-10 08:46:33 +02:00
Aleksander Machniak
04ff1feec3 Improve wording: record -> list entry 2019-08-09 19:58:04 +02:00
Aleksander Machniak
902c264cf0 PHPRedis 5 compat. fix in session handler 2019-08-09 16:11:49 +02:00
Jack Cherng
198585d8a0 Fix implode() wrong parameter order (#6866)
It has been deprecated in PHP 7.4.

Such as PHP deprecated:  implode(): Passing glue string after array is deprecated. Swap the parameters in /var/www/roundcubemail/program/lib/Roundcube/rcube_db.php on line 917

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
2019-08-09 16:04:51 +02:00
Sandor Takacs
adcfa53532 Redis::delete() is deprecated in phpredis 5.0.0 (#6883)
Redis::delete() is deprecated in phpredis 5.0.0
2019-08-09 16:03:47 +02:00
Jack Cherng
17d8423299 Fix PHP 7.4 deprecation: array/string curly braces access (#6884)
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
2019-08-09 16:03:20 +02:00
Aleksander Machniak
9a225bd3fe Use Left/Right Arrow keys to faster move over threaded messages list (#6399)
Fixed some inconsistencies in list widget expand/collapse code.

Made the arrow keys behavior like in Thunderbird, i.e.:
- Right Arrow expands thread or selects closest child if already expanded,
- Left Arrow collapses thread or jumps to closest parent,
- Left Arrow + Ctrl selects top-most parent,
- Up/Down Arrow keys behavior didn't change.
2019-08-09 13:28:42 +02:00
Aleksander Machniak
dc5be05a5f Select all records on the current list page with CTRL + A (#6813) 2019-08-02 19:19:14 +02:00
Aleksander Machniak
7e8f9da64b Elastic: Add "Show unread messages" button to the search bar (#6587) 2019-08-02 12:38:52 +02:00
Aleksander Machniak
9b88e9e5c2 Correct vendor string for GMail is 'gimap' 2019-08-01 08:53:38 +02:00
johndoh
91398c858a Add KOI8-R to charset_selector (#6861) 2019-07-31 13:19:32 +02:00
Aleksander Machniak
a80c5569ab Added flag to disable server certificate validation via Mysql DSN argument (#6848) 2019-07-15 09:12:18 +02:00
Aleksander Machniak
786bde62f2 Fix wrong messages order after returning to a multi-folder search result (#6836) 2019-07-14 15:06:24 +02:00
Aleksander Machniak
0e4bf6fda8 Fix bug where unread count wasn't updated after moving multi-folder result (#6846) 2019-07-14 13:23:37 +02:00
Aleksander Machniak
d9e3218025 Fix bug where handling multiple messages from multi-folder search result could not work (#6845) 2019-07-14 12:54:15 +02:00
Aleksander Machniak
d39d49b7a6 Fix keyboard navigation (tabindex) on attachments list in compose 2019-07-12 14:49:48 +02:00
Aleksander Machniak
14849be400 Merge branch 'pr-elastic-attachments' of https://github.com/thomascube/roundcubemail into thomascube-pr-elastic-attachments 2019-07-12 13:52:21 +02:00
Thomas Bruederli
00a867a05f Make attachment list :empty selector work 2019-07-11 13:28:43 +02:00
Aleksander Machniak
44bdca4ab9 Enigma: Fix bug where signature verification could have been skipped for some message structures (#6838) 2019-07-10 14:01:51 +02:00
Aleksander Machniak
c1344643a1 Fix bug in miemetype name comparator
The code was removing the first matching prefix (x- or x-ms-), which
caused 'x-ms-bmp' to end up as 'ms-bmp'. It should be 'bmp'. Fixed by
reverting the order of tokens in the regexp.
2019-07-07 15:18:32 +02:00
Aleksander Machniak
bfe2bc17d7 Fix css styles leak from replied/forwarded message to the rest of the composed text (#6831)
Generally do the same with styles what we do on message preview.

This also fixes small bugs in handling styles:
- fix so <style> tag on the start of the HTML content is not ignored
- fix so body's background/bgcolor attributes are applied to the container (regression)
2019-07-07 15:08:23 +02:00
Aleksander Machniak
8f895cb17f Replace function alias: getallheaders() -> apache_request_headers() 2019-07-06 08:28:53 +02:00
Jack Cherng
20bf625733 Remove a unused variable in rcube_plugin::include_stylesheet() (#6832)
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
2019-07-02 09:03:32 +02:00
Aleksander Machniak
b7b2ce7b91 Small code improvement 2019-06-30 11:19:01 +02:00
Aleksander Machniak
446ff50c57 Merge branch 'dev/display_next' of https://github.com/alecpl/roundcubemail into alecpl-dev/display_next 2019-06-30 11:04:20 +02:00
Aleksander Machniak
a991e3181c Put charset meta specification before a title tag, add page title automatically (#6811)
I.e. templates should not specify <title>
2019-06-29 15:48:51 +02:00
Aleksander Machniak
84c4d062c6 Unified and simplified keypress event handling on a list widget 2019-06-28 09:47:14 +02:00
Jack Cherng
e449f30eff Simplify jQuery DOM ready at the footer (#6825)
https://api.jquery.com/ready/#entry-longdesc

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
2019-06-27 07:50:25 +02:00
Aleksander Machniak
0869f02b7c Fix bug in converting multi-page Tiff images into Jpeg (#6824)
When using 'convert' binary we have to use -flatten argument (the same
as we do with thumbnails) otherwise it will produce multiple output files
with -0, -1, etc. suffix. This way we make sure to generate only one image
until we support multi-page Tiff properly.
2019-06-26 13:40:30 +02:00
Aleksander Machniak
2d8c396b6e Fix bug where selection of columns on messages list wasn't working 2019-06-20 10:17:44 +02:00
Aleksander Machniak
6196278869 Fix bug where title text on a treelist record (folder) could include unread count number
Add skip-content class to unreadcount elements
2019-06-19 11:09:02 +00:00
Aleksander Machniak
7846505fa4 Don't expand groups without id
Skipping redundant request for cases like ACL plugin where we may deal
with groups that may have no mail, id nor source assigned in acl identifier
autocompletion.
2019-06-17 09:19:53 +00:00
Aleksander Machniak
0a0ad2c9b7 Switch to IDNA2008 variant (#6806)
After switching IDNA_NONTRANSITIONAL_TO_ASCII on, switch to
IDNA2008 variant in Net_LDAP2. Add test, update changelog.
2019-06-16 12:03:27 +02:00
Max Bosse
f1d3f9ee44 Fix: Use IDNA_NONTRANSITIONAL_TO_UNICODE for idn_to_utf8 call 2019-06-16 10:41:25 +02:00
Max Boße
70c20740e7 Set 'IDNA_NONTRANSITIONAL_TO_ASCII' idn-option 2019-06-16 10:24:37 +02:00
Aleksander Machniak
89a342a03a Elastic: Fix visual issue with long buttons in .boxwarning (#6797) 2019-06-16 09:38:54 +02:00
Aleksander Machniak
f6807bcc4c Added 'keyservers' option to define list of HKP servers for Enigma/Mailvelope (#6326) 2019-06-14 19:06:32 +02:00
Aleksander Machniak
1423536ce0 Plugin API: Add 'render_folder_selector' hook 2019-06-12 11:37:58 +00:00
Aleksander Machniak
22a47cced6 Changes in display_next setting (#6795)
- Move it to Preferences > User Interface > Main Options
- Make it apply to Contacts interface too
- Make it apply only if deleting/moving a previewed message/contact
2019-06-10 13:44:17 +02:00
Aleksander Machniak
940e500c1f Enigma: For verified signatures, display the user id associated with the sender address (#5958) 2019-06-09 09:52:39 +02:00
Aleksander Machniak
0e4156ea83 Fix bug where Next/Prev button in mail view didn't work with multi-folder search result (#6793) 2019-06-07 10:25:47 +02:00
Aleksander Machniak
c8bec34f8f Properly apply assets_path to contact photo placeholder 2019-06-05 10:06:40 +00:00
Aleksander Machniak
8932abd2e7 CS fixes 2019-06-05 10:47:17 +02:00
Aleksander Machniak
24913e51d3 Mention Kolab/Net_LDAP3 as a dependency 2019-06-05 09:51:39 +02:00
Aleksander Machniak
ed9da6cb7f Memcached: Don't add the same server to the pool many times when using persistent connections 2019-05-29 14:58:52 +02:00