Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
651710ca96
Fix deprecated (in PHP 8.4) use of session_set_save_handler() ( #9060 )
2023-11-11 12:49:27 +01:00
Aleksander Machniak
2c0b870bd6
Fix bug where session could time out if DB and PHP timezone were different ( #8303 )
2022-03-13 11:40:49 +01:00
Aleksander Machniak
8eb382b4ca
PHP8 fixes
2020-12-11 20:29:41 +01:00
Aleksander Machniak
85cfacc882
PHP8 fixes, CS fixes, short array syntax, tests
2020-11-29 12:20:51 +01:00
Aleksander Machniak
a5c2b4360c
Fixes in context of undefined variables, and code style
2020-08-15 12:13:31 +02:00
Aleksander Machniak
15ee34a438
Revert "Fix bug where session was destoryed with window close ( #7251 )"
...
This reverts commit 32fac136db
2020-04-05 12:25:01 +02:00
Aleksander Machniak
32fac136db
Fix bug where session was destoryed with window close ( #7251 )
2020-04-04 11:52:42 +02:00
Aleksander Machniak
e7ebff56df
PHPDoc fixes
2019-09-30 20:43:07 +02:00
Aleksander Machniak
00173a7622
Update some code documentation
2019-04-21 09:36:09 +02:00
Aleksander Machniak
32612f0b8f
Log some more info with session_debug
2019-04-19 10:49:01 +02:00
Aleksander Machniak
c87ac075ae
Renamed 'log_session' option to 'session_debug'
2019-04-19 10:26:26 +02:00
Aleksander Machniak
57c67db029
Remove year(s) from copyright headers + some cleanup
2019-04-16 10:42:45 +02:00
Aleksander Machniak
a7df28093f
Make rcube_session::unserialize() public method
2019-01-01 18:37:38 +01:00
Aleksander Machniak
edd9c31d6c
Skip registering session handlers when session already exists
...
.. for a specific use case when I want to create additional rcube_session object
for discrete operations on another session.
2018-11-23 15:35:10 +00:00
Aleksander Machniak
b126941846
Fix session issue on long running requests ( #6470 )
2018-10-06 10:59:19 +02:00
Aleksander Machniak
0f4f85e097
Skip redundant INSERT query on successful logon when using PHP7
...
Since PHP 7.0 session_regenerate_id() will cause the old session data update.
This is redundant INSERT query and also produces a record for the session
we don't need anymore.
2017-11-04 10:42:24 +01:00
Aleksander Machniak
8c75dd3aa8
Add convenient method to create new session records
2016-09-29 12:20:43 +02:00
Aleksander Machniak
d72e5afb47
Fix PHP7 warning "session_start(): Session callback expects true/false return value" ( #1490624 )
2015-12-28 17:07:53 +01:00
Aleksander Machniak
cd219a45dd
Fix regression where some message attachments could be missing on edit/forward ( #1490608 )
2015-12-18 11:42:05 +01:00
Aleksander Machniak
7bbb86f78a
Session read handler must return a string in PHP7
2015-09-19 08:35:35 +02:00
Aleksander Machniak
f75bc5c24b
Use random security tokens instead of hashes based on encryption key ( #1490404 )
2015-09-08 09:38:45 +02:00
Aleksander Machniak
93e64008a6
Small code improvements
2015-08-05 09:30:51 +02:00
Aleksander Machniak
e2bceaefe6
Support more secure hashing algorithms for auth cookie - configurable by PHP's session.hash_function ( #1490403 )
2015-07-18 16:05:34 +02:00
Aleksander Machniak
a958748947
CS fixes
2015-06-07 15:26:33 +02:00
Thomas Bruederli
87ff88d550
Fix session garbage collector handler registration after refactoring
2015-03-09 17:17:04 +01:00
corbosman
b4be89bdac
use factory
2015-02-27 15:03:58 +01:00
corbosman
4df4ab5007
session refactor and add redis driver
2015-02-19 14:55:09 +01:00
Aleksander Machniak
34a0902089
Use consistent column/table quoting in sql queries
2014-09-12 14:37:51 +02:00
Thomas Bruederli
17acd5ccda
Use public property instead of setter method to improve compatibility
2014-05-27 19:51:04 +02:00
Thomas Bruederli
14291c79db
Add option to suppress session data writes to DB
2014-05-22 18:02:02 +02:00
Thomas Bruederli
1e7d1240ed
Avoid rcube_session::reload() to reset previous changes. This fixes parallel attachment uploads that could get lost when using the database_attachments plugin
2013-11-07 11:38:58 +01:00
Thomas Bruederli
1a8cf64dd1
Avoid session timeouts with memcache backend as proposed by D. Carter via users mailing list
2013-07-23 11:12:44 +02:00
Thomas Bruederli
4d480b36ea
Respect HTTP_X_FORWARDED_FOR and HTTP_X_REAL_IP variables for session IP check
2013-07-17 08:04:15 +02:00
Aleksander Machniak
3dbe4f79e4
Fix session issues when local and database time differs ( #1486132 )
...
Improve performance by executing session gc on script shutdown, also call session_write_close() ASAP
2013-06-16 14:18:57 +02:00
Thomas Bruederli
42de33c7de
Add option to use PHP's native session save handlers
2013-06-05 09:10:08 +02:00
Victor Benincasa
3906264747
Fix typos
2013-03-26 07:08:58 -03:00
Thomas Bruederli
f603883d37
Fix typo
2013-03-25 09:07:29 +01:00
Thomas Bruederli
4034a79beb
Check for exact matching session keys before splitting into path segments. Adds backwards-compatibility after commit f0a7159c
2013-03-25 09:05:26 +01:00
Thomas Bruederli
f0a7159c40
Add methods to append certain nodes to session data in order to avoid session saving race conditions. Fixes #1488422
2013-03-02 00:10:54 +01:00
Aleksander Machniak
0d214498d0
CS fixes
2012-12-18 19:02:53 +01:00
Aleksander Machniak
d2534c63f2
Cleanup, remove file paths from doc
2012-12-18 09:07:00 +01:00
Aleksander Machniak
ba6f21caeb
Framework files moved to lib/Roundcube
2012-11-21 19:52:03 +01:00
