Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
93946f4ca7
Fix "self_accessor" PHP CS Fixer rule ( #9269 )
2023-12-17 09:44:43 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
6b25d146a1
Fix PHP fatal error when importing vcf file using PHP 8.2 ( #9025 )
...
and some PHP8 warning
2023-06-03 12:14:35 +02:00
Aleksander Machniak
819afeff29
Fix a couple of PHP8 warnings ( #8420 )
2022-01-29 08:35:50 +01:00
Aleksander Machniak
f429b26810
Fix various PHP8 warnings ( #8392 )
2022-01-11 19:04:24 +01:00
Aleksander Machniak
c331431521
Fix some PHP8 compatibility issues ( #8363 )
2021-12-17 18:54:37 +01:00
Aleksander Machniak
f2688ba492
Use ?? operator where applicable
2021-09-21 19:12:06 +02:00
Aleksander Machniak
b4e9cda45b
PHP 8.1 warning fix
2021-07-31 17:45:33 +02:00
Aleksander Machniak
766189f524
Fix PHP 8.1 deprecation warnings
2021-07-31 08:38:47 +02:00
Aleksander Machniak
0d4a395464
Fix PHP 8.1 deprecation warnings
2021-07-31 07:53:14 +02:00
Josh Soref
203f456620
Spelling ( #8001 )
2021-04-18 08:43:18 +02:00
Michael Stilkerich
0608af9814
phpdoc type annotations to aid static analysis tools ( #7957 )
2021-03-21 14:39:17 +01:00
Aleksander Machniak
ac8e067ae6
Use official GPL-3.0-or-later license identifier ( #7901 )
2021-02-24 15:39:36 +01:00
johndoh
dec10e51da
Support providing skins for plugins inside the main skin folder ( #7445 )
2020-12-21 09:45:34 +01:00
Aleksander Machniak
f4ed1024dc
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-02 20:15:00 +01:00
Aleksander Machniak
8110ed9a9d
PHP8 fixes, CS fixes, short array syntax, tests
2020-11-30 20:37:50 +01:00
Aleksander Machniak
596004beb3
More actions tests, code improvements
2020-11-07 12:54:12 +01:00
Aleksander Machniak
f95212d626
PHP8: More warnings fixed
2020-10-11 15:24:30 +02:00
Aleksander Machniak
bde383d051
PHP8: Fix various issues
...
for now only these I found by running our unit tests, there will be much more
2020-10-11 10:32:41 +02:00
Aleksander Machniak
a5c2b4360c
Fixes in context of undefined variables, and code style
2020-08-15 12:13:31 +02:00
Aleksander Machniak
c39081b6a1
Fix bug in extracting required plugins from composer.json that led to spurious error in log ( #7364 )
2020-05-01 18:55:14 +02:00
Aleksander Machniak
219e353ac1
Fix local file inclusion (and code execution) via crafted 'plugins' option
2020-04-26 08:02:53 +02:00
Aleksander Machniak
45a6ad1ba7
Fix so an error is logged when more than one attachment plugin has been enabled, initialize the first one ( #6735 )
2019-05-01 21:51:22 +02:00
Aleksander Machniak
57c67db029
Remove year(s) from copyright headers + some cleanup
2019-04-16 10:42:45 +02:00
Aleksander Machniak
e38b477b99
Fix including plugin scripts (regression)
2018-09-21 08:48:07 +02:00
Aleksander Machniak
2c12274d38
Fix style/navigation on error page depending on authentication state ( #6362 )
2018-09-20 15:38:22 +02:00
johndoh
05d1b1947e
Check for minified CSS files ( #6089 )
2017-12-12 19:51:17 +01:00
Aleksander Machniak
9ce8948294
Get rid of the 2nd argument of include_stylesheet()
...
.. make the optional behavior default now.
2017-11-20 14:03:07 +01:00
Aleksander Machniak
1cf72fa2b6
Allow plugins to include Less files ( #6051 )
2017-11-20 13:48:07 +01:00
Aleksander Machniak
1c24c69a3b
Fix path for css file existence check in include_stylesheet()
2017-08-09 08:03:24 +02:00
Aleksander Machniak
69f50b122d
Add a way to include plugin stylesheets optionally only if the file exists
2017-08-06 19:46:22 +02:00
Aleksander Machniak
e04f72d018
Fix PHP 7.2 warnings on count() use ( #5845 )
2017-07-09 13:20:57 +02:00
Aleksander Machniak
7e3298753a
Use ternary operator where aplicable
2015-11-14 10:08:07 +01:00
Aleksander Machniak
5ed8ade763
Fix bug where some plugins could be initialized more than one time
2015-08-05 11:45:03 +02:00
Aleksander Machniak
a958748947
CS fixes
2015-06-07 15:26:33 +02:00
Thomas Bruederli
5def0d8e9e
Ignore plugin loading filter if force parameter is set
2015-03-11 16:47:28 +01:00
Aleksander Machniak
75e8a7d313
Really make sure plugins aren't initialized twice
2015-02-24 11:38:22 +01:00
Aleksander Machniak
6c8cbe3ee5
Fix regression where require_plugin() wasn't initializing the plugin
2015-02-23 11:06:55 -05:00
Aleksander Machniak
3665d1e8ec
Merge pull request #259 from corbosman/plugin_preload
...
Plugin preload
2015-02-19 08:31:43 +01:00
corbosman
de89d46be2
Load plugins before sessions have started
...
Move the plugin loading phase to before sessions have started allowing plugins to add session drivers. Plugins that want to use this should define an "onload" method in their plugins. This method does not have access to variables like $task as they are not yet initialised at that time.
2015-02-04 13:17:51 +01:00
Aleksander Machniak
09d52dbb67
Fix some typos in comments
2015-02-04 10:46:14 +01:00
Aleksander Machniak
20740a9650
Fix error in exec_hook() in case some hook handler was unregistered before
2015-02-04 10:21:00 +01:00
Aleksander Machniak
0a5841702f
Fix exec_hook() so handlers added inside the hook are not omitted
2015-01-29 12:41:43 -05:00
Aleksander Machniak
8c2075b9fc
Remove hook aliases deprecated long time ago, CS fixes
2015-01-10 18:05:49 +01:00
Aleksander Machniak
72b117feb1
Use consistent license identifiers, remove redundant package.xml files
2014-12-09 05:02:13 -05:00
