Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
86eda9f7ed
Fix "increment_style" CS ( #9296 )
...
* Fix "increment_style" CS
* use "post" increment style
2024-01-01 12:23:21 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
a9167a0d2f
Fix "static_lambda" CS ( #9276 )
2023-12-20 20:01:00 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Aleksander Machniak
164d486594
Fix PHP8 warning
2023-12-12 12:16:37 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Michael Voříšek
a5bb3b2b08
Fix rcube_imap::sort_folder_comparator() warning on Windows ( #9253 )
...
* Fix rcube_imap::sort_folder_comparator() for Windows
* fix more robustly
2023-12-10 15:50:55 +01:00
Aleksander Machniak
8415e34c2b
Cleanup
2023-11-07 15:53:40 +01:00
Aleksander Machniak
cd87dd013f
Fix cross-site scripting (XSS) vulnerability in setting Content-Type/Content-Disposition for attachment preview/download
...
Thanks to rehme.infosec for reporting the issues.
2023-11-04 17:52:00 +01:00
Denys Klymenko
26ba211400
Fix PHP fatal error on folder read-only check ( #9190 )
2023-10-29 12:52:37 +01:00
Aleksander Machniak
04767b6b47
Fix bug where images attached to application/smil messages weren't displayed ( #8870 )
2023-10-21 18:15:00 +02:00
Aleksander Machniak
6880e085f9
Fix PHP8 fatal error when parsing a malformed BODYSTRUCTURE ( #9171 )
2023-10-17 20:02:30 +02:00
Aleksander Machniak
048e1e8e9b
Fix PHP8 warnings
2023-08-20 08:13:35 +02:00
Aleksander Machniak
6fdcef3b6b
Fix PHP8 warnings
2023-07-12 18:55:47 +02:00
Adrien Beau
d8146b6150
Fix sort_folder_comparator ( #9057 )
...
In case $path2 is longer than $path1, and all folders in $path1 are
equal to the corresponding folder in $path2 (in other words: $path2 is a
subfolder of $path1), sort_folder_comparator currently considers them
equal because it stops comparing when it reaches the end of $path1.
This breaks the ordering done by uasort() above, and breaks code that
relies on the folder list being sorted, notably the folders settings
page.
2023-07-09 19:51:10 +02:00
Aleksander Machniak
813dacec71
Fix potential PHP fatal error when opening a message with message/rfc822 part ( #8953 )
2023-07-09 13:18:11 +02:00
Aleksander Machniak
b9de4841d3
Don't log an imap authentication error when log_logins=true
2023-06-15 10:54:38 +02:00
Aleksander Machniak
9d9912c12f
Fix bug where subfolders could loose subscription on parent folder rename ( #8892 )
2023-05-10 21:07:48 +02:00
Aleksander Machniak
33fac1927e
Fix PHP 8.1 warnings, make BODYSTRUCTURE parser less fragile ( #8803 )
2022-11-28 20:34:02 +01:00
Aleksander Machniak
e7f57c6dd5
Fix PHP warning ( #8794 )
2022-11-26 10:17:29 +01:00
Aleksander Machniak
e111f22d50
Fix a PHP warning ( #8743 )
2022-11-11 13:26:08 +01:00
Aleksander Machniak
aac9b696b8
Fix various PHP 8.2 warnings
2022-08-06 09:22:12 +02:00
Michael Steininger
38bf246b0d
Fix usage of "break" ( #8624 )
2022-07-21 18:38:08 +02:00
Aleksander Machniak
f23aaed10e
Remove use of unreliable charset detection ( #8344 )
2022-04-09 14:13:50 +02:00
Aleksander Machniak
bfef4691cf
Fix PHP8 warning ( #8466 )
2022-03-12 09:38:54 +01:00
Aleksander Machniak
78b3049ce5
Fix PHPDoc
2022-02-18 19:19:07 +01:00
Aleksander Machniak
06b6089767
Fix handling of RFC2231-encoded attachment names inside of a message/rfc822 part ( #8418 )
2022-01-29 10:16:48 +01:00
Aleksander Machniak
f429b26810
Fix various PHP8 warnings ( #8392 )
2022-01-11 19:04:24 +01:00
Aleksander Machniak
81cc8ac0e0
Purge also subfolders of Trash (and/or messages in them) on logout ( #1037 )
2021-10-09 16:55:28 +02:00
Aleksander Machniak
f2688ba492
Use ?? operator where applicable
2021-09-21 19:12:06 +02:00
Aleksander Machniak
63056eb803
Fix PHP8 warnings ( #8175 )
2021-09-11 08:59:15 +02:00
Aleksander Machniak
4d233b5c65
Fix strpos(): empty needle warning ( #8184 )
2021-08-29 18:27:06 +02:00
Aleksander Machniak
e2187b8f2d
Fix various PHP 8.1 warnings
2021-08-27 16:52:54 +02:00
Aleksander Machniak
6ff862d7d8
Fix a couple of PHP8 warnings ( #8175 )
2021-08-25 18:57:50 +02:00
Aleksander Machniak
9caab5f701
Fix PHP8 warnings
2021-07-16 12:57:46 +02:00
Thomas Bruederli
861be4606b
Fix phpdoc error
2021-06-21 20:56:12 +02:00
Aleksander Machniak
094ef387e9
Fix bug where plus characters in attachment filename could have been ignored ( #8074 )
2021-05-28 11:34:20 +02:00
Josh Soref
203f456620
Spelling ( #8001 )
2021-04-18 08:43:18 +02:00
Aleksander Machniak
dd6aefe1fd
Fix bug where imap_conn_options settings were ignored ( #7912 )
2021-03-04 19:14:28 +01:00
hefee
8ef57a4173
Add 'reconnect' plugin to retry IMAP connection ( #7844 )
...
* Make storage_connect hook ready to be usable for reconnect plugins.
* Add reconnect plugin to retry to login into IMAP server.
Co-authored-by: Sandro Knauß <hefee@debian.org >
2021-02-06 16:46:21 +01:00
Aleksander Machniak
17ae3693c3
PHP8 fixes + fix fatal error when refreshing compose page in forward-as-attachment state
2020-12-18 19:27:25 +01:00
Aleksander Machniak
3bbb01fe13
PHP8 fixes, regression fixes
2020-12-13 12:14:15 +01:00
Aleksander Machniak
61a5ade872
PHP8 fixes, short array syntax
2020-12-12 16:20:14 +01:00
Aleksander Machniak
8eb382b4ca
PHP8 fixes
2020-12-11 20:29:41 +01:00
Aleksander Machniak
f4ed1024dc
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-02 20:15:00 +01:00
