Michael Voříšek
a797873ef5
Fix "phpdoc_no_empty_return" CS ( #9302 )
...
* replace void with never return type
* replace "return void" phpdoc with native type in tests
* replace "return void" phpdoc with native type in rcube_addressbook
* replace "return void" phpdoc with native type in rcmail_oauth
* fix remaining
2024-01-05 19:03:58 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
a9167a0d2f
Fix "static_lambda" CS ( #9276 )
2023-12-20 20:01:00 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Edouard Vanbelle
588a879107
OAuth improvements ( #9217 )
...
- OAuth: Add `oauth_config_uri` - support OAuth/OpenIDC discovery (#8201 )
- OAuth: Add `oauth_logout_uri` - allow invalidating the OAUTH-Session on logout (#8057 )
- OAuth: Support for OpenID Connect RP-Initiated Logout (#9109 )
- OAuth: Add support of OAUTHBEARER (#9217 )
- OAuth: Add `oauth_debug` option (#9217 )
- OAuth: Fix: missing config `oauth_provider_name` in rcmail_oauth's constructor (#9217 )
- OAuth: Refactor: move display to the rcmail_oauth class and use `loginform_content` hook (#9217 )
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr >
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:13:07 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
ef9d345441
Drop dependency on JsTimeZoneDetect ( #8965 )
2023-04-09 16:06:00 +02:00
Aleksander Machniak
156e480a26
Fix invalid onclick handler on the logo image when using non-array skin_logo setting ( #8933 )
2023-02-26 10:14:38 +01:00
Oliver Rahner
f7b8b14df8
Check if shell_exec() exists and work around if it doesn't ( #8814 )
2022-12-31 10:31:22 +01:00
Aleksander Machniak
3b16cbf371
Fix bug where "about:blank" page could trigger "load error" ( #8554 )
...
Use javascript:false; instead
2022-08-15 09:58:56 +02:00
Aleksander Machniak
aac9b696b8
Fix various PHP 8.2 warnings
2022-08-06 09:22:12 +02:00
Aleksander Machniak
fa65a68389
Use ... oprator instead of func_get_args() for variadic functions
2022-04-27 19:21:00 +02:00
Github-Citizen
0e2858da97
Added link to logo image using $config['skin_logo'] ( #8509 )
...
Added ability to define a link URL for the logo image using $config['skin_logo'].
Works by defining the `logo type` for $config['skin_logo'] as `[link]` for example:
$config['skin_logo'] = ['elastic:*[link]' => 'https://www.example.com '];
$config['skin_logo'] = ['[link]' => 'https://www.example.com '];
Same relative path rules apply as when you define location of logo image file.
Starting with `http://` or `https://` is absolute.
Starting with a slash `/page.html` is relative to the skin directory ie `example.com/skins/elastic/page.html`
Starting without a slash `page.html` is relative to the website root directory ie `example.com/page.html`
2022-04-24 09:37:35 +02:00
Aleksander Machniak
893216cb29
Unified and simplified services connection options ( #8310 )
2021-12-07 15:07:54 +01:00
Thomas Bruederli
0c7c9e7ccb
Fix relative path to assets if /index.php/foo/bar url is used ( #8144 )
2021-12-02 21:25:20 +01:00
Aleksander Machniak
a9f51ced21
CS fixes, update changelog
2021-11-28 08:39:12 +01:00
Philip Weir
e2a9d36f5e
Add loginform_content plugin hook ( #8273 )
2021-11-28 08:32:50 +01:00
Aleksander Machniak
640e22d987
Fix PHP8 warnings
2021-10-17 11:18:14 +02:00
Aleksander Machniak
e0e5626802
Bring back support for defining logo images via data-src-* attributes
...
Removed (unintentionally?) in 4c8ea71e3a
2021-09-30 13:46:48 +02:00
Aleksander Machniak
14522d7108
get_input_value() -> get_input_string()
2021-09-26 11:34:31 +02:00
Aleksander Machniak
5db6dd0317
Fix handling of dark_mode_support:false setting in skins meta.json ( #8186 )
2021-09-25 09:59:23 +02:00
Aleksander Machniak
f2688ba492
Use ?? operator where applicable
2021-09-21 19:12:06 +02:00
Aleksander Machniak
e2187b8f2d
Fix various PHP 8.1 warnings
2021-08-27 16:52:54 +02:00
Aleksander Machniak
0d4a395464
Fix PHP 8.1 deprecation warnings
2021-07-31 07:53:14 +02:00
Aleksander Machniak
5d81c15f07
Document blankpage_url option ( #5025 )
2021-06-05 09:29:21 +02:00
Aleksander Machniak
24fc958f03
Improve template conditionals parsing
...
The old method with big regexps was buggy as described in #8065 .
2021-05-19 19:49:57 +02:00
johndoh
bf2c4f32e4
Regex optimisation, fix #8065 ( #8068 )
2021-05-19 08:07:24 +02:00
Josh Soref
203f456620
Spelling ( #8001 )
2021-04-18 08:43:18 +02:00
johndoh
8547ccb765
Remove duplicate <title> tag in iframe output ( #7997 )
2021-04-12 11:15:53 +02:00
johndoh
8453d147d7
Handle http 500 error on message send ( #7959 )
2021-04-09 08:25:38 +02:00
Thomas Bruederli
8fdf37bf21
Set absolute path for assets if PATH_INFO is set (#7812,#7923)
2021-03-15 21:20:07 +01:00
Aleksander Machniak
435d6c6fc2
Don't cache disabled_actions setting in memory
...
If some plugin changed the setting after first button() method
use, the change would not have been seen in the rest of the method calls.
2021-03-15 14:12:37 +01:00
johndoh
1eebfd723b
Improve detection of external urls for redirect ( #7823 )
2021-01-23 10:15:09 +01:00
Thomas Bruederli
375d668064
Hide login form fields when oauth_login_redirect is configured ( #7830 )
2021-01-18 21:17:48 +01:00
johndoh
dec10e51da
Support providing skins for plugins inside the main skin folder ( #7445 )
2020-12-21 09:45:34 +01:00
Aleksander Machniak
5aa0d09def
Add array_first() helper, fix some code issues
2020-12-20 09:44:17 +01:00
johndoh
cfd4fa170f
Fix a few PHP notices ( #7791 )
2020-12-19 19:36:58 +01:00
Aleksander Machniak
84949fbb4e
CS fixes, added more tests
2020-12-17 19:45:12 +01:00
Aleksander Machniak
3bbb01fe13
PHP8 fixes, regression fixes
2020-12-13 12:14:15 +01:00
Aleksander Machniak
f4ed1024dc
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-02 20:15:00 +01:00
Aleksander Machniak
0cbe4a4acc
PHP8 fixes, CS fixes, short array syntax, added more tests
2020-11-22 12:03:02 +01:00
Aleksander Machniak
1007b873f0
More action tests, PHP8 fixes
2020-11-15 12:03:37 +01:00
Aleksander Machniak
596004beb3
More actions tests, code improvements
2020-11-07 12:54:12 +01:00
Aleksander Machniak
97991b59be
Add more tests for contact actions, fix various code issues
2020-11-05 11:59:02 +01:00
Aleksander Machniak
e99fb3968d
Add tests for contacts export action, fix PHP8 issues
2020-11-02 18:49:39 +01:00
