Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
93946f4ca7
Fix "self_accessor" PHP CS Fixer rule ( #9269 )
2023-12-17 09:44:43 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
20447fa962
Fix PHP8 warnings ( #9142 )
2023-09-18 11:15:33 +02:00
Aleksander Machniak
57b161111f
Fix bug where installto.sh/update.sh scripts were removing some essential options from the config file ( #9051 )
...
Plus small code improvements
2023-07-08 09:10:45 +02:00
Aleksander Machniak
ed73265c76
Create rcmail_install::unzip() and simplify code
2023-03-05 11:30:11 +01:00
Thomas B
dec93dc1b7
Update vendor dir from installto.sh if untouched ( #8642 ) ( #8840 )
...
* installto.sh checks for a marker indicating that composer was not run/used.
* update.sh tries to find and run composer
2023-01-05 21:30:51 +01:00
Aleksander Machniak
cb1951048c
Fix regression in create_config()
...
On update some bool options might got changed values to false,
if not specified in the config.inc.php file.
2022-11-13 14:11:52 +01:00
Aleksander Machniak
e6ed5ae19e
Fix handling of smtp/imap port options on configuration file update ( #8756 )
2022-11-13 13:19:45 +01:00
Aleksander Machniak
019801a430
Removed support for MS SQL Server and Oracle ( #7854 )
2022-09-11 11:01:03 +02:00
Aleksander Machniak
44f0d6cbc4
Fix bug where renamed options were removed from the config on installto.sh (update.sh) run ( #8643 )
2022-08-01 21:00:35 +02:00
Aleksander Machniak
01e42cfe57
Fix bug where config creation in Installer did ignore options in the form ( #8634 )
2022-07-31 12:41:05 +02:00
Aleksander Machniak
afa1221783
Fix PHP8 warnings
2022-07-24 12:45:50 +02:00
Aleksander Machniak
01b7dbd1a7
Lock Installer to a set of supported config options
2022-01-23 09:11:58 +01:00
Aleksander Machniak
893216cb29
Unified and simplified services connection options ( #8310 )
2021-12-07 15:07:54 +01:00
Aleksander Machniak
f2688ba492
Use ?? operator where applicable
2021-09-21 19:12:06 +02:00
Josh Soref
203f456620
Spelling ( #8001 )
2021-04-18 08:43:18 +02:00
Aleksander Machniak
b4b24f93df
Fix some PHP8 warnings
2021-01-15 18:56:48 +01:00
Aleksander Machniak
6b8881271f
By default do not set the User-Agent header ( #7731 )
2020-12-28 19:25:33 +01:00
Aleksander Machniak
12547ccf01
Require php-intl extension, get rid of Net_IDNA2, PHP8 fixes, short array syntax
...
Net_IDNA2 is not compatible, and Intl is a bundled ext since PHP 5.3.
Fixed some regressions.
2020-12-13 10:21:52 +01:00
Aleksander Machniak
f4ed1024dc
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-02 20:15:00 +01:00
Aleksander Machniak
0cbe4a4acc
PHP8 fixes, CS fixes, short array syntax, added more tests
2020-11-22 12:03:02 +01:00
Aleksander Machniak
8b16a7dfe7
More tests
2020-11-08 11:06:42 +01:00
johndoh
34a0af8964
Allow array in smtp_host config ( #7296 )
2020-05-16 14:05:28 +02:00
Aleksander Machniak
014659b600
CS fixes, mostly around undefined variables
2020-05-03 11:29:15 +02:00
Aleksander Machniak
3cd3d8eecb
Fix bug where the Installer would not warn about required schema upgrade ( #7042 )
2019-11-16 09:23:32 +01:00
Aleksander Machniak
bd21d43ac9
Small correction
2019-11-15 11:55:39 +01:00
Aleksander Machniak
90738d7a36
Fix so Elastic is also a default in jqueryui plugin ( #7039 )
2019-11-15 10:41:06 +01:00
Aleksander Machniak
814db5a33e
Fixed typo
2019-11-13 06:55:47 +01:00
Aleksander Machniak
294683b390
Fix so update.sh script warns about changed defaults ( #7011 )
2019-11-12 20:30:42 +01:00
Aleksander Machniak
66fab8cdb2
CS fixes, Avoid usused variables, fixed minor bugs
2019-10-05 19:44:39 +02:00
Aleksander Machniak
e7ebff56df
PHPDoc fixes
2019-09-30 20:43:07 +02:00
Aleksander Machniak
5040009f9c
Fix array offset access syntax with curly braces
2019-09-11 10:22:36 +02:00
Aleksander Machniak
1afa46d28d
PHPDoc and CS fixes
2019-08-25 14:15:09 +02:00
Aleksander Machniak
57c67db029
Remove year(s) from copyright headers + some cleanup
2019-04-16 10:42:45 +02:00
Aleksander Machniak
6e74498656
Fix so mime_content_type check in Installer uses files that should always be available (i.e. from program/resources) ( #6599 )
2019-01-30 13:05:54 +01:00
Aleksander Machniak
796e5a17e6
Removed referer_check option ( #6440 )
2018-09-12 08:27:09 +02:00
Thomas Bruederli
728c186943
Deprecate debug_level config option
2018-08-24 21:24:18 +02:00
Aleksander Machniak
4b97f40af9
Get rid of debug_level ( #6298 )
2018-05-22 11:12:24 +02:00
Aleksander Machniak
84a79ee8db
Move common mail composing/sending code to new rcmail_sendmail class
...
This is needed to make simpler an implementation of e.g.
- Mail Bounce feature (#4985 ),
- Direct Draft sending (#4998 ),
- Fast reply from mail preview (#5129 ).
2017-07-05 13:18:08 +02:00
Aleksander Machniak
cc0defce86
Fix failing database schema check in all engines except mysql ( #5730 )
2017-04-21 09:48:46 +02:00
Aleksander Machniak
a844db6a27
Merge branch 'dev-layouts'
2016-11-20 19:04:09 +01:00
Aleksander Machniak
40fe66b71e
Fix reference to non-existing blank.tif file in mime_content_type check
2016-10-06 21:11:24 +02:00
Aleksander Machniak
6886a4de3f
Widescreen layout aka three column view ( #5093 )
2016-09-17 19:04:33 +02:00
