Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
86eda9f7ed
Fix "increment_style" CS ( #9296 )
...
* Fix "increment_style" CS
* use "post" increment style
2024-01-01 12:23:21 +01:00
Aleksander Machniak
f5091423c6
2023 -> 2024
...
[skip ci]
2024-01-01 10:38:21 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Edouard Vanbelle
320bdefb57
OAuth: code refactorization ( #9274 )
...
* OAuth: Refact.: migrate login flow into hooks (more evolutive code and less dependency to core code)
* OAuth: Fix: logger prefix (include prefix during login phase)
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr >
2023-12-26 09:07:50 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
a9167a0d2f
Fix "static_lambda" CS ( #9276 )
2023-12-20 20:01:00 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Edouard Vanbelle
588a879107
OAuth improvements ( #9217 )
...
- OAuth: Add `oauth_config_uri` - support OAuth/OpenIDC discovery (#8201 )
- OAuth: Add `oauth_logout_uri` - allow invalidating the OAUTH-Session on logout (#8057 )
- OAuth: Support for OpenID Connect RP-Initiated Logout (#9109 )
- OAuth: Add support of OAUTHBEARER (#9217 )
- OAuth: Add `oauth_debug` option (#9217 )
- OAuth: Fix: missing config `oauth_provider_name` in rcmail_oauth's constructor (#9217 )
- OAuth: Refactor: move display to the rcmail_oauth class and use `loginform_content` hook (#9217 )
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr >
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:13:07 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
4a780ed741
Fix PHP8 warning ( #9238 )
2023-12-04 20:56:01 +01:00
Aleksander Machniak
17eec91deb
Fix PHP8 warning ( #9235 )
...
And added tests for utils/modcss action
2023-12-03 10:40:57 +01:00
Philip Weir
89ce052242
Unify HTML editor font settings ( #9177 )
2023-11-25 14:23:17 +01:00
Aleksander Machniak
cd87dd013f
Fix cross-site scripting (XSS) vulnerability in setting Content-Type/Content-Disposition for attachment preview/download
...
Thanks to rehme.infosec for reporting the issues.
2023-11-04 17:52:00 +01:00
Aleksander Machniak
ce0d1ab13f
Fix PHP string replacement error in utils/error.php ( #9185 )
2023-10-29 12:50:27 +01:00
Aleksander Machniak
d08d167884
Code improvements for latest changes regarding #9077 , #7556
2023-10-08 10:36:18 +02:00
vladimirdulov
e7360d87b1
Make mail search scope configurable ( #9077 , #7556 )
...
Co-authored-by: Vladimir D <vladimir@brandlight.org >
2023-10-08 10:24:28 +02:00
Aleksander Machniak
8cd3ceeb36
Fix "Show source" on mobile with x_frame_options = deny ( #9084 )
2023-08-20 08:34:20 +02:00
Aleksander Machniak
048e1e8e9b
Fix PHP8 warnings
2023-08-20 08:13:35 +02:00
Aleksander Machniak
1501ca4858
FIx PHP8 warning ( #9071 )
2023-07-23 16:29:43 +02:00
Ville Ojamo
25e4a65e24
Update about.php copyright year to 2023 ( #9050 )
...
Fixes #9049 .
2023-07-08 09:12:33 +02:00
Aleksander Machniak
54cdba28d9
Fix bug where inline images in a composed message could get lost on page refresh
2023-06-25 16:19:42 +02:00
Aleksander Machniak
9427ec1d35
Mouse-over menu on messages list ( #7141 )
2023-06-23 21:04:17 +02:00
Aleksander Machniak
e25608faae
Remove redundant comma
2023-06-08 20:43:40 +02:00
Aleksander Machniak
901fa1163b
Remove redundant if() condition
2023-06-06 13:00:59 +02:00
Aleksander Machniak
5723849978
Remove 'alt' attribute for contact photo images
...
Loading a contact photo may take a while, displaying the alt text looks ugly
and is redundant.
2023-06-04 10:29:14 +02:00
Aleksander Machniak
9d9912c12f
Fix bug where subfolders could loose subscription on parent folder rename ( #8892 )
2023-05-10 21:07:48 +02:00
Aleksander Machniak
a20445fcc5
Fix potential HTTP protocol version mismatch ( #8982 )
2023-05-07 16:37:17 +02:00
Aleksander Machniak
dbcdedfc69
Fix PHP8 warnings when using list_flags and list_cols properties by plugins ( #8998 )
2023-05-07 09:22:32 +02:00
Aleksander Machniak
fc3cd4484a
Fix QR code images for contacts with non-ASCII characters ( #9001 )
2023-05-04 07:34:55 +02:00
Aleksander Machniak
80c246de8b
Fix contact photo uploading
2023-05-02 14:57:32 +02:00
Aleksander Machniak
158e236b41
Fix PHP warnings
2023-04-10 12:47:16 +02:00
Camilo Sperberg
02cdea4e4b
Fix most common warnings RoundCube 1.6.1 ( #8901 )
2023-03-04 11:41:51 +01:00
Aleksander Machniak
77e96c7bc2
Fix duplicate recipients in "To" and "Cc" on reply ( #8912 )
2023-02-26 20:54:10 +01:00
Aleksander Machniak
06af033fef
Fix deleting attachments on reply/forward/draft edit ( #8868 )
2023-01-18 11:43:49 +01:00
Aleksander Machniak
e7b381b321
Fix missing mail composing textarea on reply/draft with a long plain text content ( #8866 )
2023-01-18 08:26:57 +01:00
Aleksander Machniak
a7f25ffb25
Update changelog
2023-01-01 13:08:06 +01:00
Shaun A. Johnson
3bd377c387
Added logic to purge messages from junk folder ( #8766 )
...
If delete_junk is on, end user expectation is that both single message delete as well as 'empty folder' operations should immediately delete messages from junk and bypass trash.
2023-01-01 13:03:04 +01:00
anton-labunsky
f1e44f7681
Fix SIGBUS raised in ImageMagick ( #8511 )
...
Use unique filename for temporary file, when image thumbnail is rendered.
2023-01-01 12:49:45 +01:00
Aleksander Machniak
d1d8caa70f
Fix bug where "Invalid skin name" error was logged on preferences save if there's only one skin ( #8825 )
2022-12-31 15:29:16 +01:00
Aleksander Machniak
3f8c4680c3
Fix bug array values could not be saved in utils/save_pref action ( #8781 )
2022-11-15 19:16:22 +01:00
Camilo Sperberg
0bfd9a4dc7
Address most common warnings in PHP >= 8.0.0 ( #8769 )
2022-11-11 13:14:59 +01:00
Aleksander Machniak
80404a8674
Store uploads metadata in a separate sql database table instead of a session ( #8415 )
2022-10-09 11:35:14 +02:00
Aleksander Machniak
e9ce8dc63d
Fix undefined array key warning
2022-09-29 20:29:08 +02:00
Aleksander Machniak
fd4fb61d8c
Fix regression where clicking on attachment would open and download the file
2022-08-28 11:56:04 +02:00
Aleksander Machniak
8c7911b9f2
Fix bug where setting 'Clear Trash on Logout' to 'all messages' didn't work ( #8687 )
2022-08-23 19:46:39 +02:00
Aleksander Machniak
8c487d9b56
Fix duplicate Reply-To header in mail preview
...
If there's Mail-Reply-To and Reply-To with the same value.
Also cleanup some code.
2022-08-14 10:30:02 +02:00
