Commit Graph

100 Commits

Author SHA1 Message Date
Michael Voříšek
6a53a1d853 Fix CS (whitespace, visibility) (#9297)
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa Fix single quotes CS (#9283)
* Fix "single_quote"

* fix "escape_implicit_backslashes"

* fix typo from f363481c

* fix single quotes in JS

* fix some minor JS CS

* fix CS v3.45.0
2023-12-31 16:36:55 +01:00
Edouard Vanbelle
0e4c35797d core: correct coding style warning (#9284)
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr>
2023-12-26 09:04:54 +01:00
Michael Voříšek
3e458fa5fd Refer native constants unambiguously (#9275)
* Fix "native_constant_invocation" CS

* "self_accessor" was fixed in 9269 PR

* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
e7d7e62146 Modernize more basic CS II (#9254)
* fix "integer_literal_case"

* fix "phpdoc_separation"

* fix "phpdoc_var_without_name"

* fix "operator_linebreak"

* fix "no_alias_language_construct_call"

* fix "list_syntax"

* fix "concat_space"

* fix "array_syntax"

* fix "binary_operator_spaces"

* fix "binary_operator_spaces" relaxed

* fix "phpdoc_types_order"

* fix "phpdoc_trim"

* fix "native_type_declaration_casing"

* fix "method_chaining_indentation"

* fix "phpdoc_no_package"

* fix "elseif"

* fix PHP CS Fixer config itself too

* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191 Modernize more basic CS (#9258)
* fix "yoda_style"

* fix "is_null"

* rm useless rule ignores

* add full "PhpCsFixer:risky" ruleset

* fix "implode_call"

* fix "no_alias_functions"

* fix "array_push"

* fix "long_to_shorthand_operator"

* fix "ternary_to_elvis_operator"

* fix "logical_operators"

* fix "fopen_flags"

* rename "returns" phpdoc tags to "return"

* fix "php_unit_construct"

* fix "function_to_constant"

* fix "php_unit_data_provider_return_type"

* fix "php_unit_set_up_tear_down_visibility"

* some safe "string_length_to_empty"

* fix "phpdoc_align"

* fix "phpdoc_no_alias_tag"

* fix "trailing_comma_in_multiline"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220 Fix and assert basic CS using CI (#9246)
* Assert CS using CI

* fix "single_blank_line_at_eof"

* fix "statement_indentation"

* fix "switch_case_semicolon_to_colon"

* fix "control_structure_braces"

* fix "statement_indentation"

* fix "no_whitespace_in_blank_line"

* fix "no_trailing_whitespace_in_comment"

* fix "no_trailing_whitespace"

* fix "single_space_around_construct"

* fix "spaces_inside_parentheses"

* fix "ternary_operator_spaces"

* fix "trim_array_spaces"

* fix "whitespace_after_comma_in_array"

* fix "cast_spaces"

* fix "unary_operator_spaces"

* fix "no_trailing_comma_in_singleline"

* fix "ordered_imports"

* fix "no_unused_imports"

* Check composer.json format

* fix CI job name

* file header comments are not phpdoc

* fix "phpdoc_indent"

* fix "braces_position"

* fix "phpdoc_types"

* fix "no_blank_lines_after_class_opening"

* fix "no_multiple_statements_per_line"

* fix "multiline_comment_opening_closing"

* fix "single_line_empty_body"

* fix "non_printable_character"

* fix "phpdoc_trim_consecutive_blank_line_separation"

* fix "include"

* fix "no_mixed_echo_print"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a Fix invalid phpdocs (#9252)
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
TheFirstGoodmaN
d9ec5be68d Add ssha256 password algo (#8479) 2022-03-20 10:52:15 +01:00
Aleksander Machniak
6cfca8dc9f Fix crypted password prefixes, use stronger blowfish algorithm 2021-11-06 10:15:22 +01:00
Aleksander Machniak
87c706c146 Password: Improve handling errors on executed commands (#8200) 2021-09-29 19:21:26 +02:00
Aleksander Machniak
53801e5fdc Password: Remove some deprecated algorithms and replacement variables 2021-09-25 15:33:20 +02:00
Aleksander Machniak
ee74fe806e Password: Add support for passwords based on PHP's password_hash() function (#7724)
i.e. Bcrypt, Argon2i, Argon2id
2021-09-25 15:18:59 +02:00
Aleksander Machniak
719b53f48f Password: Verify current password with IMAP (#8142) 2021-09-18 16:55:21 +02:00
Aleksander Machniak
7a269a2b84 Replace get_input_value() with get_input_string() where appropriate 2021-09-13 19:31:49 +02:00
Aleksander Machniak
d69613c4e4 Always throw an error when password hashing fails (#8145) 2021-08-01 10:39:56 +02:00
Aleksander Machniak
9f62e2d584 PHP 8.1: Drop use of (deprecated) mhash extension methods 2021-07-31 17:51:24 +02:00
Aleksander Machniak
a954f75bb5 Fix localization label use, again 2021-05-03 09:19:15 +02:00
Aleksander Machniak
c0ae5aad54 Cleanup a localization string, move href to the code 2021-05-03 09:03:57 +02:00
Aleksander Machniak
b4b50b87b3 Password: Set password_minimum_length to 8 by default (#8003) 2021-04-18 10:49:44 +02:00
Josh Soref
203f456620 Spelling (#8001) 2021-04-18 08:43:18 +02:00
Aleksander Machniak
ded37ff97c Introduce password_http_client config option 2021-01-16 09:06:28 +01:00
Aleksander Machniak
3bbb01fe13 PHP8 fixes, regression fixes 2020-12-13 12:14:15 +01:00
Aleksander Machniak
14a94cf0d7 PHP8 fixes, CS fixes, short array syntax, tests 2020-12-09 21:11:46 +01:00
fluteze
f6a0779c7e Password: Log error on unsupported hash method (#7735) 2020-11-23 08:52:38 +01:00
Aleksander Machniak
eb7636d491 Fixes in context of undefined variables, and code style 2020-08-16 10:29:42 +02:00
Aleksander Machniak
66fab8cdb2 CS fixes, Avoid usused variables, fixed minor bugs 2019-10-05 19:44:39 +02:00
Johannes Prösl
4644e3404f Adding ssha512 password_algorithm (#6805)
* Added SSHA512 method to the hash_password function

Basically a copy of the ssha method this case is compatible with the dovecot ssha512 settings so there is no doveadm needed alongside with roundcube to update ssha512 passwords.
2019-06-24 10:28:53 +02:00
Aleksander Machniak
57c67db029 Remove year(s) from copyright headers + some cleanup 2019-04-16 10:42:45 +02:00
Aleksander Machniak
a32d72b661 Password: Disallow control characters in passwords (#6547) 2018-12-14 11:36:23 +01:00
Aleksander Machniak
11216a1925 Changed 'password_charset' default to 'UTF-8' (#6522) 2018-11-16 13:22:13 +01:00
Aleksander Machniak
9babe138af Password: Change API for password checking
... for simpler implementation of strength indicator in future.

Also simplified configuration by removing password_check_strength and
adding password_minimum_score.
2018-11-11 09:02:50 +01:00
Aleksander Machniak
cd9ec7983b Password: README, Style, CS improvements, bump version, update changelog 2018-11-08 12:03:41 +01:00
PhilW
00946f1f57 give password plugin drivers more power
Allow password drivers more control over the entire password changeing
processes not just the save action. Allow them to perform old/new
password comparisons and also password strength checking.

*) allow password drivers override default password comparisons (eg
   new is not same as current) #6473
*) allow password drivers override default strength checks (eg allow
   for 'not the same as last x passwords')
*) allow separate password saving and strength drivers for use of
   strength checking services eg HaveIBeenPwned.com #5040
*) allow drivers to define password strength rules displayed to the
   user
*) rename password_require_nonalpha config option to
   password_check_strength to reflect new strength checking
   possibilities (added backwards compatibility)
2018-10-07 07:50:42 +01:00
Aleksander Machniak
b7d51573e4 Password: Fix bug where new users could skip forced password change (#6434) 2018-09-15 18:22:41 +02:00
Aleksander Machniak
bae58951bf Fix bug where password_dovecotpw_with_method setting could be ignored (#6436) 2018-09-09 10:30:06 +02:00
Aleksander Machniak
60922dc3d5 Password: Added password_username_format option (#5766) 2018-04-23 19:01:35 +02:00
Aleksander Machniak
fd9517655f Fix password form 2017-10-28 18:23:35 +02:00
Aleksander Machniak
315f78a65a Elastic: Use btn.submit instead of button.save classes for Save button in forms 2017-10-20 14:56:08 +02:00
Aleksander Machniak
f3ce401def Set 'propform' class for password change form table 2017-08-04 12:47:20 +02:00
Aleksander Machniak
9858c2a294 Merge branch 'master' into dev-elastic 2017-05-14 13:32:35 +02:00
Torkel Bjørnson-Langen
278b46a99d password plugin: better error message on constraint violation (#5727)
If the password policy on the ldap server is violated when changing
password, report error as "constraint violation" instead of the
misleading "connection error".

Only tested with OpenLDAP (v2.4).
2017-04-21 10:39:49 +02:00
Aleksander Machniak
8e6eb9fa72 Define 'save' class for password form button 2017-03-10 18:44:38 +01:00
Aleksander Machniak
e240e5f8dd CS fixes and update changelog 2016-11-27 14:27:23 +01:00
KaloNK
d41db75d82 Do not store passwords on disk - use proc_open instead of popen (#5531) 2016-11-27 14:20:58 +01:00
Aleksander Machniak
d59bf988e3 Fix style of Save button in password form (larry) 2016-11-07 13:43:21 +01:00
Aleksander Machniak
391d0d2039 Remove "@version @package_version@" 2016-11-01 18:26:47 +01:00
Aleksander Machniak
33addff305 assword: Added possibility to nicely handle password epiration from other plugins (#5468)
Squashed commit of the following:

commit 41283ecab18321201c3adfef8e964e2aa0dc2032
Author: Aleksander Machniak <alec@alec.pl>
Date:   Sat Oct 15 08:37:31 2016 +0200

    CS fixes after PR merge, renamed session variable

commit b4440a0c4d15c194619c003683ff0d36787f82a8
Merge: cf9f0d8 5dee181
Author: Aleksander Machniak <alec@alec.pl>
Date:   Sat Oct 15 08:26:04 2016 +0200

    Merge branch 'master' of https://github.com/ZiBiS/roundcubemail into ZiBiS-master

commit 5dee1812e7
Author: Zbigniew Szmyd <zbigniew.szmyd@linseco.pl>
Date:   Thu Oct 13 14:20:14 2016 +0200

    passing by session

commit 6ccb7e7d1d
Author: Zbigniew Szmyd <zbigniew.szmyd@linseco.pl>
Date:   Thu Oct 13 11:45:43 2016 +0200

    formatted passwdexpdatetime should be set in session data

commit a43f30fdfc
Author: Zbigniew Szmyd <zbigniew.szmyd@linseco.pl>
Date:   Thu Oct 13 11:10:06 2016 +0200

    _passwdexpwarning removed and expdatetime object is stored in session

commit 62ef852a11
Author: Zbigniew Szmyd <zbigniew.szmyd@linseco.pl>
Date:   Thu Oct 13 10:24:39 2016 +0200

    String concatenation is removed and expdatetime is passed via session
    data.

commit 2aea3a4e85
Author: Zbigniew Szmyd <zbigniew.szmyd@linseco.pl>
Date:   Wed Oct 12 10:20:58 2016 +0200

    Removing ppolicy plugin from my repository.

commit 8848c944ab
Author: Zbigniew Szmyd <zbigniew.szmyd@linseco.pl>
Date:   Tue Oct 11 11:32:37 2016 +0200

    little correction of variables names

commit 5266c89da9
Author: Zbigniew Szmyd <zbigniew.szmyd@linseco.pl>
Date:   Tue Oct 11 11:14:17 2016 +0200

    little corrections

commit c665b5c607
Author: Zbigniew Szmyd <zbigniew.szmyd@linseco.pl>
Date:   Tue Oct 11 10:31:05 2016 +0200

    A plugin to check LDAP password for expiration
2016-10-15 08:38:40 +02:00
Aleksander Machniak
7f4ab8c14a Merge pull request #5364 from ZiBiS/master
Password: LDAP PPolicy driver
2016-10-10 16:17:17 +02:00
Aleksander Machniak
9e129383a1 Improve randomness of password salts and random hashes (#5266) 2016-10-01 08:23:19 +02:00