Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Christian Mollekopf
e495fc73b5
Enigma: WOAT Support ( #8626 )
...
* Enigma: WOAT Support
* Fixed public key extraction from dns record
Co-authored-by: Aleksander Machniak <alec@alec.pl >
Co-authored-by: Christian Mollekopf <mollekopf@apheleia-it.ch >
2022-08-01 11:51:32 +02:00
Aleksander Machniak
f2688ba492
Use ?? operator where applicable
2021-09-21 19:12:06 +02:00
Aleksander Machniak
7a269a2b84
Replace get_input_value() with get_input_string() where appropriate
2021-09-13 19:31:49 +02:00
Aleksander Machniak
b7cbe9aa1b
Enigma: Optional support for passwordless keys ( #7265 )
2021-05-25 15:37:57 +02:00
Aleksander Machniak
22f6b89978
Fix PHP8 warnings
2021-03-06 08:58:58 +01:00
Aleksander Machniak
6b97651501
Enigma: Fix bug where signature verification could fail for non-ascii bodies ( #7919 )
2021-03-06 08:52:23 +01:00
Aleksander Machniak
8eb382b4ca
PHP8 fixes
2020-12-11 20:29:41 +01:00
Aleksander Machniak
e3416c9fc0
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-06 11:43:56 +01:00
Aleksander Machniak
545a1569f1
Steps -> Actions refactoring ( #7688 )
...
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
f95212d626
PHP8: More warnings fixed
2020-10-11 15:24:30 +02:00
Aleksander Machniak
eb7636d491
Fixes in context of undefined variables, and code style
2020-08-16 10:29:42 +02:00
Aleksander Machniak
b0d69503e0
Enigma: Support ECC key generation - when using GnuPG >= 2.1.7 ( #6853 )
2020-07-26 19:26:31 +02:00
Aleksander Machniak
66fab8cdb2
CS fixes, Avoid usused variables, fixed minor bugs
2019-10-05 19:44:39 +02:00
Aleksander Machniak
8fe12e2fad
Enigma: Fix "decryption oracle" bug [CVE-2019-10740] ( #6638 )
...
When composing mail (on reply/forward/edit) we decrypt content only
in the first "content part" of the message.
2019-05-11 16:15:46 +02:00
Aleksander Machniak
1ee7253ff2
Enigma: Fix error message when trying to encrypt with a revoked private key ( #6607 )
2019-05-11 09:03:32 +02:00
Aleksander Machniak
57c67db029
Remove year(s) from copyright headers + some cleanup
2019-04-16 10:42:45 +02:00
Aleksander Machniak
14cc3ec188
Add EFAIL-related warning in the code
2018-05-16 09:38:10 +02:00
Aleksander Machniak
f63150b256
Enigma: Fix key selection for signing
...
In some cases a public key of other user could be selected instead
of the sender's private key
2018-04-04 11:14:35 +02:00
Aleksander Machniak
5660489759
Fix decryption of messages encoded with non-ascii charset ( #5962 )
2017-09-27 08:57:22 +02:00
Aleksander Machniak
9028e77290
Enigma: Set micalg parameter to real hash algorithm used for signing
2017-03-06 10:57:20 +01:00
Aleksander Machniak
dd53a3d486
Enigma: Fix handling of messages with nested PGP encrypted parts ( #5634 )
2017-02-13 11:28:16 +01:00
Aleksander Machniak
d04cc14018
Enigma: Always use detached signatures ( #5624 )
2017-02-01 09:40:20 +01:00
Aleksander Machniak
62bcda35df
Enigma: Don't log bad-passphrase errors
2016-11-13 16:57:57 +01:00
Aleksander Machniak
ecefdca21d
GnuPG 2.1: Support password input on private key export
2016-10-23 15:51:28 +02:00
Aleksander Machniak
7829da358d
GnuPG 2.1: Fix importing newly generated (secret) keys using GnuPG 2.1
2016-09-25 13:05:21 +02:00
Aleksander Machniak
7df99b7399
Enigma: Fix signature verification with some IMAP servers, e.g. Gmail, DBMail ( #5371 )
2016-07-30 18:26:39 +02:00
Aleksander Machniak
a876748d84
Fix regression where password was continuously prompted on signing (an no enrypting)
2016-07-30 16:23:30 +02:00
Aleksander Machniak
88ed121f24
Enigma: Add possibility to export private keys ( #5321 )
2016-06-20 19:29:49 +02:00
Aleksander Machniak
3dd83804b4
Don't return false if keys directory does not exist
2016-06-12 13:11:16 +02:00
Aleksander Machniak
3f01232625
Enigma: Delete user keys when using deluser.sh script
2016-06-12 12:49:29 +02:00
Aleksander Machniak
ac1cd3719c
Enigma: Fix redundant list-secret-keys/list-public-keys calls on signing/encryption
2016-06-12 09:59:50 +02:00
Aleksander Machniak
f1c260b05f
Enigma: Implement PGP encryption and signing in one go ( #5302 )
...
Enigma: Display signature verification status for encrypted+signed messages (#5302 )
2016-06-07 12:29:17 +02:00
Aleksander Machniak
dcb7db2f8c
Enigma: Fix keys import from inside of an encrypted message ( #5285 )
2016-05-30 11:07:58 +02:00
Aleksander Machniak
96c3d84cdd
Enigma: Varius fixes and cleanup in code for attaching pubkeys
2016-04-02 10:35:17 +02:00
Kyle Francis
a9d399155d
Implemented attaching pub PGP key to outgoing messages.
2016-03-30 09:33:53 -04:00
Aleksander Machniak
007c9ddcb0
Enigma: Handle messages with text before an encrypted block ( #5149 )
2016-03-30 12:56:44 +02:00
Aleksander Machniak
4e6f3019f5
Enigma: Handle encrypted/signed content inside message/rfc822 attachments
2016-03-25 13:25:44 +01:00
Aleksander Machniak
5d49af37cc
Enigma: Disable format=flowed for signed plain text messages ( #1490646 )
2016-02-06 17:45:20 +01:00
Aleksander Machniak
5a30653024
Enigma: Don't display "bad password" warning when the password wasn't provided yet
2016-01-26 20:54:57 +01:00
Aleksander Machniak
8c626eec8a
Cleanup redundant variables
2016-01-26 16:59:40 +01:00
Aleksander Machniak
53fa08d8ae
Enigma: Code refactoring with better handling of encrypted-inside-encrypted (e.g. forwarded) and signed+ncrypted messages
2016-01-25 09:53:33 +01:00
Aleksander Machniak
c9e2ab488e
Enigma: Fix handling of encrypted + signed messages ( #1490632 )
2016-01-21 11:05:01 +01:00
