Michael Voříšek
a797873ef5
Fix "phpdoc_no_empty_return" CS ( #9302 )
...
* replace void with never return type
* replace "return void" phpdoc with native type in tests
* replace "return void" phpdoc with native type in rcube_addressbook
* replace "return void" phpdoc with native type in rcmail_oauth
* fix remaining
2024-01-05 19:03:58 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
b5637067eb
Bound upper PHP version in composer.json ( #9298 )
...
* bound upper PHP version
* improve/replace all relative includes
2024-01-02 13:33:50 +01:00
Michael Voříšek
86eda9f7ed
Fix "increment_style" CS ( #9296 )
...
* Fix "increment_style" CS
* use "post" increment style
2024-01-01 12:23:21 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Edouard Vanbelle
0e4c35797d
core: correct coding style warning ( #9284 )
...
Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr >
2023-12-26 09:04:54 +01:00
Michael Voříšek
740267fac0
Lint JS files using eslint and normalize JS indentation ( #9280 )
...
* Lint JS using eslint
* Fix "comma-spacing"
* Fix "semi"
* Fix indent to unified 4 spaces as for PHP
* ignore symlinked public_html/* files
2023-12-23 17:08:32 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
a9167a0d2f
Fix "static_lambda" CS ( #9276 )
2023-12-20 20:01:00 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
8c82b29baf
Assert expected data types in tests ( #9268 )
...
* fix test skips for local testing
* fix Actions_Mail_Search tests when run /w non-UTC default TZ
* improve tests before PHP CS Fixer is run
* fix "php_unit_strict"
2023-12-17 15:03:08 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Aleksander Machniak
77ae91f213
CS fixes in .php.dist files
2023-12-17 12:02:14 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
93946f4ca7
Fix "self_accessor" PHP CS Fixer rule ( #9269 )
2023-12-17 09:44:43 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Michael Voříšek
0ab210ac1b
Fix Sieve scripts comment parse with CRLF ( #9249 )
2023-12-10 15:43:24 +01:00
Pablo Zmdl
edf2a95fd8
Fix saving other encryption settings besides enigma's ( #9240 )
...
Previously, if the enigma plugin was enabled, it wasn't possible to save
the option whether Roundcube should use Mailvelope's main keyring
(`mailvelope_main_keyring`), because this code overwrote the whole array
for the "encryption"-section on saving. That is now fixed.
2023-12-05 19:33:16 +01:00
Aleksander Machniak
965fd90284
Browser Tests: The last attempt on mobile menu issues
...
If this does not work I give up. Tests work on my computer, but not on GA,
and I don't know really why.
2023-11-26 18:29:26 +01:00
Aleksander Machniak
a31cb3d166
Enigma: Fix finding of a private key when decrypting a message using GnuPG v2.3
...
Additional fix for a case when sender's public key is in the keyring
2023-11-22 18:44:51 +01:00
Aleksander Machniak
7b616863b2
Enigma: Fix finding of a private key when decrypting a message using GnuPG v2.3
2023-11-22 14:33:20 +01:00
Aleksander Machniak
cfd55ca010
Fix PHP8 warnings
2023-11-13 20:01:49 +01:00
Aleksander Machniak
2824e16ffe
Browser Tests: Attempt to fix a flaky test
2023-10-30 09:50:55 +01:00
Aleksander Machniak
941918bb26
Fix UI issue when dealing with an invalid managesieve_default_headers value ( #9175 )
2023-10-21 16:06:20 +02:00
onozaty
3a99bc3799
Fix deactivated and activated messages being reversed in ja_JP. ( #9176 )
2023-10-20 19:10:24 +02:00
Aleksander Machniak
5ebaf19c32
Fix PHP warnings ( #9174 )
2023-10-20 19:00:04 +02:00
Aleksander Machniak
a11270bdb5
Fix javascript error when relational or spamtest extension is not enabled ( #9139 )
2023-10-01 14:56:15 +02:00
Aleksander Machniak
c38c75c0d4
Fix PHP warning ( #9125 )
2023-09-14 08:48:21 +02:00
Aleksander Machniak
a815867bca
Fix deprecated use of ldap_connect() in password's ldap_simple driver ( #9060 )
2023-08-20 08:56:30 +02:00
Aleksander Machniak
ac3ce662e0
Fix PHP8 deprecation warning in the reconnect plugin ( #9083 )
...
Also improve performance by loading the plugin config file when needed.
2023-08-13 14:42:39 +02:00
Aleksander Machniak
c5022b9e52
Update jQuery-UI to version 1.13.2 ( #9041 )
2023-07-08 10:10:38 +02:00
Aleksander Machniak
f60464912a
Fix PHP8 errors
2023-06-30 18:30:12 +02:00
Aleksander Machniak
67cf54881d
Managesieve: Fix PHP fatal error when connection fails
2023-06-30 15:01:58 +02:00
Aleksander Machniak
ed430f0577
Fix PHP8 warnings
2023-06-12 12:14:11 +02:00
Aleksander Machniak
44a4496302
Cleaner code
2023-05-29 08:00:31 +02:00
Aleksander Machniak
3188679bdd
Return early if hashing of password fails
2023-05-28 15:14:42 +02:00
Matwey V. Kornilov
7d13b337db
Some minor improvements for password plugin ( #8402 )
...
* plugins/password/ldap_simple: Allow LDAP access using LDAP URI
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru >
* plugins/password/ldap_simple: Allow LDAP SASL binding when search user DN
This may be particularly useful when UNIX socket connection is used,
or TLS certificate-based authentication is performed.
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru >
* plugins/password/ldap_simple: Allow LDAP SASL bind for admin
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru >
---------
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru >
2023-05-28 10:38:02 +02:00
Aleksander Machniak
6747ac1f68
Fix bug where some mail headers didn't work in cmd_learn driver of markasjunk plugin ( #9005 )
2023-05-16 11:19:02 +02:00
Nik Soggia
5f9004d8c2
Fix insecure shell command params handling in cmd_learn driver of Markasjunk plugin
2023-05-15 19:21:59 +02:00
Aleksander Machniak
295c2d743f
Fix typos in localization ( #8979 , #8995 )
2023-05-07 09:36:04 +02:00
Aleksander Machniak
0266f7a3bf
ACL: Set default of 'acl_specials' option to ['anyone'] ( #8911 )
2023-04-10 09:39:12 +02:00
Philip Weir
9672242de4
Markasjunk: Add SpamAssassin v4 compatibility ( #8975 )
2023-04-09 18:31:22 +02:00
Aleksander Machniak
2d5f7aa9f5
Update localization
2023-04-09 18:30:38 +02:00
Aleksander Machniak
5526aa99ab
Add List-ID to the list of headers for creating new sieve-filters ( #8307 )
2023-03-26 18:49:09 +02:00
Aleksander Machniak
ff72cb078d
Managesieve: Support :encodeurl (RFC 5435) ( #8917 )
2023-03-26 12:40:25 +02:00
Asterios "Aster" Bandis
9c2b459b8c
Update Greek localization (from Transifex) ( #8937 )
...
* Pull new Greek translations from Transifex
* Pull new Greek translations from Transifex
Replace the "Greeklish" folder name with Greek characters
2023-03-04 09:26:25 +01:00
Aleksander Machniak
85973477f4
Switch help_source location to https:// ( #8898 )
2023-02-20 07:37:33 +01:00
Aleksander Machniak
642b772087
Fix Help plugin menu ( #8898 )
2023-02-19 14:52:44 +01:00
Aleksander Machniak
16e523d1e7
Fix so an email address with name is supported as input to the managesieve notify :from parameter ( #8918 )
2023-02-19 14:28:44 +01:00
