Commit Graph

194 Commits

Author SHA1 Message Date
Aleksander Machniak
4f915b5476 Fix PHP deprecation warnings when handling an invalid BODYSTRUCTURE (#9896) 2025-07-05 15:30:44 +02:00
Aleksander Machniak
c32a86cda2 Fix bug where a wrong SPECIAL-USE folder could have been detected, if there were more than one per-type (#9781) 2025-04-20 12:40:14 +02:00
Aleksander Machniak
4a9516b2c9 Fix decoding of attachment names encoded using both RFC2231 and RFC2047 standards (#9725) 2025-02-02 14:05:31 +01:00
Aleksander Machniak
a34f716051 Reset internal cache in appropriate places to be on a safe side 2024-12-12 13:49:36 +01:00
Aleksander Machniak
b206cbc87a IMAP: Partial support for ANNOTATE-EXPERIMENT-1 extension (RFC 5257) 2024-12-11 15:03:04 +01:00
Aleksander Machniak
5c38c67287 Fix PHP fatal error when parsing some malformed BODYSTRUCTURE responses (#9689) 2024-11-17 14:45:42 +01:00
Pablo Zmdl
8cc559a6f0 Fix getting IMAP vendor name (#9654)
In some cases, the array's keys where upper case, and the previous code
produced a warning and resulted in an empty string, even though the
name was present.
2024-09-29 11:51:53 +02:00
Aleksander Machniak
b66f7aabda Fix PHP8 warning 2023-12-13 19:55:35 +01:00
Michael Voříšek
793664f568 Fix invalid phpdocs (#9252)
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-13 19:55:05 +01:00
Aleksander Machniak
81ac3c342a Fix cross-site scripting (XSS) vulnerability in setting Content-Type/Content-Disposition for attachment preview/download
Thanks to rehme.infosec for reporting the issues.
2023-11-04 17:52:34 +01:00
Denys Klymenko
efd5842dcb Fix PHP fatal error on folder read-only check (#9190) 2023-10-29 12:53:07 +01:00
Aleksander Machniak
11ec814a80 Fix bug where images attached to application/smil messages weren't displayed (#8870) 2023-10-21 18:15:42 +02:00
Aleksander Machniak
522562a4ab Fix PHP8 fatal error when parsing a malformed BODYSTRUCTURE (#9171) 2023-10-17 20:03:29 +02:00
Aleksander Machniak
33ff28080c Fix PHP8 warnings 2023-08-20 08:34:59 +02:00
Aleksander Machniak
eaef7b3e4b Fix PHP8 warnings 2023-07-12 18:56:17 +02:00
Adrien Beau
e5c5676fcc Fix sort_folder_comparator (#9057)
In case $path2 is longer than $path1, and all folders in $path1 are
equal to the corresponding folder in $path2 (in other words: $path2 is a
subfolder of $path1), sort_folder_comparator currently considers them
equal because it stops comparing when it reaches the end of $path1.

This breaks the ordering done by uasort() above, and breaks code that
relies on the folder list being sorted, notably the folders settings
page.
2023-07-09 19:53:09 +02:00
Aleksander Machniak
7a3c1b4d68 Fix potential PHP fatal error when opening a message with message/rfc822 part (#8953) 2023-07-09 14:49:38 +02:00
Aleksander Machniak
31b1f4aea9 Fix bug where subfolders could loose subscription on parent folder rename (#8892) 2023-05-10 21:08:26 +02:00
Aleksander Machniak
872435e0de Fix PHP 8.1 warnings, make BODYSTRUCTURE parser less fragile (#8803) 2022-11-28 20:35:45 +01:00
Aleksander Machniak
6807820eed Fix PHP warning (#8794) 2022-11-26 10:18:39 +01:00
Aleksander Machniak
eff5130f6f Fix a PHP warning (#8743) 2022-11-11 13:26:49 +01:00
Aleksander Machniak
8af9cf93b6 Fix various PHP 8.2 warnings 2022-08-06 09:22:32 +02:00
Michael Steininger
d12efe4eaf Fix usage of "break" (#8624) 2022-07-21 18:38:45 +02:00
Aleksander Machniak
f23aaed10e Remove use of unreliable charset detection (#8344) 2022-04-09 14:13:50 +02:00
Aleksander Machniak
bfef4691cf Fix PHP8 warning (#8466) 2022-03-12 09:38:54 +01:00
Aleksander Machniak
78b3049ce5 Fix PHPDoc 2022-02-18 19:19:07 +01:00
Aleksander Machniak
06b6089767 Fix handling of RFC2231-encoded attachment names inside of a message/rfc822 part (#8418) 2022-01-29 10:16:48 +01:00
Aleksander Machniak
f429b26810 Fix various PHP8 warnings (#8392) 2022-01-11 19:04:24 +01:00
Aleksander Machniak
81cc8ac0e0 Purge also subfolders of Trash (and/or messages in them) on logout (#1037) 2021-10-09 16:55:28 +02:00
Aleksander Machniak
f2688ba492 Use ?? operator where applicable 2021-09-21 19:12:06 +02:00
Aleksander Machniak
63056eb803 Fix PHP8 warnings (#8175) 2021-09-11 08:59:15 +02:00
Aleksander Machniak
4d233b5c65 Fix strpos(): empty needle warning (#8184) 2021-08-29 18:27:06 +02:00
Aleksander Machniak
e2187b8f2d Fix various PHP 8.1 warnings 2021-08-27 16:52:54 +02:00
Aleksander Machniak
6ff862d7d8 Fix a couple of PHP8 warnings (#8175) 2021-08-25 18:57:50 +02:00
Aleksander Machniak
9caab5f701 Fix PHP8 warnings 2021-07-16 12:57:46 +02:00
Thomas Bruederli
861be4606b Fix phpdoc error 2021-06-21 20:56:12 +02:00
Aleksander Machniak
094ef387e9 Fix bug where plus characters in attachment filename could have been ignored (#8074) 2021-05-28 11:34:20 +02:00
Josh Soref
203f456620 Spelling (#8001) 2021-04-18 08:43:18 +02:00
Aleksander Machniak
dd6aefe1fd Fix bug where imap_conn_options settings were ignored (#7912) 2021-03-04 19:14:28 +01:00
hefee
8ef57a4173 Add 'reconnect' plugin to retry IMAP connection (#7844)
* Make storage_connect hook ready to be usable for reconnect plugins.
* Add reconnect plugin to retry to login into IMAP server.

Co-authored-by: Sandro Knauß <hefee@debian.org>
2021-02-06 16:46:21 +01:00
Aleksander Machniak
17ae3693c3 PHP8 fixes + fix fatal error when refreshing compose page in forward-as-attachment state 2020-12-18 19:27:25 +01:00
Aleksander Machniak
3bbb01fe13 PHP8 fixes, regression fixes 2020-12-13 12:14:15 +01:00
Aleksander Machniak
61a5ade872 PHP8 fixes, short array syntax 2020-12-12 16:20:14 +01:00
Aleksander Machniak
8eb382b4ca PHP8 fixes 2020-12-11 20:29:41 +01:00
Aleksander Machniak
f4ed1024dc PHP8 fixes, CS fixes, short array syntax, tests 2020-12-02 20:15:00 +01:00
Aleksander Machniak
7e5301f636 CS fixes, short array syntax, PHP8 fixes, tests 2020-11-28 18:52:36 +01:00
Aleksander Machniak
596004beb3 More actions tests, code improvements 2020-11-07 12:54:12 +01:00
Aleksander Machniak
545a1569f1 Steps -> Actions refactoring (#7688)
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
f95212d626 PHP8: More warnings fixed 2020-10-11 15:24:30 +02:00
Aleksander Machniak
bde383d051 PHP8: Fix various issues
for now only these I found by running our unit tests, there will be much more
2020-10-11 10:32:41 +02:00