Aleksander Machniak
94fd5a0f80
CS fixes (for the new fixer version rules)
2025-02-23 11:51:27 +01:00
Michael Voříšek
a30e0ad438
Infer file/line location in rcube::raise_error() from backtrace ( #9422 )
...
* \n\s+'file' => __FILE__,
* \n\s+'line' => __LINE__,
* 'line' => __LINE__, 'file' => __FILE__,
* 'file' => __FILE__, 'line' => __LINE__,
* rest
* more
* improve cs
* more cs
* revert rcube_utils::preg_error changes
* impl file/line from backtrace
* Revert "revert rcube_utils::preg_error changes"
2024-04-21 11:48:35 +02:00
Aleksander Machniak
e086c2c97c
Code improvements
2024-04-07 09:20:52 +02:00
Aleksander Machniak
15c1228cf3
Code improvements
2024-03-24 08:52:17 +01:00
Aleksander Machniak
5ed3b29a0a
Code improvements
2024-03-16 21:30:10 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
34500a4fa4
Fix "missing return statement" phpstan errors
2024-01-27 19:07:52 +01:00
Aleksander Machniak
c47484cf3d
Small improvement to rcube_user::get_identity()
2024-01-26 19:20:37 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
93946f4ca7
Fix "self_accessor" PHP CS Fixer rule ( #9269 )
2023-12-17 09:44:43 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Aleksander Machniak
80404a8674
Store uploads metadata in a separate sql database table instead of a session ( #8415 )
2022-10-09 11:35:14 +02:00
Aleksander Machniak
f2688ba492
Use ?? operator where applicable
2021-09-21 19:12:06 +02:00
Aleksander Machniak
cb37d14c5c
Support responses (snippets) in HTML format ( #5315 )
2021-08-28 19:17:19 +02:00
Aleksander Machniak
8cf8a47381
new_user_identity: Make sure email_list includes the main user email ( #7085 )
2021-02-21 10:20:52 +01:00
Aleksander Machniak
b7ac23ea5d
new_user_identity: Fix missing password for user-specific LDAP operations ( #7667 )
2021-02-07 09:55:41 +01:00
Aleksander Machniak
3bbb01fe13
PHP8 fixes, regression fixes
2020-12-13 12:14:15 +01:00
Aleksander Machniak
f4ed1024dc
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-02 20:15:00 +01:00
Jacques Belin
8ad73423d4
Plugin API: Added 'preferences' parameter to 'user_create' hook ( #7692 )
2020-11-21 09:05:59 +01:00
Aleksander Machniak
545a1569f1
Steps -> Actions refactoring ( #7688 )
...
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
a5c2b4360c
Fixes in context of undefined variables, and code style
2020-08-15 12:13:31 +02:00
Aleksander Machniak
66fab8cdb2
CS fixes, Avoid usused variables, fixed minor bugs
2019-10-05 19:44:39 +02:00
Aleksander Machniak
1afa46d28d
PHPDoc and CS fixes
2019-08-25 14:15:09 +02:00
Aleksander Machniak
57c67db029
Remove year(s) from copyright headers + some cleanup
2019-04-16 10:42:45 +02:00
Aleksander Machniak
641a67fe75
Elastic: Fix unintentional layout preference overwrite ( #6613 )
...
This is actually skin-independent mechanism that prevents overwriting
of skin-specific preferences by ajax requests (that until now were
not aware of skin config).
2019-02-08 11:19:09 +01:00
Aleksander Machniak
55e99398e1
Fix possible information leak - add more strict sql error check on user creation ( #6125 )
2018-01-11 16:13:13 +01:00
Aleksander Machniak
76170baac0
Fix bug where it wasn't possible to set timezone to auto-detected value ( #5782 )
2017-06-03 19:00:00 +02:00
Aleksander Machniak
d1cf69562f
CS fixes and return values fixes
2017-04-27 09:58:11 +02:00
Aleksander Machniak
e160e48069
Fix undesired effects when postgres database uses different timezone than PHP host ( #5708 )
...
Allow passing DateTime variables as query arguments. Their value will
be converted to date/time input string in format specific to the database type
(with timezone on postgres).
2017-04-03 12:06:23 +02:00
Aleksander Machniak
dfd19206a4
sizeof() -> count()
2017-02-06 13:49:29 +01:00
Aleksander Machniak
9e129383a1
Improve randomness of password salts and random hashes ( #5266 )
2016-10-01 08:23:19 +02:00
Aleksander Machniak
a15d877ba8
Added brute-force attack prevention via login rate limit ( #1490566 )
2015-11-11 18:53:43 +01:00
Aleksander Machniak
26a00e76be
Fix race-condition in saving user preferences and loading plugin config ( #1490431 )
2015-06-16 11:39:55 +02:00
Aleksander Machniak
a958748947
CS fixes
2015-06-07 15:26:33 +02:00
Aleksander Machniak
0c08b04778
Fix issues when using moduserprefs.sh without --user argument ( #1490399 )
2015-05-21 10:19:46 +02:00
Thomas Bruederli
e2fb340289
Remove obsolete mt_srand() calls
2015-03-12 09:59:47 +01:00
Thomas Bruederli
a74d023903
Generate random hash for the per-user local storage prefix ( #1490279 ); only unserialize user prefs once
2015-03-12 09:48:32 +01:00
Aleksander Machniak
692011df7f
Extend list_emails() to optionally return only default identity
2014-11-27 06:24:42 -05:00
Aleksander Machniak
2f46789081
Added rcube_user::list_emails() method with better performance than list_identities()
...
which should be used always if we want only all user email addresses (with names)
2014-11-27 10:08:55 +01:00
Aleksander Machniak
83a64265a7
Fixes for Oracle
2014-09-15 11:37:42 +02:00
Aleksander Machniak
34a0902089
Use consistent column/table quoting in sql queries
2014-09-12 14:37:51 +02:00
Aleksander Machniak
54185837c8
Make identity name field optional ( #1489510 )
...
Get rid of unhelpful error message.
2014-04-28 09:38:07 +02:00
Thomas Bruederli
e59471fcb9
Make sure prefs always is a valid array (otherwise causes fatal errors if language if not set)
2014-01-07 09:48:55 +01:00
Aleksander Machniak
51fe045a04
Fix deprecated function usage
2013-11-18 11:08:20 +01:00
Thomas Bruederli
85e60ada15
First version of the local storage compose data saving feature; some behavioral improvements and encrytion are still to be added
2013-11-10 14:04:33 +01:00
