Aleksander Machniak
f7d8852d17
Use str_starts_with() where applicable
2025-03-30 11:32:38 +02:00
Aleksander Machniak
a9b1ca34f3
Update min PHP version check, cleanup outdated checks/comments
2025-02-23 11:18:50 +01:00
Michael Voříšek
1e360999b2
Use composer autoloader for bundled plugins testing ( #9412 )
...
* use fixed "roundcube/plugin-installer"
* Use composer autoloader for plugins testing
* cherrypick remaining from 9241 related with testing
* minor legacy autoload improvements
2024-04-11 18:28:46 +02:00
Aleksander Machniak
8adb052d35
Code improvements, PHPDoc fixes
2024-03-30 14:17:34 +01:00
Aleksander Machniak
a1f39f47b7
Fix phpstan errors
2024-02-10 19:20:04 +01:00
Michael Voříšek
332c165d28
Fix some basic JS CS ( #9328 )
...
* fix "nonblock-statement-body-position" (fixed already)
* fix "comma-dangle"
* fix "no-regex-spaces"
* fix "new-parens"
* fix "object-curly-newline"
* fix "object-property-newline"
* fix "spaced-comment" semimanually
* fix "no-constant-condition" manually
* fix "unicorn/no-hex-escape"
* fix "unicorn/escape-case"
* fix "quote-props"
* fix "no-whitespace-before-property" - fix bug/typo
* fix "unicorn/empty-brace-spaces"
* fix "keyword-spacing"
* fix "dot-notation"
* fix "no-return-assign" manually
* fix "padding-line-between-statements"
* fix "key-spacing"
* fix "no-else-return" semimanually
* fix some "no-undef"
* fix case cs
* Revert "fix "padding-line-between-statements""
* improve switch/case format I.
* improve switch/case format II.
regex: (^ *(break|return).*)\n *(\n)
* fix safe "eqeqeq"
* fix "radix"
* fix v3.49.0 CS (static providers)
* fix "string_implicit_backslashes" in php files
* fix comments align
* fix test static providers
* fix stan
* disable "final_internal_class" rule
2024-02-06 08:28:19 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Michael Voříšek
ff2d721680
Fix more CS whitespace ( #9318 )
...
* fix "no_useless_else" manually
* fix some "blank_line_before_statement"
* two manual changes
* Revert "fix some "blank_line_before_statement""
This reverts commit 2cc857c00e .
* fix some "blank_line_before_statement" using patched fixer (after "}" only)
* fix continue/break too
2024-01-25 19:17:29 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Aleksander Machniak
cca23b24ce
Small phpdoc cleanup
2024-01-21 15:50:33 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
* fix single quotes in JS
* fix some minor JS CS
* fix CS v3.45.0
2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd
Refer native constants unambiguously ( #9275 )
...
* Fix "native_constant_invocation" CS
* "self_accessor" was fixed in 9269 PR
* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
a9167a0d2f
Fix "static_lambda" CS ( #9276 )
2023-12-20 20:01:00 +01:00
Aleksander Machniak
9f5cc3e9fa
Accept null as input to parse_bytes()
2023-12-18 08:04:55 +01:00
Michael Voříšek
aa3803eaee
Return integer|false from parse_bytes() function ( #9271 )
...
* Return integer from parse_bytes() function
* fix rebase
* Return false from parse_bytes() function if input is invalid
* allow null until strongly typed
2023-12-18 07:51:07 +01:00
Aleksander Machniak
9729ff9418
Fix warning on parse_bytes(null) call
2023-12-17 14:18:55 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
cgzones
12dea728f8
Ignore mbstring.func_overload in PHP 8 ( #9227 )
...
The feature `mbstring.func_overload` is deprecated since PHP version 7.2 and removed since 8.0.0
(see https://www.php.net/manual/en/mbstring.overload.php ).
Skip trying to set it for PHP version 8, e.g. to avoid failures with the sloppy comparison hardening of Snuffleupagus
(https://snuffleupagus.readthedocs.io/config.html#prevent-sloppy-comparison ):
2023-12-03 13:11:22 +01:00
Aleksander Machniak
94c78b350e
Fix so install/update scripts do not require PEAR ( #9037 )
2023-07-15 18:43:00 +02:00
Aleksander Machniak
251a7ae0e7
Don't require specific error_reporting
...
I think we're E_STRICT and E_NOTICE free now.
2023-07-07 09:13:04 +02:00
Aleksander Machniak
42f9cdceba
Master is 1.7-git
2022-06-23 19:02:23 +02:00
Aleksander Machniak
41d1873f38
Fix in_array_nocase() regression
2021-12-17 18:58:13 +01:00
Aleksander Machniak
c331431521
Fix some PHP8 compatibility issues ( #8363 )
2021-12-17 18:54:37 +01:00
Aleksander Machniak
0d4a395464
Fix PHP 8.1 deprecation warnings
2021-07-31 07:53:14 +02:00
Aleksander Machniak
b4fd75d6c1
Master is 1.6-git now
2021-07-25 09:08:20 +02:00
Aleksander Machniak
5d2668a260
Bring the old error_reporting setting back
2021-01-23 10:02:41 +01:00
Aleksander Machniak
5aa0d09def
Add array_first() helper, fix some code issues
2020-12-20 09:44:17 +01:00
Aleksander Machniak
8b83d29f24
PHP8 fixes, do not require specific error_reporting setting anymore
2020-12-19 10:01:10 +01:00
Aleksander Machniak
12547ccf01
Require php-intl extension, get rid of Net_IDNA2, PHP8 fixes, short array syntax
...
Net_IDNA2 is not compatible, and Intl is a bundled ext since PHP 5.3.
Fixed some regressions.
2020-12-13 10:21:52 +01:00
Aleksander Machniak
c98059e43d
Short array syntax, CS fixes, tests
2020-11-26 20:34:35 +01:00
Aleksander Machniak
a5c2b4360c
Fixes in context of undefined variables, and code style
2020-08-15 12:13:31 +02:00
Aleksander Machniak
9f1d185c44
Master is 1.5-git now
2019-10-27 09:45:15 +01:00
Aleksander Machniak
3b4d9f3fb5
PHPDoc updates
2019-08-25 19:24:08 +02:00
Aleksander Machniak
0a0ad2c9b7
Switch to IDNA2008 variant ( #6806 )
...
After switching IDNA_NONTRANSITIONAL_TO_ASCII on, switch to
IDNA2008 variant in Net_LDAP2. Add test, update changelog.
2019-06-16 12:03:27 +02:00
Aleksander Machniak
57c67db029
Remove year(s) from copyright headers + some cleanup
2019-04-16 10:42:45 +02:00
PhilW
e024f133fa
give all temp files a constant prefix
2018-11-06 07:11:04 +00:00
Aleksander Machniak
3d0b2cd3ce
Pass PEAR errors to rcube::raise_error(), small CS improvements
2018-05-27 08:50:42 +02:00
Aleksander Machniak
30ab2eec5f
Remove function_exists() checks for mbstring functions
2018-05-25 10:10:02 +02:00
Aleksander Machniak
c0b9025215
Remove sample PHP configuration from .htaccess and .user.ini files ( #5850 )
...
Moved to https://github.com/roundcube/roundcubemail/wiki/Installation#php-configuration
2018-04-21 20:17:17 +02:00
Aleksander Machniak
1058924e21
Move some framework classes to sub-directories
2018-03-03 17:46:59 +01:00
Aleksander Machniak
5101cfc67a
Bump version to 1.4-git
2017-05-15 11:34:43 +02:00
Thomas Bruederli
f78e2a4367
Add 1.3-beta milestone + update copyright year
2017-01-03 18:24:34 +01:00
Aleksander Machniak
c3fc072d97
Remove code related to magic_quotes_* and register_globals
...
...they do not exist in PHP 5.4 which we now require.
2016-07-29 13:34:50 +02:00
Aleksander Machniak
6626328e7c
We already require PEAR, so it's not needed to check if PEAR class exists.
...
Sooner or later it will fail if PEAR does not exist, so better to do this sooner.
2016-07-21 09:35:52 +02:00
Raoul Bhatia
7122df719d
Translate PHP namespaces into directories
2016-06-20 20:16:11 +02:00
Aleksander Machniak
9634169647
Bump version number to 1.3-beta
2016-05-02 14:37:39 +02:00