Philip Weir
db2e201788
Contact import improvements ( #9431 )
...
* contact import: correct mismapped fields
* contacts: remove im:other field from UI, it does not exist in the vCard
* vcard: add some more maps for common vcard types to roundcube types
* contact import: list all possible roundcube contact fields in csv import UI, remove hard coded $local_map
* add SORT_LOCALE_STRING flag
* fix typos
* remove unwanted label
* move field list to csv2vcard
* move rcube_csv2vcard::list_fields to rcmail_action_contacts_import::list_fields as it relies on rcmail_action_contacts
* use single field map for csv2vcard imports, remove hardcoded version
* fix test
* small cs fix
* reformat csv2vcard.inc
* fix failing test
* restore existance check
* fix failing test again
2025-10-08 13:36:57 +02:00
Aleksander Machniak
f37a959197
Fix new phpstan errors
2025-03-24 18:14:40 +01:00
Aleksander Machniak
749eb3853d
CS fix
2024-11-03 10:40:17 +01:00
Aleksander Machniak
55881d35ae
Fix PHP 8.4 deprecation warning on str_getcsv() use
2024-11-03 10:33:37 +01:00
Aleksander Machniak
20d9edce04
Code improvements
2024-03-31 19:22:56 +02:00
Philip Weir
ed47e11319
csv2vard: store labels by key not value ( #9394 )
2024-03-24 08:00:38 +01:00
Aleksander Machniak
a1f39f47b7
Fix phpstan errors
2024-02-10 19:20:04 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
34500a4fa4
Fix "missing return statement" phpstan errors
2024-01-27 19:07:52 +01:00
Michael Voříšek
4ee79b9e84
fix "explicit_string_variable" ( #9315 )
2024-01-22 08:05:59 +01:00
Michael Voříšek
54f4aa33f9
Fix CS - imports ( #9316 )
...
* fix Tests\Browser\TestCase imports
* fix remaining imports
* fix PHPUnit\Framework\TestCase imports
* import GuzzleHttp\Client
* fix remaining
* "php_unit_method_casing" is not todo
* fix "single_line_comment_spacing"
* fix 2nd commit done using older fixer
2024-01-21 19:13:31 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa
Fix single quotes CS ( #9283 )
...
* Fix "single_quote"
* fix "escape_implicit_backslashes"
* fix typo from f363481c
2023-12-31 16:36:55 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
f23aaed10e
Remove use of unreliable charset detection ( #8344 )
2022-04-09 14:13:50 +02:00
Aleksander Machniak
f2688ba492
Use ?? operator where applicable
2021-09-21 19:12:06 +02:00
Josh Soref
203f456620
Spelling ( #8001 )
2021-04-18 08:43:18 +02:00
Aleksander Machniak
5ac44fd4ed
PHPDoc fixes
2021-02-28 11:58:27 +01:00
Thomas P
98b105aed8
Do not remove commas in groups/categories list ( #7690 )
2021-02-20 10:10:14 +01:00
Aleksander Machniak
f4ed1024dc
PHP8 fixes, CS fixes, short array syntax, tests
2020-12-02 20:15:00 +01:00
Aleksander Machniak
37d75d96a3
Short array syntax, CS fixes
2020-11-27 19:51:33 +01:00
Thomas P
57a77dbace
Fixing typo ( #7689 )
...
Typo for work_dept value
2020-11-01 21:12:44 +01:00
PhilW
7b2f135bc6
add field mapping step to csv contact import
2020-10-11 10:25:30 +01:00
Aleksander Machniak
bde383d051
PHP8: Fix various issues
...
for now only these I found by running our unit tests, there will be much more
2020-10-11 10:32:41 +02:00
Aleksander Machniak
a5c2b4360c
Fixes in context of undefined variables, and code style
2020-08-15 12:13:31 +02:00
Aleksander Machniak
e7ebff56df
PHPDoc fixes
2019-09-30 20:43:07 +02:00
Aleksander Machniak
57c67db029
Remove year(s) from copyright headers + some cleanup
2019-04-16 10:42:45 +02:00
Aleksander Machniak
35e2bffb90
Support simple field labels (e.g. LetterHub examples) in csv imports ( #6541 )
2018-12-29 14:25:38 +01:00
Aleksander Machniak
a958748947
CS fixes
2015-06-07 15:26:33 +02:00
Aleksander Machniak
b262e12964
Fix import of contacts with multiple email addresses from Google-csv format ( #1490178 )
2014-12-08 09:19:17 +01:00
Aleksander Machniak
f864495b7b
Fix import of multiple contact email addresses from Outlook-csv format ( #1490169 )
2014-12-01 14:26:52 +01:00
Aleksander Machniak
25fb9732a0
Fix so all unknown email addresses from Google csv format are imported ( #1490159 )
2014-11-26 18:49:31 +01:00
Aleksander Machniak
bb1398a54e
Fix import of multiple contact groups from Google-csv format ( #1490159 )
2014-11-19 08:46:43 +01:00
Aleksander Machniak
5f17657e82
Support contacts import in GMail CSV format
2014-08-14 18:19:55 +02:00
Aleksander Machniak
b58abd86c5
email:main -> email:pref
2014-04-15 18:38:39 +02:00
Aleksander Machniak
5983ee0f18
Fix categories/groups import from csv
2013-11-07 20:12:16 +01:00
Thomas Bruederli
0272081d05
Add option to import vcards with group assignments (pull-request 105)
2013-09-08 16:47:00 +02:00
Aleksander Machniak
3725cfb245
Avoid uninitialized/unused variables
2013-05-07 15:12:22 +02:00
Aleksander Machniak
0b0caee40b
Fix csv import from Thunderbird with French localization ( #1489059 )
2013-05-05 13:11:34 +02:00
Aleksander Machniak
38c19a2064
Fix csv2vcard test
2013-05-01 11:19:47 +02:00
Aleksander Machniak
609483d9f6
Support CSV import from Atmail ( #1489045 )
2013-04-30 15:05:41 +02:00
Aleksander Machniak
c59ef9542a
Support more Thunderbird CSV fields, added zh_TW localization for csv2vcard map ( #1488901 )
2013-01-11 09:02:45 +01:00
Aleksander Machniak
acf851f823
Fix address fields import from CSV ( #1488900 )
2013-01-07 17:53:37 +01:00
Aleksander Machniak
745d8697ba
Fix quoted data handling in CSV files ( #1488899 )
2013-01-07 15:06:09 +01:00
Aleksander Machniak
d2534c63f2
Cleanup, remove file paths from doc
2012-12-18 09:07:00 +01:00
Aleksander Machniak
a92beb6bdb
Define RCUBE_CHARSET in place of RCMAIL_CHARSET for naming consistency
2012-11-27 08:43:43 +01:00
Thomas Bruederli
9be2f43d02
Define more (uniquely prefixed) constants for Roundcube directories in order to enhance the interoperability of the Roundcube framework
2012-11-25 17:35:53 +01:00
