Mirrors/roundcubemail
2
0
Fork 0
mirror of https://github.com/roundcube/roundcubemail.git synced 2026-03-03 14:54:01 +01:00
Code Issues Packages Projects Releases Wiki Activity
13,320 Commits 72 Branches 205 Tags
html-allow-array-as-content
Commit Graph

49 Commits

Author SHA1 Message Date
Aleksander Machniak
fbdfb036ad Fix bug where an unhandled exception was caused by an invalid image attachment (#9475) 
GD functions may throw ValueError in some cases since PHP 8.0.
We wrap them in try/catch blocks.
 2024-07-21 14:23:28 +02:00
Aleksander Machniak
7da322371f Fix command injection via crafted im_convert_path/im_identify_path on Windows 
Reported by Huy Nguyễn Phạm Nhật.
 2024-05-19 10:10:32 +02:00
Aleksander Machniak
58d28297a3 Code improvements, PHPDoc fixes 2024-03-29 16:18:20 +01:00
Michael Voříšek
d18406a8bd Fix binary operator spaces CS (#9330) 
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
 2024-02-02 07:53:34 +01:00
Aleksander Machniak
34500a4fa4 Fix "missing return statement" phpstan errors 2024-01-27 19:07:52 +01:00
Michael Voříšek
4ee79b9e84 fix "explicit_string_variable" (#9315) 2024-01-22 08:05:59 +01:00
Michael Voříšek
b1a0067e5d Fix more CS (#9303) 
* fix "class_attributes_separation"

* fix "ternary_to_null_coalescing"

* fix "no_extra_blank_lines"

* fix "php_unit_data_provider_name" - use snake_case

* fix remaining "function data_" manually

* move "php_unit_test_case_static_method_calls" to a better place in cnf

* fix 3.47.1 CS
 2024-01-20 08:22:32 +01:00
Michael Voříšek
6a53a1d853 Fix CS (whitespace, visibility) (#9297) 
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
 2024-01-04 14:26:35 +01:00
Michael Voříšek
2643be3eaa Fix single quotes CS (#9283) 
* Fix "single_quote"

* fix "escape_implicit_backslashes"

* fix typo from f363481c

* fix single quotes in JS

* fix some minor JS CS

* fix CS v3.45.0
 2023-12-31 16:36:55 +01:00
Michael Voříšek
3e458fa5fd Refer native constants unambiguously (#9275) 
* Fix "native_constant_invocation" CS

* "self_accessor" was fixed in 9269 PR

* "php_unit_strict" was fixed in 9268 PR
 2023-12-23 17:02:19 +01:00
Michael Voříšek
e7d7e62146 Modernize more basic CS II (#9254) 
* fix "integer_literal_case"

* fix "phpdoc_separation"

* fix "phpdoc_var_without_name"

* fix "operator_linebreak"

* fix "no_alias_language_construct_call"

* fix "list_syntax"

* fix "concat_space"

* fix "array_syntax"

* fix "binary_operator_spaces"

* fix "binary_operator_spaces" relaxed

* fix "phpdoc_types_order"

* fix "phpdoc_trim"

* fix "native_type_declaration_casing"

* fix "method_chaining_indentation"

* fix "phpdoc_no_package"

* fix "elseif"

* fix PHP CS Fixer config itself too

* fix "native_type_declaration_casing"
 2023-12-17 13:14:45 +01:00
Michael Voříšek
1aef271290 Fix class/method names case typos (#9261) 
* fix Mail_Mime case

* fix StdErrMock case

* fix method calls case
 2023-12-16 15:39:59 +01:00
Michael Voříšek
a8707ae220 Fix and assert basic CS using CI (#9246) 
* Assert CS using CI

* fix "single_blank_line_at_eof"

* fix "statement_indentation"

* fix "switch_case_semicolon_to_colon"

* fix "control_structure_braces"

* fix "statement_indentation"

* fix "no_whitespace_in_blank_line"

* fix "no_trailing_whitespace_in_comment"

* fix "no_trailing_whitespace"

* fix "single_space_around_construct"

* fix "spaces_inside_parentheses"

* fix "ternary_operator_spaces"

* fix "trim_array_spaces"

* fix "whitespace_after_comma_in_array"

* fix "cast_spaces"

* fix "unary_operator_spaces"

* fix "no_trailing_comma_in_singleline"

* fix "ordered_imports"

* fix "no_unused_imports"

* Check composer.json format

* fix CI job name

* file header comments are not phpdoc

* fix "phpdoc_indent"

* fix "braces_position"

* fix "phpdoc_types"

* fix "no_blank_lines_after_class_opening"

* fix "no_multiple_statements_per_line"

* fix "multiline_comment_opening_closing"

* fix "single_line_empty_body"

* fix "non_printable_character"

* fix "phpdoc_trim_consecutive_blank_line_separation"

* fix "include"

* fix "no_mixed_echo_print"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
 2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a Fix invalid phpdocs (#9252) 
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
 2023-12-10 16:20:50 +01:00
Aleksander Machniak
d1bfe81731 Support conversion from webp formt using GD, improve is_convertable() 2023-04-10 12:32:14 +02:00
Aleksander Machniak
953be4bbe1 Fix so PHP warnings are ignored when resizing a malformed image attachment (#8387) 2022-01-08 09:16:43 +01:00
Aleksander Machniak
5ac44fd4ed PHPDoc fixes 2021-02-28 11:58:27 +01:00
Aleksander Machniak
066faa1485 CS fixes, short array syntax, PHP8 fixes, tests 
also fixed listing of table columns on SQLite database
 2020-11-28 10:06:41 +01:00
Aleksander Machniak
545a1569f1 Steps -> Actions refactoring (#7688) 
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
 2020-11-01 11:25:38 +01:00
Aleksander Machniak
a5c2b4360c Fixes in context of undefined variables, and code style 2020-08-15 12:13:31 +02:00
Aleksander Machniak
bda02002de Security: Better fix for CVE-2020-12641 2020-05-30 08:34:11 +02:00
Aleksander Machniak
4951d6603a Fix remote code execution via crafted 'im_convert_path' or 'im_identify_path' settings 2020-04-26 08:02:03 +02:00
Aleksander Machniak
e7ebff56df PHPDoc fixes 2019-09-30 20:43:07 +02:00
Aleksander Machniak
0869f02b7c Fix bug in converting multi-page Tiff images into Jpeg (#6824) 
When using 'convert' binary we have to use -flatten argument (the same
as we do with thumbnails) otherwise it will produce multiple output files
with -0, -1, etc. suffix. This way we make sure to generate only one image
until we support multi-page Tiff properly.
 2019-06-26 13:40:30 +02:00
Aleksander Machniak
57c67db029 Remove year(s) from copyright headers + some cleanup 2019-04-16 10:42:45 +02:00
Aleksander Machniak
d3c65d752b Remove useless "return null;" at the end of function block 2018-12-27 11:03:47 +01:00
Aleksander Machniak
b46cd5de1d Fix PHP Warning: exif_read_data(...): Illegal IFD size (#6169) 2018-02-12 15:48:23 +01:00
Aleksander Machniak
2f2765ab43 Fix regression in resizing JPEG images with Imagick (#5376) 2016-07-29 09:05:12 +02:00
Aleksander Machniak
7a7a6795f0 Support WEBP images in mail messages (#5362) 2016-07-21 16:42:45 +02:00
fliespl
10c032165b Remove deprecated function flattenImages 
flattenImages in imagick is deprecated since php 5.6. 
`PHP Deprecated:  Imagick::flattenImages method is deprecated and it's use should be avoided `


Proposed solution works with imagick 3.1.0+.
11 is used as an alternative to `Imagick::ALPHACHANNEL_REMOVE` which was added in imagick 3.2.0.
 2016-07-09 10:42:11 +02:00
Aleksander Machniak
bffca14d96 Exit when imagecreatetruecolor() fails 2016-01-19 09:37:29 +01:00
Aleksander Machniak
a03233ceba CS fixes 2015-10-07 09:14:18 +02:00
Aleksander Machniak
a958748947 CS fixes 2015-06-07 15:26:33 +02:00
Thomas Bruederli
5c9ddcc052 Check available memory for image resizing with GD on Windows (#1489937) 2014-11-03 15:49:49 +01:00
Aleksander Machniak
2979df5529 Call exif_read_data() only on JPEG images 2014-10-24 19:08:21 +02:00
Aleksander Machniak
4045cd9266 Cleanup after PR merge, updated changelog 2014-08-13 14:34:12 +02:00
brendan braybrook
090bacddb6 changes suggested by aleks 2014-08-12 18:39:55 +00:00
brendan braybrook
e2dd31f987 rotate image with GD if exit rotation data present 2014-08-11 23:23:36 +00:00
brendan braybrook
c6183b649a wrong type returned for gif 2014-08-11 23:21:02 +00:00
Aleksander Machniak
8968f9543f Support image operations with Imagick extension (#1489734) 2014-05-06 16:18:36 +02:00
Aleksander Machniak
328876db5c Fix image scaling issues when image has only one dimension smaller than the limit (#1489274) 
Other small code improvements.
 2013-08-09 10:15:51 +02:00
Aleksander Machniak
7015dd99f9 Added -stip option to convert command line (#1489270) 2013-08-03 09:35:16 +02:00
Aleksander Machniak
c908fb451d Fix colorspace issue on image conversion using ImageMagick (#1489270) - s/RGB/sRGB/ 2013-08-03 09:29:16 +02:00
Aleksander Machniak
1cdcafc7fc Added more error checking in rcube_image::resize() 2013-06-07 13:12:04 +02:00
Thomas Bruederli
b413bb2b60 Set minimal permissions to temp files (#148899) 2013-04-10 23:38:50 +02:00
Aleksander Machniak
139635f189 Fix thumbnail size when GD extension is used for image resize (#1488985) 2013-03-05 10:25:12 +01:00
Aleksander Machniak
9ac96015f2 Better GD module functions detection, should fix "Call to undefined function imagecreatefromjpeg()" error 2012-12-19 12:27:52 +01:00
Aleksander Machniak
d2534c63f2 Cleanup, remove file paths from doc 2012-12-18 09:07:00 +01:00
Aleksander Machniak
ba6f21caeb Framework files moved to lib/Roundcube 2012-11-21 19:52:03 +01:00