Aleksander Machniak
15659d7815
PHPCS: phpdoc_annotation_without_dot=true (default)
2024-04-14 10:32:35 +02:00
Aleksander Machniak
e086c2c97c
Code improvements
2024-04-07 09:20:52 +02:00
Aleksander Machniak
8adb052d35
Code improvements, PHPDoc fixes
2024-03-30 14:17:34 +01:00
Aleksander Machniak
a1f39f47b7
Fix phpstan errors
2024-02-10 19:20:04 +01:00
Michael Voříšek
d18406a8bd
Fix binary operator spaces CS ( #9330 )
...
* align_single_space_minimal for assign
* assign operators grouping is not supported by PHP CS Fixer
* binary_operator_spaces = single_space
* fix anonymous function on single line
* align comments manually
2024-02-02 07:53:34 +01:00
Aleksander Machniak
34500a4fa4
Fix "missing return statement" phpstan errors
2024-01-27 19:07:52 +01:00
Michael Voříšek
ff2d721680
Fix more CS whitespace ( #9318 )
...
* fix "no_useless_else" manually
* fix some "blank_line_before_statement"
* two manual changes
* Revert "fix some "blank_line_before_statement""
This reverts commit 2cc857c00e
2024-01-25 19:17:29 +01:00
Michael Voříšek
b1a0067e5d
Fix more CS ( #9303 )
...
* fix "class_attributes_separation"
* fix "ternary_to_null_coalescing"
* fix "no_extra_blank_lines"
* fix "php_unit_data_provider_name" - use snake_case
* fix remaining "function data_" manually
* move "php_unit_test_case_static_method_calls" to a better place in cnf
* fix 3.47.1 CS
2024-01-20 08:22:32 +01:00
Michael Voříšek
a797873ef5
Fix "phpdoc_no_empty_return" CS ( #9302 )
...
* replace void with never return type
* replace "return void" phpdoc with native type in tests
* replace "return void" phpdoc with native type in rcube_addressbook
* replace "return void" phpdoc with native type in rcmail_oauth
* fix remaining
2024-01-05 19:03:58 +01:00
Michael Voříšek
6a53a1d853
Fix CS (whitespace, visibility) ( #9297 )
...
* Fix "method_argument_space"
* Fix "control_structure_continuation_position"
* Fix "new_with_parentheses"
* Fix "blank_line_before_statement"
* Fix "visibility_required"
* Fix some "array_indentation"
* Fix some "array_indentation" - unify all "rcube::raise_error" calls
* rm useless eslint ignores and add rules counts
* sort eslint ignores
* fix eslint ignores grammar
* Revert "Fix "blank_line_before_statement""
* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
a9167a0d2f
Fix "static_lambda" CS ( #9276 )
2023-12-20 20:01:00 +01:00
Michael Voříšek
28c778b7a0
Modernize more CS III ( #9270 )
...
* fix "single_trait_insert_per_statement"
* fix "empty_loop_condition"
* fix "backtick_to_shell_exec"
* fix "phpdoc_to_comment"
* fix "no_empty_statement"
* fix "heredoc_to_nowdoc"
* fix "class_reference_name_casing"
* fix "align_multiline_comment"
* fix "heredoc_indentation"
* fix "constant_case"
* fix "single_line_comment_style"
* fix "no_null_property_initialization"
* fix "standardize_increment"
* fix "no_unneeded_control_parentheses"
* fix missing NL after "<?php"
* fix php in *.sh files too
* fix trailing spaces from all text files
* fix "explicit_indirect_variable"
* Revert "fix "align_multiline_comment""
This reverts commit 42e584f8e32101c2a3a3
2023-12-18 07:46:51 +01:00
Michael Voříšek
e7d7e62146
Modernize more basic CS II ( #9254 )
...
* fix "integer_literal_case"
* fix "phpdoc_separation"
* fix "phpdoc_var_without_name"
* fix "operator_linebreak"
* fix "no_alias_language_construct_call"
* fix "list_syntax"
* fix "concat_space"
* fix "array_syntax"
* fix "binary_operator_spaces"
* fix "binary_operator_spaces" relaxed
* fix "phpdoc_types_order"
* fix "phpdoc_trim"
* fix "native_type_declaration_casing"
* fix "method_chaining_indentation"
* fix "phpdoc_no_package"
* fix "elseif"
* fix PHP CS Fixer config itself too
* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191
Modernize more basic CS ( #9258 )
...
* fix "yoda_style"
* fix "is_null"
* rm useless rule ignores
* add full "PhpCsFixer:risky" ruleset
* fix "implode_call"
* fix "no_alias_functions"
* fix "array_push"
* fix "long_to_shorthand_operator"
* fix "ternary_to_elvis_operator"
* fix "logical_operators"
* fix "fopen_flags"
* rename "returns" phpdoc tags to "return"
* fix "php_unit_construct"
* fix "function_to_constant"
* fix "php_unit_data_provider_return_type"
* fix "php_unit_set_up_tear_down_visibility"
* some safe "string_length_to_empty"
* fix "phpdoc_align"
* fix "phpdoc_no_alias_tag"
* fix "trailing_comma_in_multiline"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-17 09:51:11 +01:00
Michael Voříšek
a8707ae220
Fix and assert basic CS using CI ( #9246 )
...
* Assert CS using CI
* fix "single_blank_line_at_eof"
* fix "statement_indentation"
* fix "switch_case_semicolon_to_colon"
* fix "control_structure_braces"
* fix "statement_indentation"
* fix "no_whitespace_in_blank_line"
* fix "no_trailing_whitespace_in_comment"
* fix "no_trailing_whitespace"
* fix "single_space_around_construct"
* fix "spaces_inside_parentheses"
* fix "ternary_operator_spaces"
* fix "trim_array_spaces"
* fix "whitespace_after_comma_in_array"
* fix "cast_spaces"
* fix "unary_operator_spaces"
* fix "no_trailing_comma_in_singleline"
* fix "ordered_imports"
* fix "no_unused_imports"
* Check composer.json format
* fix CI job name
* file header comments are not phpdoc
* fix "phpdoc_indent"
* fix "braces_position"
* fix "phpdoc_types"
* fix "no_blank_lines_after_class_opening"
* fix "no_multiple_statements_per_line"
* fix "multiline_comment_opening_closing"
* fix "single_line_empty_body"
* fix "non_printable_character"
* fix "phpdoc_trim_consecutive_blank_line_separation"
* fix "include"
* fix "no_mixed_echo_print"
---------
Co-authored-by: Aleksander Machniak <alec@alec.pl >
2023-12-16 15:37:43 +01:00
Michael Voříšek
5425d1a84a
Fix invalid phpdocs ( #9252 )
...
* fix missing return type in phpdoc
* fix "phpdoc_scalar"
* Fix phpdoc variable names typos
* fix wrong phpdoc tags
2023-12-10 16:20:50 +01:00
Aleksander Machniak
11ae5a14e4
Fix possible error in compare_search_value() ( #8823 )
2022-12-31 10:06:11 +01:00
Aleksander Machniak
78b3049ce5
Fix PHPDoc
2022-02-18 19:19:07 +01:00
Aleksander Machniak
f429b26810
Fix various PHP8 warnings ( #8392 )
2022-01-11 19:04:24 +01:00
Aleksander Machniak
2536e847d5
Fix one more warning
2021-10-21 19:54:41 +02:00
Aleksander Machniak
38f519659c
Fix some PHP8 warnings ( #8239 )
2021-10-21 19:52:04 +02:00
Aleksander Machniak
f2688ba492
Use ?? operator where applicable
2021-09-21 19:12:06 +02:00
Aleksander Machniak
5043255f7e
Example_addressbook: Various improvements and fixes
2021-06-09 15:33:40 +02:00
Michael Stilkerich
74fab3e730
More extensive documentation for query-related rcube_addressbook API ( #7958 )
...
Also add list_records()'s $nocount parameter to all implementations
2021-05-15 14:15:21 +02:00
Josh Soref
203f456620
Spelling ( #8001 )
2021-04-18 08:43:18 +02:00
Michael Stilkerich
0608af9814
phpdoc type annotations to aid static analysis tools ( #7957 )
2021-03-21 14:39:17 +01:00
Aleksander Machniak
5ac44fd4ed
PHPDoc fixes
2021-02-28 11:58:27 +01:00
Aleksander Machniak
a03a1db73c
Tabs to spaces
...
[skip ci]
2021-02-06 16:59:05 +01:00
Michael Stilkerich
ae3f9c215e
Improve preciseness of some PHPdoc annotations ( #7809 )
2021-01-09 10:05:46 +01:00
Aleksander Machniak
17ae3693c3
PHP8 fixes + fix fatal error when refreshing compose page in forward-as-attachment state
2020-12-18 19:27:25 +01:00
Aleksander Machniak
3bbb01fe13
PHP8 fixes, regression fixes
2020-12-13 12:14:15 +01:00
Michael Stilkerich
208e627198
Restore compatibility in rcube_addressbook::set_sort_order API ( #7758 )
2020-12-06 20:38:15 +01:00
Aleksander Machniak
66ca4f0f72
CS fixes, PHP8 fixes, short array syntax, tests
2020-11-30 14:03:11 +01:00
Aleksander Machniak
37d75d96a3
Short array syntax, CS fixes
2020-11-27 19:51:33 +01:00
Michael Stilkerich
bad1dedbf6
Phpdoc type annotations ( #7733 )
2020-11-21 09:34:24 +01:00
Aleksander Machniak
97991b59be
Add more tests for contact actions, fix various code issues
2020-11-05 11:59:02 +01:00
Aleksander Machniak
e99fb3968d
Add tests for contacts export action, fix PHP8 issues
2020-11-02 18:49:39 +01:00
Aleksander Machniak
e2572b8984
PHP8 compat. fixes, added some tests
2020-11-02 08:55:42 +01:00
Aleksander Machniak
545a1569f1
Steps -> Actions refactoring ( #7688 )
...
* Move action handling code to rcmail class
* Add rcmail_action class
* Add action aliases
* Get rid of $OUTPUT global
* Move some methods from rcmail to rcmail_action
* PHP8 compat. fixes
* Add framework for testing actions
* Fix obvious code mistakes
2020-11-01 11:25:38 +01:00
Aleksander Machniak
9713ce364c
Automatically collected recipients and trusted senders ( #6904 )
...
Added configurable Collected Recipients addressbook source (#4971 )
Added configurable Trusted Senders addressbook source (#5046 )
Added 'contact_exists' hook
2020-09-20 10:00:08 +02:00
Aleksander Machniak
a5c2b4360c
Fixes in context of undefined variables, and code style
2020-08-15 12:13:31 +02:00
Michael Stilkerich
25e42439d2
Fix inconsistencies in phpdoc type annotations ( #7474 )
2020-07-25 09:59:01 +02:00
Aleksander Machniak
66fab8cdb2
CS fixes, Avoid usused variables, fixed minor bugs
2019-10-05 19:44:39 +02:00
Aleksander Machniak
1afa46d28d
PHPDoc and CS fixes
2019-08-25 14:15:09 +02:00
Aleksander Machniak
57c67db029
Remove year(s) from copyright headers + some cleanup
2019-04-16 10:42:45 +02:00
Aleksander Machniak
d3c65d752b
Remove useless "return null;" at the end of function block
2018-12-27 11:03:47 +01:00
Aleksander Machniak
6691756ea1
Fix bug where unicode contact names could have been broken/emptied or caused DB errors ( #6299 )
2018-05-25 12:29:36 +02:00
Aleksander Machniak
ce338164e3
Fix bug where contacts search could skip some records ( #6130 )
2018-01-10 11:52:35 +01:00
Aleksander Machniak
d151afd229
Fix addressbook searching by gender ( #5757 )
2017-05-11 08:56:42 +02:00
Aleksander Machniak
9b554cd3d5
Remove redundant spaces from generated contact names
2017-03-20 09:15:50 +01:00
