Commit Graph

24 Commits

Author SHA1 Message Date
Philip Weir
ccede1f272 Update links in comments and config to https where available (#9759) 2025-01-26 13:34:57 +01:00
Aleksander Machniak
89d429dbee Fix two new phpstan issues 2024-08-02 09:12:48 +02:00
Aleksander Machniak
8b11a9843e Cleanup raise_error() use in password drivers 2024-05-16 19:29:08 +02:00
Aleksander Machniak
ad25c6f7ce Password: Use Guzzle HTTP Client in the domainfactory driver 2024-04-21 16:58:53 +02:00
Aleksander Machniak
e1925c47a4 Code improvements 2024-04-07 11:27:01 +02:00
Michael Voříšek
d18406a8bd Fix binary operator spaces CS (#9330)
* align_single_space_minimal for assign

* assign operators grouping is not supported by PHP CS Fixer

* binary_operator_spaces = single_space

* fix anonymous function on single line

* align comments manually
2024-02-02 07:53:34 +01:00
Michael Voříšek
ff2d721680 Fix more CS whitespace (#9318)
* fix "no_useless_else" manually

* fix some "blank_line_before_statement"

* two manual changes

* Revert "fix some "blank_line_before_statement""

This reverts commit 2cc857c00e.

* fix some "blank_line_before_statement" using patched fixer (after "}" only)

* fix continue/break too
2024-01-25 19:17:29 +01:00
Michael Voříšek
6a53a1d853 Fix CS (whitespace, visibility) (#9297)
* Fix "method_argument_space"

* Fix "control_structure_continuation_position"

* Fix "new_with_parentheses"

* Fix "blank_line_before_statement"

* Fix "visibility_required"

* Fix some "array_indentation"

* Fix some "array_indentation" - unify all "rcube::raise_error" calls

* rm useless eslint ignores and add rules counts

* sort eslint ignores

* fix eslint ignores grammar

* Revert "Fix "blank_line_before_statement""

* fix CS 3.46.0
2024-01-04 14:26:35 +01:00
Michael Voříšek
3e458fa5fd Refer native constants unambiguously (#9275)
* Fix "native_constant_invocation" CS

* "self_accessor" was fixed in 9269 PR

* "php_unit_strict" was fixed in 9268 PR
2023-12-23 17:02:19 +01:00
Michael Voříšek
e7d7e62146 Modernize more basic CS II (#9254)
* fix "integer_literal_case"

* fix "phpdoc_separation"

* fix "phpdoc_var_without_name"

* fix "operator_linebreak"

* fix "no_alias_language_construct_call"

* fix "list_syntax"

* fix "concat_space"

* fix "array_syntax"

* fix "binary_operator_spaces"

* fix "binary_operator_spaces" relaxed

* fix "phpdoc_types_order"

* fix "phpdoc_trim"

* fix "native_type_declaration_casing"

* fix "method_chaining_indentation"

* fix "phpdoc_no_package"

* fix "elseif"

* fix PHP CS Fixer config itself too

* fix "native_type_declaration_casing"
2023-12-17 13:14:45 +01:00
Michael Voříšek
ca8b17d191 Modernize more basic CS (#9258)
* fix "yoda_style"

* fix "is_null"

* rm useless rule ignores

* add full "PhpCsFixer:risky" ruleset

* fix "implode_call"

* fix "no_alias_functions"

* fix "array_push"

* fix "long_to_shorthand_operator"

* fix "ternary_to_elvis_operator"

* fix "logical_operators"

* fix "fopen_flags"

* rename "returns" phpdoc tags to "return"

* fix "php_unit_construct"

* fix "function_to_constant"

* fix "php_unit_data_provider_return_type"

* fix "php_unit_set_up_tear_down_visibility"

* some safe "string_length_to_empty"

* fix "phpdoc_align"

* fix "phpdoc_no_alias_tag"

* fix "trailing_comma_in_multiline"

---------

Co-authored-by: Aleksander Machniak <alec@alec.pl>
2023-12-17 09:51:11 +01:00
Aleksander Machniak
14a94cf0d7 PHP8 fixes, CS fixes, short array syntax, tests 2020-12-09 21:11:46 +01:00
Aleksander Machniak
66fab8cdb2 CS fixes, Avoid usused variables, fixed minor bugs 2019-10-05 19:44:39 +02:00
Aleksander Machniak
57c67db029 Remove year(s) from copyright headers + some cleanup 2019-04-16 10:42:45 +02:00
Aleksander Machniak
60922dc3d5 Password: Added password_username_format option (#5766) 2018-04-23 19:01:35 +02:00
Aleksander Machniak
30f9839b46 Remove redundant code 2017-05-19 07:37:00 +02:00
Aleksander Machniak
4baf96a4ca Added license headers to driver files, CS fixes 2014-09-08 09:50:59 +02:00
Aleksander Machniak
524e382669 Merge pull request #168 from tillkruess/master
another security fix for domainfactory password plugin driver
2014-02-13 08:02:45 +01:00
Till Krüss
aba993da6a prevent unwanted code execution via CURLOPT_POSTFIELDS (again) 2014-02-13 09:40:17 +05:30
Aleksander Machniak
e7881f058a Merge pull request #166 from tillkruess/master
security fix for domainfactory password plugin driver
2014-02-10 18:27:50 +01:00
Till Krüss
334475a50b prevent unwanted code execution via CURLOPT_POSTFIELDS 2014-02-10 21:32:06 +05:30
Till Krüss
910a3581be check if password was changed successfully, before looking for error messages 2013-10-15 18:13:24 +08:00
Till Krüss
0f4c9b850f check if the new password matched the requirements; code cleanup 2013-10-15 17:56:03 +08:00
thomascube
48e9c14ebd Move plugins repository into roundcubemail root folder; svn:externals are not defined anymore 2012-03-31 12:25:48 +00:00